[Solved | 1.7.10] How to detect Right Clicks with items?

[noahc3]

Hey, I'm having some issues with detecting right clicks with an item.

 

Here is the code I'm using:

 

public ItemStack onItemRightClick(ItemStack itemstack, World par2World, EntityPlayer par3EntityPlayer)
{
        if(itemstack.stackTagCompound.getInteger("enabled") == 1)
        {
        	itemstack.stackTagCompound.setInteger("enabled", 0);
		System.out.println("Was Enabled, now Disabled");
             return null;
        }
        else
        {
        	itemstack.stackTagCompound.setInteger("enabled", 1);
		 System.out.println("Was Disabled, now Enabled");
		 return null;
        }
}

 

Minecraft successfully loads, but right clicking the item crashes the game. (But it does detect the right click as sysout prints to console)

 

Any help would be appreciated.

[Guest]

Show your crash report. If it is a NullPointerException, they are easy to diagnose.

[Guest]

Wait... Why are you returning null??? You have to return the itemstack provided (I'm pretty sure). I think that's why if it is a null pointer. Problem solved.

[coolAlias]

  On 7/12/2015 at 4:22 AM, Awesome_Spider said:

Wait... Why are you returning null??? You have to return the itemstack provided (I'm pretty sure). I think that's why if it is a null pointer. Problem solved.

No, you can return null to set the current item to nothing. EDIT: I stand corrected

 

@OP Your problem is you are using the NBT tag directly without checking if it exists - ItemStacks generally do not have an NBT tag until you give them one.

if (!itemstack.hasTagCompound()) {
   itemstack.setTagCompound(new NBTTagCompound());
}

[noahc3]

@AwesomeSpider Thanks, switching it to return itemstack fixed it. Yea, it was a nullpointer exception.

 

@coolAlias I have created the NBT tag further in the code with this:

 

if(itemstack.stackTagCompound == null){
		 itemstack.stackTagCompound = new NBTTagCompound();
		 itemstack.stackTagCompound.setInteger("timer", 24000);
		 itemstack.stackTagCompound.setInteger("enabled", 0);
		 }

 

 

Thanks for the help.

 

That's inside onUpdate.