[1.8] Custom stairs and slabs issue

[krikke93]

Hi everyone, I'm having some problems with getting my custom stair and slab blocks to work properly.

 

I'll start with my stairs, since those are almost complete.

The problem I'm having is a lighting issue as you can see in this screenshot: http://puu.sh/j5own/753e2aa570.jpg

 

Stairs Class:

public class ExtraStairsBlock extends BlockStairs {

public ExtraStairsBlock(IBlockState modelState, String name) {
	super(modelState);
	setUnlocalizedName(name);
	setCreativeTab(ExpansionMod.tabBlocks);
}

}

 

Stairs modelstate json:

{
    "variants": {
        "facing=east,half=bottom,shape=straight":  { "model": "em:mahogany_stairs" },
        "facing=west,half=bottom,shape=straight":  { "model": "em:mahogany_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=straight": { "model": "em:mahogany_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=straight": { "model": "em:mahogany_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_right":  { "model": "em:mahogany_outer_stairs" },
        "facing=west,half=bottom,shape=outer_right":  { "model": "em:mahogany_outer_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=outer_right": { "model": "em:mahogany_outer_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=outer_right": { "model": "em:mahogany_outer_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=outer_left":  { "model": "em:mahogany_outer_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=outer_left":  { "model": "em:mahogany_outer_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=outer_left": { "model": "em:mahogany_outer_stairs" },
        "facing=north,half=bottom,shape=outer_left": { "model": "em:mahogany_outer_stairs", "y": 180, "uvlock": true },
        "facing=east,half=bottom,shape=inner_right":  { "model": "em:mahogany_inner_stairs" },
        "facing=west,half=bottom,shape=inner_right":  { "model": "em:mahogany_inner_stairs", "y": 180, "uvlock": true },
        "facing=south,half=bottom,shape=inner_right": { "model": "em:mahogany_inner_stairs", "y": 90, "uvlock": true },
        "facing=north,half=bottom,shape=inner_right": { "model": "em:mahogany_inner_stairs", "y": 270, "uvlock": true },
        "facing=east,half=bottom,shape=inner_left":  { "model": "em:mahogany_inner_stairs", "y": 270, "uvlock": true },
        "facing=west,half=bottom,shape=inner_left":  { "model": "em:mahogany_inner_stairs", "y": 90, "uvlock": true },
        "facing=south,half=bottom,shape=inner_left": { "model": "em:mahogany_inner_stairs" },
        "facing=north,half=bottom,shape=inner_left": { "model": "em:mahogany_inner_stairs", "y": 180, "uvlock": true },
        "facing=east,half=top,shape=straight":  { "model": "em:mahogany_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=straight":  { "model": "em:mahogany_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=straight": { "model": "em:mahogany_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=straight": { "model": "em:mahogany_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_right":  { "model": "em:mahogany_outer_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=outer_right":  { "model": "em:mahogany_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=outer_right": { "model": "em:mahogany_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=outer_right": { "model": "em:mahogany_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=outer_left":  { "model": "em:mahogany_outer_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=outer_left":  { "model": "em:mahogany_outer_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=outer_left": { "model": "em:mahogany_outer_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=outer_left": { "model": "em:mahogany_outer_stairs", "x": 180, "uvlock": true },
        "facing=east,half=top,shape=inner_right":  { "model": "em:mahogany_inner_stairs", "x": 180, "uvlock": true },
        "facing=west,half=top,shape=inner_right":  { "model": "em:mahogany_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=south,half=top,shape=inner_right": { "model": "em:mahogany_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=north,half=top,shape=inner_right": { "model": "em:mahogany_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=east,half=top,shape=inner_left":  { "model": "em:mahogany_inner_stairs", "x": 180, "y": 90, "uvlock": true },
        "facing=west,half=top,shape=inner_left":  { "model": "em:mahogany_inner_stairs", "x": 180, "y": 270, "uvlock": true },
        "facing=south,half=top,shape=inner_left": { "model": "em:mahogany_inner_stairs", "x": 180, "y": 180, "uvlock": true },
        "facing=north,half=top,shape=inner_left": { "model": "em:mahogany_inner_stairs", "x": 180, "uvlock": true }
    }
}

 

----------

 

My second problem I'm having is with custom slabs. These seem a lot harder than stairs, or I might be doing something wrong.

Everything seems fine with the textures. The only problem I'm having is that I can't seem to get two slabs to stack onto each other to become a double slab.

 

Custom Slab class:

public class ExtraSlabBlock extends BlockSlab {

private boolean isDouble;

public ExtraSlabBlock(String name, boolean isDouble) {
	super(Material.wood);

	String newname = "";
	if(isDouble) newname += "double_";
	setUnlocalizedName(newname+name);

	if(!isDouble) setCreativeTab(ExpansionMod.tabBlocks);
	this.isDouble = isDouble;

	IBlockState iblockstate = this.blockState.getBaseState();
        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, BlockSlab.EnumBlockHalf.BOTTOM);
        }
        this.setDefaultState(iblockstate);
        
        this.useNeighborBrightness = !this.isDouble();
}

@Override
protected BlockState createBlockState()
    {
        return new BlockState(this, new IProperty[] {HALF});
    }

@Override
    public final IBlockState getStateFromMeta(final int meta) {
        IBlockState blockState = this.getDefaultState();
        if (!this.isDouble()) {
            EnumBlockHalf value = EnumBlockHalf.BOTTOM;
            if ((meta &  != 0) {
                value = EnumBlockHalf.TOP;
            }

            blockState = blockState.withProperty(HALF, value);
        }

        return blockState;
    }

@Override
public int getMetaFromState(IBlockState state)
    {
	if (this.isDouble()) {
           return 0;
        }

        if ((EnumBlockHalf) state.getValue(HALF) == EnumBlockHalf.TOP) {
            return 8;
        } else {
            return 0;
        }
    }

public String getId()
  {
    return isDouble() ? "slab_double" : "slab";
  }

@Override
public boolean isDouble()
    {
        return isDouble;
    }

@Override
public String getUnlocalizedName(int meta) {
	return getUnlocalizedName();
}

@Override
public IProperty getVariantProperty() {
	return null;
}

@Override
public Object getVariant(ItemStack stack) {
	return null;
}

}

 

Slab modelstate json:

{
    "variants": {
        "half=bottom": { "model": "em:mahogany_half_slab" },
        "half=top": { "model": "em:mahogany_upper_slab" }
    }
}

 

Slab registering:

...
public static Block mahogany_slab;
public static Block double_mahogany_slab;
...
mahogany_slab = new ExtraSlabBlock("mahogany_slab", false);
double_mahogany_slab = new ExtraSlabBlock("mahogany_slab", true);
...
GameRegistry.registerBlock(mahogany_slab, mahogany_slab.getUnlocalizedName().substring(5));
GameRegistry.registerBlock(double_mahogany_slab, double_mahogany_slab.getUnlocalizedName().substring(5));
...
registerRender(mahogany_slab);
registerRender(double_mahogany_slab);
...

[EverythingGames]

Hi

Override the isFullCube() boolean in your block class and return false.

[krikke93]

Although I indeed forgot to Override isFullCube() in both classes, it didn't solve my problems

Thanks for the suggestion though, I'm hoping someone sees what I'm doing wrong.

 

- Krikke

[TheGreyGhost]

Hi

 

Try setting

useNeighborBrightness = true

in your block's constructor

 

http://www.minecraftforge.net/forum/index.php/topic,32060.msg167789.html#msg167789

 

-TGG

[krikke93]

Thanks, that solved my Stairs issue. Now I just need to find a way to make slabs stack to become a double_slab.