Search the Forums BEFORE making a new post.

[SOLVED]Getting OreDictionary names for an item not working right

Start new topic

Posted July 25, 201510 yr

Hey guys, I am trying to get a list of OreDictionary names for an item and render it in the item's tooltip. I have the following code so far:

@SubscribeEvent
public void tooltipEvent(ItemTooltipEvent event){
	String[] oreDict = getOreNames(event.itemStack);
	for(int i=0;i<oreDict.length;i++){
		event.toolTip.add(EnumChatFormatting.GREEN+oreDict[i]);
	}
}
public String[] getOreNames(ItemStack stack){
	int[] ids = OreDictionary.getOreIDs(stack);
	String[] list = new String[ids.length];
	for(int i=0;i<ids.length;i++){
		list[i] = OreDictionary.getOreName(i);
	}
	return list;
}

When moused over, anything with 1 oredictionary name says logWood, anything with 2 says logWood and plankWood, and I haven't tested anything with 3 or more, as nothing in vanilla Minecraft has that many.

Does anyone know how I can fix this? Any help is appreciated.

EDIT: Fixed it. Here is the fixed code if anyone wants to see it:

@SubscribeEvent
public void tooltipEvent(ItemTooltipEvent event){
	event.toolTip.add(EnumChatFormatting.BLUE+modThatAddedStack(event.itemStack));
	String[] oreDict = getOreNames(event.itemStack);
	for(int i=0;i<oreDict.length;i++){
		event.toolTip.add(EnumChatFormatting.GREEN+oreDict[i]);
	}
}
public String[] getOreNames(ItemStack stack){
	int[] ids = OreDictionary.getOreIDs(stack);
	String[] list = new String[ids.length];
	for(int i=0;i<ids.length;i++){
		list[i] = OreDictionary.getOreName(ids[i]);
	}
	return list;
}

If I helped please press the Thank You button.

Check out my mods at http://www.curse.com/users/The_Fireplace/projects

This topic is now closed to further replies.

https://forums.minecraftforge.net/topic/32231-solvedgetting-oredictionary-names-for-an-item-not-working-right/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Small tip for beginners: How to avoid common JSON model errors in Forge

It takes some setting up and figuring out, but using data generators will ensure there are no json errors.

By Ugdhar · 3 hours ago3 hr
Small tip for beginners: How to avoid common JSON model errors in Forge

I wanted to share something that helped me when I started creating custom blocks and items.
A lot of new modders get stuck because of tiny JSON syntax mistakes in blockstate or model files.
A few simple tips:
Always validate your JSON using an online validator
Make sure your paths match exactly (Forge is case-sensitive)
Check that all textures are referenced from the correct namespace
If your model is invisible, 90% of the time it’s a missing comma or wrong folder name
Hopefully this helps someone avoid an hour of debugging like it did for me.
Best regards,
Myroslav Mokhammad Abdeljawwad

By Myroslav Mokhammad Abdelja · Posted 3 hours ago3 hr
Help understanding basic event handling in Forge 1.20.1

Hi everyone,
I recently started learning Forge modding and I’m trying to understand the proper way to handle simple gameplay events in Forge 1.20.1.
Right now, I’m experimenting with detecting when a player right-clicks with a custom item, but I’m a bit confused about which event bus I should be using and where the listener should be registered.
If someone could clarify the difference between the mod event bus vs the Forge event bus in the context of input / item-use events, that would really help. And if you have a small code example, even better.
Thanks in advance!
— Myroslav Mokhammad Abdeljawwad

By Myroslav Mokhammad Abdelja · Posted 3 hours ago3 hr
Latest builds of 1.21.X versions crashing

I didn't dig deeply into this but it looks like this is happening on all versions recently migrated to Github Actions. Perhaps a build step is messed up there.

By lordsherman · 7 hours ago7 hr
Latest builds of 1.21.X versions crashing

Hello,

I noticed many subversions of 1.21.X were updated since last night and all have now started to produce this error when attempting to start up:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
at net.minecraftforge.bootstrap.shim.Main$ListEntry.getPathFrom(Main.java:142)
at net.minecraftforge.bootstrap.shim.Main$ListEntry.access$000(Main.java:129)
at net.minecraftforge.bootstrap.shim.Main.main(Main.java:49)

I use the shim jar file to run this, and when reverting to previous builds, it works just fine.

This includes: 1.21.10, 1.21.8, 1.21.5, 1.21.4, 1.21.3, and 1.21.1

By lordsherman · Posted 7 hours ago7 hr

Ugdhar

Sign In

[SOLVED]Getting OreDictionary names for an item not working right

Featured Replies

Posts

Small tip for beginners: How to avoid common JSON model errors in Forge

Small tip for beginners: How to avoid common JSON model errors in Forge

Help understanding basic event handling in Forge 1.20.1

Latest builds of 1.21.X versions crashing

Latest builds of 1.21.X versions crashing

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)