Jump to content

[1.8] Problems with recursion and block finding?


Ferrettomato

Recommended Posts

I'm trying to make use BlockEvent.BreakEvent to allow the player to chop down trees that are multiple blocks wide all at once, but all kinds of things are going wrong. It counts all blocks as wood, even if they're not, and it always thinks that positions have already been used. (so, basically, all the breaks are being tripped every time.) I honestly don't know why this is happening, can anyone enlighten me?

 

Notes:

* I've tried using Block#isWood, it doesn't help.

* I've also tried comparing the individual co-ordinates in the BlockPoses instead of .equals'ing them, it doesn't help.

 

Code:

@SubscribeEvent
public void treecapitate(BlockEvent.BreakEvent event)
{
	if(event.state.getBlock().isWood(event.world, event.pos))
	{
		chopTree(event.world, event.pos, new ArrayList<BlockPos>(128));
	}
}

public void chopTree(World world, BlockPos pos, List<BlockPos> done)
{
	done.add(pos);

	for(int i = 2; i <= 5; i++)
	{
		BlockPos target = pos.offset(EnumFacing.getFront(i));
		System.out.println(target.toString());

		if(world.getBlockState(target).getBlock().equals(Blocks.log));
		{
			System.out.println("Found wood!");
			boolean stop = false;

			for(BlockPos donepos : done)
			{
				System.out.println(donepos.toString());
				if(donepos.equals(target))
				{
					stop = true;
					break;
				}
			}
			if(stop = false)
			{
				chopTree(world, target, done);
			}
			else
				System.out.println("Been there, done that!");
		}
	}
	while(world.getBlockState(pos.up()).getBlock().isWood(world, pos.up()))
	{
		world.destroyBlock(pos.up(), true);
		pos = pos.up();
	}
}

Console output when the player harvests the northwest corner of a 2x2 tree:

Note: The actual donepos should have been 2180/65/-1499.

BlockPos{x=2180, y=65, z=-1501}
Found wood!
BlockPos{x=2180, y=65, z=-1500}
Been there, done that!
BlockPos{x=2180, y=65, z=-1499}
Found wood!
BlockPos{x=2180, y=65, z=-1500}
Been there, done that!
BlockPos{x=2179, y=65, z=-1500}
Found wood!
BlockPos{x=2180, y=65, z=-1500}
Been there, done that!
BlockPos{x=2181, y=65, z=-1500}
Found wood!
BlockPos{x=2180, y=65, z=-1500}
Been there, done that!

Link to comment
Share on other sites

You are making the code way more convoluted than you need to: why use a List at all, when you are already iterating over positions? Make your iteration logic do the work.

 

Another thing - if you are going to use the position above the current one, use pos.up() once as an assignment, like so:

// or however you want to check if it's a log, perhaps there's a Forge method
while (world.getBlockState(pos).getBlock() instanceof BlockLog) {
   // destroy the block
   world.destroyBlock(pos, true);

   // this is also where you should check the surrounding blocks
   // but those can also be long branches, so you should probably come up with a better system than this
   // which only goes up and possibly one block to each side (I'm not writing that, though)

   // finally move up one position
   pos = pos.up();
}

 

Also, check your code for errors - you surely meant to use == here:

if(stop = false)

And be careful using .equals - that's usually not what you want.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • im stuck in a problem whit BlockEntities i cannot solve so im trying to work around it but in the less complex way possible  i think is posible to store data to the minecraft world  in older versions people talk about  WordDataSave i dont find anything about it for 1.20.4  i find a tutorial for player capability in 1.19    here is an event      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesPlayer(AttachCapabilitiesEvent<Entity> event) {         if(event.getObject() instanceof Player) {             if(!event.getObject().getCapability(PlayerThirstProvider.PLAYER_THIRST).isPresent()) {                 event.addCapability(new ResourceLocation(mercmod.MOD_ID, "properties"), new PlayerThirstProvider());             }         }     }  soo i made this      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesLevel(AttachCapabilitiesEvent<Level> event) {     } i think i can do some witchcraft  here  but is many things don't understand  to start whit i dont get yet how to recall the saved data from a BlockEntity  the handler still in progress the plan is to make a Map to store nbt data using the block coordinates as index later store that map as a big nbt      ########## any way the question is if theres alredy a tutorial for 1.20.4 for this ?? or some alredy working code from someone else doing something similar ?           
    • I tried this, and found out that Oculus is the mod that is crashing the game. I have removed it, and it now works fine! Thanks!
    • Hi @DanielderErbauer, I arrived here as I have the "as it does not exist in Block{minecraft:air}" error in a modpack I am trying to start. It's a long-shot, I know, but as the post that led this to being solved is missing, can I ask if you may recall what it said? Thanks in advance
    • Hm yeah sorry, not seeing anything else that's sticking out, I'd need to debug myself probably. Do you have a github or bitbucket repo? I could poke around when I have time to see what the problem might be.
    • looking around for the capabilities thing i found a piece of code and find this piece of code  //########## ########## ########## ########## @SubscribeEvent public static void addCustomTrades(VillagerTradesEvent event) { if(event.getType() == VillagerProfession.FLETCHER) { System.out.println("\n\n### VillagerProfession.FLETCHER \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.ARROW_STEEL.get(), 16); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,1,3,0.02F)); } if(event.getType() == VillagerProfession.TOOLSMITH) { System.out.println("\n\n### VillagerProfession.TOOLSMITH \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.INGOT_STEEL.get(), 1); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,10,8,0.02F)); } } //########## ########## ########## ########## the event is aknoledge and execute when the maps load  ### VillagerProfession.FLETCHER  ### VillagerProfession.TOOLSMITH  //########## But is not working      is a random piece of code is not working  could it be than this code is old 1.18 and no valid anymore for 1.20.4 or the thing are this numbers  stack,10,8,0.02F));  i dont know what this numbers means    ########## the question is ¿how to add things to the villager traders    thanks for your attention               
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.