Entity wont drop

[Mr.sKrabs]

I've been attempting to make a squid drop a Kalamari and it not going really good,I dont understand where is the problem,

I wrote that it will have 60 precent chance to give between 1 to 2

https://gist.github.com/anonymous/5bebd96b61c95ad71106

[EverythingGames]

Hi, that random generated int looks confusing, the event code looks correct (at a quick glance). Here is an cleaner alternative which will convert a double to an int, while giving you a value 0-3 inclusive (1 or 2):

@SubscribeEvent 
public void livingDropsEvent(LivingDropsEvent event)
{ 

    Item item = YOURITEM;
    int random = (int) Math.random * 3;

    if(event.entityLiving instanceof EntitySquid) 
    { 
        event.entityLiving.dropItem(item, random);
    }

}

[Mr.sKrabs]

https://gist.github.com/anonymous/74662918de176465e39a

Does not work,Did i do something wrong?.

[Mr.sKrabs]

Bro your code does not work.

Wont drop the item from the squid

[Mr.sKrabs]

And how do i add them to the list?

[Ernio]

I am guessing: event.drops.add

[EverythingGames]

C'mon man, I haven't used that event because my mod doesn't involve what your doing, but I'm guessing the list within the event - what other list is there?

[Mr.sKrabs]

No shit sherlock did it doesn't work

 

Give me the code brah

[Mr.sKrabs]

After trying to make it work I tried this

 

package com.drunksmanknife.harshnature.init;

 

import java.util.Random;

 

import net.minecraft.entity.item.EntityItem;

import net.minecraft.entity.passive.EntitySquid;

import net.minecraft.item.Item;

import net.minecraft.item.ItemStack;

import net.minecraftforge.event.entity.living.LivingDropsEvent;

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

 

public class ModLivingDropsEvent {

 

public static double rand;

public Random r = new Random();

 

@SubscribeEvent

public void onEntityDrop(LivingDropsEvent event) {

 

 

Item item = HarshNatureItems.Kalamari;

    int r = (int) Math.random() * 3;

 

    if(event.entityLiving instanceof EntitySquid)

    {

 

    ItemStack stack = new ItemStack(HarshNatureItems.Kalamari, r);

    EntityItem drop = new EntityItem(event.entity.worldObj, event.entity.posX, event.entity.posY, event.entity.posZ, stack);

   

    event.drops.add(drop);

    }

 

}

}

[Mr.sKrabs]

Yeap

MinecraftForge.EVENT_BUS.register(new ModLivingDropsEvent());

This is the PreInit

[EverythingGames]

Then create a random object and use the nextInt() method. The random code should not be difficult.

[EverythingGames]

Casting the int to the Math surrounded in parenthesis was what I forgot to add in my earlier post. Simple mistake on my part.

[Mr.sKrabs]

https://gist.github.com/anonymous/2aa2b8c655f69c58a685

 

Got it to work,as it drops 35% of the time problem it wont drop randomly it will always drop 2 Kalamari from a squid

[Mr.sKrabs]

Now it wont drop at all....

[Mr.sKrabs]

https://gist.github.com/anonymous/84e9e793da3753079517

 

Successfully working,50,50 drop rate of 2 and 3

 

You can close this thread here is the solution for someone out there who was the same problem

 

Btw i didn't think I wasn't the only one

Here is a quote of a guy who had the same problem

 

I was in your position 3 years ago (I was 12) and, honestly a lot people expect you to know a good amount about Minecraft mod creation before posting. My first mod I just added everything I could think of. Might seem stupid but, it broadened my knowledge to a very far extent. Now I am creating a Java game just from trial and error. Keep going and never give up even when the going gets tough!

[EverythingGames]

Good job getting it working...as for te quote saying we expect people to know a good amount of Minecraft modding, rather it should say, "we expect you to know a good amount of Java."