[1.8] Updating Schematic Converter code to 1.8 for generating structures

[codenymph]

Hi,

 

I've used MrPonyCaptain's Schematic Converter to convert a schematic file (from MCEdit) to java. I debugged a whole lot and changed things, but my structure doesn't seem to be generating. Any ideas as to what's going wrong? (Currently, Eclipse is not showing any errors in my code, but it still doesn't seem to be working)

 

WorldGenshelter.java

 

 

/*

*** MADE BY MRPONYCAPTAIN'S .SCHEMATIC TO .JAVA CONVERTING TOOL v2.0 ***

*/

 

package com.cscarlett.mod1;

 

import java.util.Random;

 

import net.minecraft.block.Block;

import net.minecraft.block.state.IBlockState;

import net.minecraft.init.Blocks;

import net.minecraft.util.BlockPos;

import net.minecraft.world.World;

import net.minecraft.world.chunk.IChunkProvider;

import net.minecraft.world.gen.feature.WorldGenerator;

import net.minecraftforge.fml.common.IWorldGenerator;

 

public class WorldGenshelter extends WorldGenerator implements IWorldGenerator

{

public WorldGenshelter() { }

 

@Override

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) { }

 

public void setBlock(World world, int x, int y, int z, Block block)

{

BlockPos blockpos = new BlockPos(x, y, z);

Block b1 = world.getBlockState(blockpos).getBlock();

 

if(world.isAirBlock(blockpos) || b1.isLeaves(world, blockpos))

{

IBlockState disblockstate = world.getBlockState(blockpos);

world.setBlockState(blockpos, disblockstate);

}

}

 

 

@Override

public boolean generate(World world, Random random, BlockPos blockpos) {

 

int i = blockpos.getX();

int j = blockpos.getY();

int k = blockpos.getZ();

 

this.setBlock(world, i + 0, j + 0, k + 0, Blocks.log);

this.setBlock(world, i + 0, j + 0, k + 1, Blocks.planks);

this.setBlock(world, i + 0, j + 0, k + 2, Blocks.planks);

this.setBlock(world, i + 0, j + 0, k + 3, Blocks.air);

this.setBlock(world, i + 0, j + 0, k + 4, Blocks.log);

this.setBlock(world, i + 0, j + 1, k + 0, Blocks.log);

this.setBlock(world, i + 0, j + 1, k + 1, Blocks.glass_pane);

this.setBlock(world, i + 0, j + 1, k + 2, Blocks.planks);

this.setBlock(world, i + 0, j + 1, k + 3, Blocks.air);

this.setBlock(world, i + 0, j + 1, k + 4, Blocks.log);

this.setBlock(world, i + 0, j + 2, k + 0, Blocks.log);

this.setBlock(world, i + 0, j + 2, k + 1, Blocks.planks);

this.setBlock(world, i + 0, j + 2, k + 2, Blocks.planks);

this.setBlock(world, i + 0, j + 2, k + 3, Blocks.planks);

this.setBlock(world, i + 0, j + 2, k + 4, Blocks.log);

this.setBlock(world, i + 0, j + 3, k + 0, Blocks.oak_stairs);

this.setBlock(world, i + 0, j + 3, k + 1, Blocks.oak_stairs);

this.setBlock(world, i + 0, j + 3, k + 2, Blocks.oak_stairs);

this.setBlock(world, i + 0, j + 3, k + 3, Blocks.oak_stairs);

this.setBlock(world, i + 0, j + 3, k + 4, Blocks.oak_stairs);

this.setBlock(world, i + 1, j + 0, k + 0, Blocks.planks);

this.setBlock(world, i + 1, j + 0, k + 1, Blocks.bed);

this.setBlock(world, i + 1, j + 0, k + 4, Blocks.furnace);

this.setBlock(world, i + 1, j + 1, k + 0, Blocks.glass_pane);

this.setBlock(world, i + 1, j + 1, k + 4, Blocks.glass_pane);

this.setBlock(world, i + 1, j + 2, k + 0, Blocks.planks);

this.setBlock(world, i + 1, j + 2, k + 4, Blocks.planks);

this.setBlock(world, i + 1, j + 3, k + 0, Blocks.oak_stairs);

this.setBlock(world, i + 1, j + 3, k + 1, Blocks.planks);

this.setBlock(world, i + 1, j + 3, k + 2, Blocks.glowstone);

this.setBlock(world, i + 1, j + 3, k + 3, Blocks.planks);

this.setBlock(world, i + 1, j + 3, k + 4, Blocks.oak_stairs);

this.setBlock(world, i + 2, j + 0, k + 0, Blocks.planks);

this.setBlock(world, i + 2, j + 0, k + 1, Blocks.bed);

this.setBlock(world, i + 2, j + 0, k + 2, Blocks.chest);

this.setBlock(world, i + 2, j + 0, k + 3, Blocks.crafting_table);

this.setBlock(world, i + 2, j + 0, k + 4, Blocks.planks);

this.setBlock(world, i + 2, j + 1, k + 0, Blocks.glass_pane);

this.setBlock(world, i + 2, j + 1, k + 4, Blocks.glass_pane);

this.setBlock(world, i + 2, j + 2, k + 0, Blocks.planks);

this.setBlock(world, i + 2, j + 2, k + 4, Blocks.planks);

this.setBlock(world, i + 2, j + 3, k + 0, Blocks.oak_stairs);

this.setBlock(world, i + 2, j + 3, k + 1, Blocks.planks);

this.setBlock(world, i + 2, j + 3, k + 2, Blocks.glowstone);

this.setBlock(world, i + 2, j + 3, k + 3, Blocks.planks);

this.setBlock(world, i + 2, j + 3, k + 4, Blocks.oak_stairs);

this.setBlock(world, i + 3, j + 0, k + 0, Blocks.log);

this.setBlock(world, i + 3, j + 0, k + 1, Blocks.planks);

this.setBlock(world, i + 3, j + 0, k + 2, Blocks.planks);

this.setBlock(world, i + 3, j + 0, k + 3, Blocks.planks);

this.setBlock(world, i + 3, j + 0, k + 4, Blocks.log);

this.setBlock(world, i + 3, j + 1, k + 0, Blocks.log);

this.setBlock(world, i + 3, j + 1, k + 1, Blocks.glass_pane);

this.setBlock(world, i + 3, j + 1, k + 2, Blocks.glass_pane);

this.setBlock(world, i + 3, j + 1, k + 3, Blocks.glass_pane);

this.setBlock(world, i + 3, j + 1, k + 4, Blocks.log);

this.setBlock(world, i + 3, j + 2, k + 0, Blocks.log);

this.setBlock(world, i + 3, j + 2, k + 1, Blocks.planks);

this.setBlock(world, i + 3, j + 2, k + 2, Blocks.planks);

this.setBlock(world, i + 3, j + 2, k + 3, Blocks.planks);

this.setBlock(world, i + 3, j + 2, k + 4, Blocks.log);

this.setBlock(world, i + 3, j + 3, k + 0, Blocks.oak_stairs);

this.setBlock(world, i + 3, j + 3, k + 1, Blocks.oak_stairs);

this.setBlock(world, i + 3, j + 3, k + 2, Blocks.oak_stairs);

this.setBlock(world, i + 3, j + 3, k + 3, Blocks.oak_stairs);

this.setBlock(world, i + 3, j + 3, k + 4, Blocks.oak_stairs);

this.setBlock(world, i + 4, j + 0, k + 0, Blocks.air);

this.setBlock(world, i + 4, j + 0, k + 4, Blocks.air);

this.setBlock(world, i + 5, j + 0, k + 0, Blocks.air);

this.setBlock(world, i + 5, j + 0, k + 4, Blocks.air);

this.setBlock(world, i + 6, j + 0, k + 0, Blocks.air);

this.setBlock(world, i + 6, j + 0, k + 4, Blocks.air);

this.setBlock(world, i + 7, j + 0, k + 0, Blocks.air);

this.setBlock(world, i + 7, j + 0, k + 1, Blocks.air);

this.setBlock(world, i + 7, j + 0, k + 2, Blocks.air);

this.setBlock(world, i + 7, j + 0, k + 3, Blocks.air);

this.setBlock(world, i + 7, j + 0, k + 4, Blocks.air);

 

return true;

 

}

 

}

 

 

 

And here's the code I have in the generateSurface() method in a different file:

 

 

private void generateSurface(World world, Random random, int x, int z) {

int posX = 10;

int posY = 4;

int posZ = 10;

BlockPos yay = new BlockPos(posX, posY, posZ);

new WorldGenshelter().generate(world, random, yay);

}

 

 

 

Thank you

 

(Alternatively, if you know of any resources or links that talk about how to update generation structure code for 1.8, that would be great!)

[GotoLink]

Problem here:

IBlockState disblockstate = world.getBlockState(blockpos);
         world.setBlockState(blockpos, disblockstate);

Those lines change nothing.

[codenymph]

You're right! I changed that and did some more debugging and actually got it to work.

 

(Code's here if anyone is interested: http://cscarlett.com/structures.php)