Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.8] Item (and maybe Block) name and getName

jeffryfisher

By jeffryfisher
in Modder Support

 Share

Recommended Posts

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

One tutorial (Wuppy Upgrading from 1.7 to 1.8) says that mc 1.8 items and blocks need to contain a static final variable called "name" and a public method called "getName". It doesn't say why, and it doesn't point to the part of Forge that needs these things (and reflection is really tricky to trace), so I'm somewhat unclear on what's really necessary. I've looked in the Forge docs, but I can't find answers to these questions. If someone knows (or could point me to the Forge class that uses name / getName() on items and/or blocks), I'd appreciate it.

 

I'm trying to generalize some abstract classes for a whole series of mods, so I'd like to know what constraints I face. In particular:

 

Is it enough to provide a getName method, or is the data member "name" also referenced via reflection?

 

If so, does the class member need to be called exactly "name", all lowercase?

 

Does "name" absolutely need to be final and/or static? I especially want to remove the "static" qualifier so my constructor can assign a value.

 

How early does name need to get its value? Can I set it during construction?

 

Do both items and blocks need these, or just one not the other?

 

What are the consequences / symptoms of doing this wrong or not at all? I left out name and getName() from some of my ItemBlock classes, but I don't see any error messages. I tried setting a breakpoint on the getName() method and then debugging. I was able to load a world, place my blocks and save the world all without triggering on a call. Maybe reflection doesn't trigger breakpoints.

 

Where does Forge call getName() or use name? If I could walk the source, I might answer my own questions.  Maybe the name member and getName method are merely Wuppy's modding style needed to fit with his own private framework. If so, then I'd like to know so I can discard these apparently unused elements (and constraints).

 

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Choonster Reality Controller

Choonster

Posted
Posted

This is just Wuppy's style, it's not required (or used at all) by Forge. He just uses it to store the name passed to 

GameRegistry.registerBlock

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • bombih7
      ку

      By bombih7 · Posted

    • HOTDOGKING272829
      Could somebody help with my modpack not working

      By HOTDOGKING272829 · Posted

      logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • Martingonn
      Decompile minecraft INDEV?

      By Martingonn · Posted

      You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Martingonn
      Decompile minecraft INDEV?

      By Martingonn · Posted

      Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • Orichalcum
      Getting Holder<Enchantment> from RegistryKey in GLM

      By Orichalcum · Posted

      I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept