[1.8] [SOLVED] Config not saving if changed in the Config GUI

[xJon]

Hi,

 

Recently I worked on a configuration GUI and when I tested it, it didn't save. The configuration file is working okay though.

I have a syncConfig method here, onConfigChanged method here, and this is my main class.

I'll really appreciate if someone could look at the code and see what's wrong. I'm trying for hours and I can't figure it out. I also tried searching online but nope - I did everything they said, well at least I think I did.

 

Thanks for any reply!

[Himself12794]

One thing I noticed is that every time syncConfig is called, you're registering the mod instance as an event handler. You don't need to do that.

 

You might also find it more convenient to put the configuration event change method in the configuration class. I just recently did something like what you did. Here is my solution: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/ModConfig.java

Main mod class here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/PowersAPI.java

And I register it here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/proxy/CommonProxy.java

 

Hopefully that helps. If not, I can look at what you've done again much better once I get access to more than just a mobile device.

[xJon]

One thing I noticed is that every time syncConfig is called, you're registering the mod instance as an event handler. You don't need to do that.

 

You might also find it more convenient to put the configuration event change method in the configuration class. I just recently did something like what you did. Here is my solution: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/ModConfig.java

Main mod class here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/PowersAPI.java

And I register it here: https://github.com/Himself12794/powersAPI/blob/develop/src/main/java/com/himself12794/powersapi/proxy/CommonProxy.java

 

Hopefully that helps. If not, I can look at what you've done again much better once I get access to more than just a mobile device.

I tried removing mod instance event in the syncConfig method but it didn't do it unfortunately..

I looked at your way and it's completely different, you send it back to the main mod class and then use the instance? I didn't really understand that. :\

[Himself12794]

Found it.

 

In your config mod gui, here: https://github.com/xJon/Jons-Useless-Mod/blob/master/src/main/java/xjon/jum/client/gui/UselessConfigGui.java#L17

 

You are registering the gui with your mod name, not your mod id. That's why the event isn't triggering. I tested it and used the mod id instead of mod name, and I was able to get it to work.

[xJon]

Found it.

 

In your config mod gui, here: https://github.com/xJon/Jons-Useless-Mod/blob/master/src/main/java/xjon/jum/client/gui/UselessConfigGui.java#L17

 

You are registering the gui with your mod name, not your mod id. That's why the event isn't triggering. I tested it and used the mod id instead of mod name, and I was able to get it to work.

You're our saviour!