[1.7.10] [Solved] Packet/keybinding issue

Athire · October 6, 2015

Hello all!

I'm still trying to get the hang of the 1.7 packet structure, and I think I know what the issue is here and where it occurs but I'm a bit confused as to how to actually fix it. I have other packets working but this one is being a bit of a pain.

I'm trying to send a packet when I press a key. When I press the button the keybinding tries to send the packet, but I get the following error: readerIndex(0) + length(4) exceeds writerIndex(1). This happens on the line which should be sending a packet. The packet should literally just contain the number 1. I read this as I'm not sending as much as the recieving code expects to see. In all the other packets I've sent I just create a new packet using the constructor and input the paramater I need. So given that my packet constructor takes in an int and saves it to a variable, shouldn't I send it like:

BaseClass.innerpowerChannel.sendToServer(new useAbilityPacket(keyPressed));

Where keyPressed is an int? Thanks in advance! I'll include the full code below:

Packet class:

package com.InnerPower.networking;

import io.netty.buffer.ByteBuf;

import cpw.mods.fml.common.network.ByteBufUtils;

import cpw.mods.fml.common.network.simpleimpl.IMessage;

public class useAbilityPacket implements IMessage

{

public int keyPressed;

public useAbilityPacket(int k) {

this.keyPressed=k;

}

@Override

public void fromBytes(ByteBuf buf) {

buf.writeInt(this.keyPressed);

}

@Override

public void toBytes(ByteBuf buf) {

this.keyPressed=buf.readInt();

}

Packet Handler:

package com.InnerPower.networking;

import io.netty.buffer.ByteBuf;

import java.io.ByteArrayInputStream;

import java.io.DataInputStream;

import java.io.IOException;

import net.minecraft.entity.player.EntityPlayer;

import com.InnerPower.BaseClass;

import com.InnerPower.magicPlayer;

import cpw.mods.fml.common.network.simpleimpl.IMessage;

import cpw.mods.fml.common.network.simpleimpl.IMessageHandler;

import cpw.mods.fml.common.network.simpleimpl.MessageContext;

public class useAbilityPacketHandler implements IMessageHandler <useAbilityPacket, IMessage>

{

@Override

public IMessage onMessage(useAbilityPacket message, MessageContext ctx) {

useSpell(message, ctx);

return null;

}

private void useSpell( useAbilityPacket message,MessageContext ctx)

{

EntityPlayer player=BaseClass.proxy.getPlayerEntity(ctx);

magicPlayer props = magicPlayer.get(player);

int keyPressed=0;

keyPressed=message.keyPressed;

if(keyPressed == 0)

{

System.out.println("[inner Power] [Error] error in useAbilityPacketHandler! keypressed == 0 ");

return;

}

if(keyPressed==1)

{

if(props.isMage)

props.mageList.useSpell(props.activeSpellID, (EntityPlayer) player);

if(props.isUnholy)

props.necroList.useSpell(props.activeSpellID, (EntityPlayer)player);

if(props.isHoly)

props.holyList.useSpell(props.activeSpellID, (EntityPlayer)player);

}

if(keyPressed==2)

{

if(props.isMage)

props.mageList.useSpell(props.activeSpellID2, (EntityPlayer)player);

if(props.isUnholy)

props.necroList.useSpell(props.activeSpellID2,(EntityPlayer) player);

if(props.isHoly)

props.holyList.useSpell(props.activeSpellID2,(EntityPlayer) player);

}

if(keyPressed==3)

{

if(props.isMage)

props.mageList.useSpell(props.activeSpellID3,(EntityPlayer) player);

if(props.isUnholy)

props.necroList.useSpell(props.activeSpellID3,(EntityPlayer) player);

if(props.isHoly)

props.holyList.useSpell(props.activeSpellID3,(EntityPlayer) player);

}

if(keyPressed==4)

{

if(props.isMage)

props.mageList.useSpell(props.activeSpellID4, (EntityPlayer)player);

if(props.isUnholy)

props.necroList.useSpell(props.activeSpellID4,(EntityPlayer) player);

if(props.isHoly)

props.holyList.useSpell(props.activeSpellID4,(EntityPlayer) player);

}

Key Input Handler:

package com.InnerPower;

import java.io.ByteArrayOutputStream;

import java.io.DataOutputStream;

import javax.swing.text.JTextComponent.KeyBinding;

import net.minecraft.client.Minecraft;

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

import cpw.mods.fml.common.gameevent.InputEvent;

import com.InnerPower.BaseClass;

import com.InnerPower.networking.clientProjPacket;

import com.InnerPower.networking.useAbilityPacket;

public class KeyInputHandler

{

//member fields

int keyPressed = 0;

@SubscribeEvent

public void onKeyInput(InputEvent.KeyInputEvent event)

{

//net.minecraft.client.settings.KeyBinding[] keyBindings= BaseClass.keyBindings;

if(BaseClass.keyBindings[0].isPressed())

{

keyPressed = 1;

}

else if(BaseClass.keyBindings[1].isPressed())

{

keyPressed= 2;

}

else if(BaseClass.keyBindings[2].isPressed())

{

keyPressed= 3;

}

else if(BaseClass.keyBindings[3].isPressed())

{

keyPressed= 4;

}

if (Minecraft.getMinecraft().inGameHasFocus)

{

//I think the issue is here

BaseClass.innerpowerChannel.sendToServer(new useAbilityPacket(keyPressed));

}

Failender · October 6, 2015

First thing I saw, the packet needs the empy constructor.

Show the whole error log please.

Athire · October 7, 2015

Right. I forgot the default constructor. I'll fix that

Here is the full error log:

[22:12:05] [Client thread/ERROR] [FML]: FMLIndexedMessageCodec exception caught

io.netty.handler.codec.EncoderException: java.lang.IndexOutOfBoundsException: readerIndex(0) + length(4) exceeds writerIndex(1): UnpooledHeapByteBuf(ridx: 0, widx: 1, cap: 256)

at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:107) ~[MessageToMessageEncoder.class:?]

at io.netty.handler.codec.MessageToMessageCodec.write(MessageToMessageCodec.java:116) ~[MessageToMessageCodec.class:?]

at io.netty.channel.DefaultChannelHandlerContext.invokeWrite(DefaultChannelHandlerContext.java:644) ~[DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:698) ~[DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelHandlerContext.writeAndFlush(DefaultChannelHandlerContext.java:688) ~[DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelHandlerContext.writeAndFlush(DefaultChannelHandlerContext.java:717) ~[DefaultChannelHandlerContext.class:?]

at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:893) ~[DefaultChannelPipeline.class:?]

at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:239) ~[AbstractChannel.class:?]

at cpw.mods.fml.common.network.simpleimpl.SimpleNetworkWrapper.sendToServer(SimpleNetworkWrapper.java:207) [simpleNetworkWrapper.class:?]

at com.InnerPower.KeyInputHandler.onKeyInput(KeyInputHandler.java:48) [KeyInputHandler.class:?]

at cpw.mods.fml.common.eventhandler.ASMEventHandler_5_KeyInputHandler_onKeyInput_KeyInputEvent.invoke(.dynamic) [?:?]

at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51) [ASMEventHandler.class:?]

at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122) [EventBus.class:?]

at cpw.mods.fml.common.FMLCommonHandler.fireKeyInput(FMLCommonHandler.java:539) [FMLCommonHandler.class:?]

at net.minecraft.client.Minecraft.runTick(Minecraft.java:1962) [Minecraft.class:?]

at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1038) [Minecraft.class:?]

at net.minecraft.client.Minecraft.run(Minecraft.java:961) [Minecraft.class:?]

at net.minecraft.client.main.Main.main(Main.java:164) [Main.class:?]

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_45]

at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]

at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_45]

at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_45]

at net.minecraft.launchwrapper.Launch.launch(Launch.java:134) [launchwrapper-1.9.jar:?]

at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]

at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:85) [start/:?]

at GradleStart.main(GradleStart.java:45) [start/:?]

Caused by: java.lang.IndexOutOfBoundsException: readerIndex(0) + length(4) exceeds writerIndex(1): UnpooledHeapByteBuf(ridx: 0, widx: 1, cap: 256)

at io.netty.buffer.AbstractByteBuf.checkReadableBytes(AbstractByteBuf.java:1160) ~[AbstractByteBuf.class:?]

at io.netty.buffer.AbstractByteBuf.readInt(AbstractByteBuf.java:611) ~[AbstractByteBuf.class:?]

at com.InnerPower.networking.useAbilityPacket.toBytes(useAbilityPacket.java:23) ~[useAbilityPacket.class:?]

at cpw.mods.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:11) ~[simpleIndexedCodec.class:?]

at cpw.mods.fml.common.network.simpleimpl.SimpleIndexedCodec.encodeInto(SimpleIndexedCodec.java:7) ~[simpleIndexedCodec.class:?]

at cpw.mods.fml.common.network.FMLIndexedMessageToMessageCodec.encode(FMLIndexedMessageToMessageCodec.java:51) ~[FMLIndexedMessageToMessageCodec.class:?]

at io.netty.handler.codec.MessageToMessageCodec$1.encode(MessageToMessageCodec.java:67) ~[MessageToMessageCodec$1.class:?]

at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:89) ~[MessageToMessageEncoder.class:?]

... 25 more

[22:12:05] [Client thread/ERROR] [FML]: SimpleChannelHandlerWrapper exception