Posted October 16, 20159 yr Hi there! So I want to save NBT to my solar panel when its broken and placed again. What the code below does is it works when I break and place the solarpanel in the same place, but if I place the solar panel somewhere else it places a solar panel with no Gui or data. Any help is much appriciated. BlockSolarPanel @Override public void onBlockPlacedBy(World world, int x, int y, int z, EntityLivingBase player, ItemStack stack) { TileEntitySolarPanel te = (TileEntitySolarPanel) world.getTileEntity(x, y, z); if (te instanceof TileEntitySolarPanel && stack.getTagCompound() != null) { te.readFromNBT(stack.getTagCompound()); } } @Override public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) { ArrayList<ItemStack> ret = new ArrayList<ItemStack>(); ItemStack stack = new ItemStack(world.getBlock(x, y, z), 1, metadata); TileEntitySolarPanel te = (TileEntitySolarPanel) world.getTileEntity(x, y, z); if (te instanceof TileEntitySolarPanel) { NBTTagCompound tag = new NBTTagCompound(); ((TileEntitySolarPanel)te).writeToNBT(tag); if (!stack.hasTagCompound()) { stack.setTagCompound(tag); } ret.add(stack); } return ret; } @Override public boolean removedByPlayer(World world, EntityPlayer player, int x, int y, int z, boolean willHarvest) { if (willHarvest) { return true; // If it will harvest, delay deletion of the block // until after getDrops } return super.removedByPlayer(world, player, x, y, z, willHarvest); } @Override public void harvestBlock(World world, EntityPlayer player, int x, int y, int z, int meta) { super.harvestBlock(world, player, x, y, z, meta); world.setBlockToAir(x, y, z); }
October 16, 20159 yr While logic behind it seems good, you are most certailny making one mistake by using vanilla read/write NBT methods. ((TileEntitySolarPanel)te).writeToNBT(tag); and: te.readFromNBT(stack.getTagCompound()); Will also cause TileEntity placed in new BlockPos set old data from old pos. Meaning: (code from TileEntity.class) public void readFromNBT(NBTTagCompound compound) { this.pos = new BlockPos(compound.getInteger("x"), compound.getInteger("y"), compound.getInteger("z")); if (compound.hasKey("ForgeData")) this.customTileData = compound.getCompoundTag("ForgeData"); } public void writeToNBT(NBTTagCompound compound) { String s = (String)classToNameMap.get(this.getClass()); if (s == null) { throw new RuntimeException(this.getClass() + " is missing a mapping! This is a bug!"); } else { compound.setString("id", s); compound.setInteger("x", this.pos.getX()); compound.setInteger("y", this.pos.getY()); compound.setInteger("z", this.pos.getZ()); if (this.customTileData != null) compound.setTag("ForgeData", this.customTileData); } } All in all causing malfunction. Create your own method that will write/read only data needed. 1.7.10 is no longer supported by forge, you are on your own.
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.