Contributing to Forge on Github

[minzmann]

I'm not sure if this is the right place for this question, since this is Modder Support, but since there is no designated place for this (Its neither an issue (well maybe in the sense that there is no documentation), nor something that requires a PR so Github is the wrong place as well). Anyway, the question is:

 

How does Forge handle its branches? What is the main branch for (I submitted a PR to both main and 1.8.8, of which only the latter got accepted, the other one is still open)? Is the main branch forked for future versions and if so are the changes to 1.8.8 applied to the main branch if a new version releases, or should I create a PR for both branches?

 

If the things stated above are in fact the case, should things that would break compatibility be PRed against master (if they can't be implemented in another way)? And is the use of Java 8 exclusive features allowed to achieve compatibility for new features under the current version (like default methods for interfaces)?

 

Sorry if these questions are really obvious, but I'm new to Github/community-development (not to Java though), and I'd really appreciate an answer.

[minzmann]

Thanks for your reply, so PRs with small bugfixes/cleanup should only be made against the current version (in this case 1.8.8 ) and then LexManos (or someone else) will later on merge these changes to the master branch?