Search the Forums BEFORE making a new post.

Contributing to Forge on Github

Posted December 13, 20159 yr

I'm not sure if this is the right place for this question, since this is Modder Support, but since there is no designated place for this (Its neither an issue (well maybe in the sense that there is no documentation), nor something that requires a PR so Github is the wrong place as well). Anyway, the question is:

How does Forge handle its branches? What is the main branch for (I submitted a PR to both main and 1.8.8, of which only the latter got accepted, the other one is still open)? Is the main branch forked for future versions and if so are the changes to 1.8.8 applied to the main branch if a new version releases, or should I create a PR for both branches?

If the things stated above are in fact the case, should things that would break compatibility be PRed against master (if they can't be implemented in another way)? And is the use of Java 8 exclusive features allowed to achieve compatibility for new features under the current version (like default methods for interfaces)?

Sorry if these questions are really obvious, but I'm new to Github/community-development (not to Java though), and I'd really appreciate an answer.

Quote

December 13, 20159 yr

Author

Thanks for your reply, so PRs with small bugfixes/cleanup should only be made against the current version (in this case 1.8.8 ) and then LexManos (or someone else) will later on merge these changes to the master branch?

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/35232-contributing-to-forge-on-github/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 4 hours ago4 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 4 hours ago4 hr
Help with file conversion

This is really helpful

By Brialeblanc · 9 hours ago9 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 16 hours ago16 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 23 hours ago23 hr

There are no registered users currently online

Sign In

Contributing to Forge on Github

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)