Search the Forums BEFORE making a new post.

Note block plays note again after using a play button and closing the GUI

Posted December 28, 20159 yr

This video demonstrates the issue:

[embed=425,349]<iframe width="560" height="315" src="https://www.youtube.com/embed/5FWh_9MUk9I" frameborder="0" allowfullscreen></iframe>[/embed]

Event Handler:

public class EventHandlerCommon {	
    public static TileEntityNote entityNoteBlock;

    @SubscribeEvent
    public void noteBlockChange(NoteBlockEvent.Change event) {
        event.setCanceled(true);
        //CHANGE EVENT
    }

@SubscribeEvent
    public void playerInteract(PlayerInteractEvent event) {
    	if (event.action == PlayerInteractEvent.Action.RIGHT_CLICK_BLOCK) {
    		World world = event.world;
    		Block block = world.getBlockState(event.pos).getBlock();
    		if (block.equals(Blocks.noteblock)) {
                event.entityPlayer.openGui(NBGUI.instance, GUI.GUI_ID, world, event.pos.getX(), event.pos.getY(), event.pos.getZ());
                entityNoteBlock = (TileEntityNote) world.getTileEntity(event.pos);
                
                event.useBlock = Event.Result.DENY;
    		}
    	}
    }
}

actionPerformed method in GUI class:

protected void actionPerformed(GuiButton button) throws IOException {
	switch (button.id) {
		case 1: //Play
			Packet playNote = new Packet(EventHandlerCommon.entityNoteBlock);
			//playNote.setText("play");
			NBGUI.network.sendToServer(playNote);          
			break;
		case 2: //Note +1
			break;
		case 3: //Note -1
			break;
		case 4: //Octave +1
			break;
		case 5: //Octave -1
			break;
	}
}

IMessage:

public class Packet implements IMessage {
    protected static TileEntityNote entity;

    public Packet() {
    }

    public Packet(TileEntityNote entityNote) {
    	entity = entityNote;
    }

    @Override
    public void fromBytes(ByteBuf buf) {
    }

    @Override
    public void toBytes(ByteBuf buf) {
    }
}

IMessageHandler:

public class PacketHandler implements IMessageHandler<Packet, Packet> {
@Override
public Packet onMessage(final Packet packet, MessageContext ctx) {
	IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
	mainThread.addScheduledTask(new Runnable() {
		@Override
		public void run() {
			TileEntityNote noteBlock = packet.entity;
			noteBlock.triggerNote(noteBlock.getWorld(), noteBlock.getPos());
		}
	});
	return null;
}
}

Quote

December 28, 20159 yr

Author

Okay, I think I understand where I went wrong. I was getting the TE before sending it to the server. Instead, I am now getting the world and the coordinates from the event that opens the GUI and sending that info to the server. I get the tile entity in the packet handler. However, this didn't fix the issue.

The point of the static field in the event handler is so that it can be used to send a packet in the actionPerformed method in the GUI class:

public static Packet entityNoteBlock;

    @SubscribeEvent
    public void playerInteract(PlayerInteractEvent event) {
    	if (event.action == PlayerInteractEvent.Action.RIGHT_CLICK_BLOCK) {
    		World world = event.world;
    		Block block = world.getBlockState(event.pos).getBlock();
    		if (block.equals(Blocks.noteblock)) {
                event.entityPlayer.openGui(NBGUI.instance, GUI.GUI_ID, world, event.pos.getX(), event.pos.getY(), event.pos.getZ());
                entityNoteBlock = new Packet(event.pos.getX(), event.pos.getY(), event.pos.getZ());
                
                event.useBlock = Event.Result.DENY;
    		}
    	}
   }

    @Override
protected void actionPerformed(GuiButton button) throws IOException {
	switch (button.id) {
		case 1: //Play
                Packet playNote = EventHandlerCommon.entityNoteBlock;
                //playNote.setText("play");
                NBGUI.network.sendToServer(playNote);          
                break;
		case 2: //Note +1
			break;
		case 3: //Note -1
			break;
		case 4: //Octave +1
			break;
		case 5: //Octave -1
			break;
	}
}

IMessage:

package com.mark.nbgui.packet;

import io.netty.buffer.ByteBuf;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntityNote;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class Packet implements IMessage {
    protected int x;
    protected int y;
    protected int z;

    public Packet() {
    }

    public Packet(int x, int y, int z) {
        this.x = x;
        this.y = y;
        this.z = z;
    }

    @Override
    public void fromBytes(ByteBuf buf) {
    	x = buf.readInt();
    	y = buf.readInt();
    	z = buf.readInt();
    }

    @Override
    public void toBytes(ByteBuf buf) {
    	buf.writeInt(x);
    	buf.writeInt(y);
    	buf.writeInt(z);
    }
}

IMessageHandler:

public class PacketHandler implements IMessageHandler<Packet, Packet> {
@Override
public Packet onMessage(final Packet packet, final MessageContext ctx) {
	final IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
	mainThread.addScheduledTask(new Runnable() {
		@Override
		public void run() {
			World world = (World) mainThread;
			BlockPos pos = new BlockPos(packet.x, packet.y, packet.z);
			TileEntityNote noteBlock = (TileEntityNote) world.getTileEntity(pos);
			noteBlock.triggerNote(world, pos);
		}
	});
	return null;
}
}

Quote

December 28, 20159 yr

Author

You just don't understand the concept of server/client, do you? Static variables completely circumvent it and cause a lot of problems.

You shoud just send the packet from the actionPerformed method directly, what is the point of the event handler anyways?

The point of the event handler is to open the GUI. I need to obtain the position of the TileEntity, and I do that by obtaining the position of the block in the same event that opens the GUI. How can I obtain the position directly from the actionPerformed method?

Quote

December 28, 20159 yr

Author

Okay. Again, how do I obtain the position of the block the GUI is open for then? If the field can not be static, that means that the actionPerformed method (which is in another class) can not use that, and conversely I cannot use the current method of obtaining the position from the same event as the one that opens the GUI. Thus, there needs to be an alternative.

Quote

December 28, 20159 yr

Author

In your GUI handler you pass the position to the GuiScreen.

Okay, cool, that's simpler than what I was trying to do. I think I did it correctly, but it the issue still occurs.

Some of the GUI class:

public class GUI extends GuiScreen {
    private int x;
    private int y;
    private int z;
    
    public GUI(EntityPlayer player, World world, int x, int y, int z) {
        this.x = x;
        this.y = y;
        this.z = z;
    }

    @Override
protected void actionPerformed(GuiButton button) throws IOException {
    	switch (button.id) {
    		case 1: //Play
    			Packet playNote = new Packet(x, y, z);
    			NBGUI.network.sendToServer(playNote);          
    			break;
	}
    }
}

Quote

December 28, 20159 yr

Author

I have this too right now, just excluded it:

    @SubscribeEvent
    public void noteBlockChange(NoteBlockEvent.Change event) {
        event.setCanceled(true);
        //CHANGE EVENT
    }

That, along with setting useBlock to DENY just stops the default action of changing the pitch. If I allow the pitch to be changed while still opening the GUI, a similar thing happens (since the note is played upon tuning the block). If I also left click to play a note and then open the GUI, again, a similar thing happens:

[embed=425,349]<iframe width="560" height="315" src="https://www.youtube.com/embed/mMUPkPS3hCY" frameborder="0" allowfullscreen></iframe>[/embed]

Note that the GUI does not pause the game.

And do I cancel the event with

event.setCanceled(true);

If so, it didn't help.

Quote

December 28, 20159 yr

Author

package com.mark.nbgui;

import com.mark.nbgui.packet.Packet;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityNote;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.event.world.NoteBlockEvent;
import net.minecraftforge.fml.client.FMLClientHandler;
import net.minecraftforge.fml.common.eventhandler.Event;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.InputEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class EventHandlerCommon {	

    /*@SubscribeEvent
    public void noteBlockChange(NoteBlockEvent.Change event) {
        event.setCanceled(true);
        //CHANGE EVENT
    }*/

    /*@SubscribeEvent
    public void noteBlockPlay(NoteBlockEvent.Play event) {
        //PLAY OVERRIDDEN
    }*/
    
    @SubscribeEvent
    @SideOnly(Side.CLIENT)
    public void onKeyInput(InputEvent.KeyInputEvent event) {
    	Minecraft mc = Minecraft.getMinecraft();
        if (KeyBindings.returnInput.isPressed() && FMLClientHandler.instance().getClient().inGameHasFocus) {
        }
    }

@SubscribeEvent
    public void playerInteract(PlayerInteractEvent event) {
    	if (event.action == PlayerInteractEvent.Action.RIGHT_CLICK_BLOCK) {
    		World world = event.world;
    		Block block = world.getBlockState(event.pos).getBlock();
    		if (block.equals(Blocks.noteblock)) {
                event.entityPlayer.openGui(NBGUI.instance, GUI.GUI_ID, world, event.pos.getX(), event.pos.getY(), event.pos.getZ());
                
                event.useBlock = Event.Result.DENY;
                event.setCanceled(true);
    		}
    	}
    }
}

package com.mark.nbgui;

import net.minecraft.block.Block;
import net.minecraft.block.BlockNote;
import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.GuiScreen;
import net.minecraft.client.gui.GuiTextField;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.tileentity.TileEntityNote;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.event.world.NoteBlockEvent;
import net.minecraftforge.event.world.NoteBlockEvent.Octave;
import net.minecraftforge.fml.common.eventhandler.Event;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.network.internal.FMLMessage;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

import java.io.IOException;

import org.lwjgl.input.Keyboard;

import com.mark.nbgui.packet.Packet;

public class GUI extends GuiScreen {
public final static int GUI_ID = 20;

    private static String instrumentText = I18n.format("nbgui.string.gui.instrument", new Object[0])+" {instrument}";
    private static String noteText = I18n.format("nbgui.string.gui.note", new Object[0])+" {note}";
    private static String octaveText = I18n.format("nbgui.string.gui.octave", new Object[0])+" {octave}";

    private int x;
    private int y;
    private int z;
    private TileEntityNote entityNote;
    private BlockNote blockNote;
    private Block underBlock;
    
    public static GuiTextField noteTextField;
    public static GuiTextField octaveTextField;
    
    public GUI(EntityPlayer player, World world, int x, int y, int z) {
        BlockPos pos = new BlockPos(x, y, z);
        this.x = x;
        this.y = y;
        this.z = z;
        
        //TODO Returns null, fix.
        //System.out.println("[DEBUG] GNote: "+entityNote);
        //System.out.println("[DEBUG] GBlock: "+blockNote);
        //System.out.println("[DEBUG] GUnder: "+underBlock);
        this.entityNote = (TileEntityNote) world.getTileEntity(pos);
        this.blockNote = (BlockNote) world.getBlockState(pos).getBlock();
        this.underBlock = world.getBlockState(pos.down()).getBlock();
    }

@Override
    public void drawScreen(int x, int y, float f) {
		this.drawDefaultBackground();
		super.drawScreen(x, y, f);

		this.noteTextField.drawTextBox();
		this.octaveTextField.drawTextBox();

            this.drawCenteredString(this.fontRendererObj,
                    GUI.instrumentText.replace("{instrument}",
                    NoteUtils.getInstrumentString(NoteUtils.getNoteBlockInstrument(this.underBlock))),
                    this.width / 2, 30, 0xFFFFFFFF);
            //TODO Remove note and octave strings; redundant with text fields
            this.drawCenteredString(this.fontRendererObj,
                    GUI.noteText.replace("{note}", 
                    NoteUtils.getNoteString(NoteUtils.getBlockNote(this.entityNote))),
                    this.width / 2, 50, 0xFFFFFFFF);
            this.drawCenteredString(this.fontRendererObj,
                    GUI.octaveText.replace("{octave}", 
                    NoteUtils.getOctaveString(NoteUtils.getBlockOctave(this.entityNote))),
                    this.width / 2, 70, 0xFFFFFFFF);
            
    }

@Override
public void initGui() {    
	Keyboard.enableRepeatEvents(false);

	//Play Button
	GuiButton playButton = new GuiButton(1, this.width / 2 - 30, 90, 60, 20, I18n.format("nbgui.button.playNote", new Object[0]));	
	this.buttonList.add(playButton);

	//Note +1 Button
	GuiButton noteButtonAdd = new GuiButton(2, this.width / 2 - 60, 130, 20, 20, "+");
	this.buttonList.add(noteButtonAdd);

	//Note -1 Button
	GuiButton noteButtonSub = new GuiButton(3, this.width / 2 + 40, 130, 20, 20, "-");
	this.buttonList.add(noteButtonSub);

	//Octave +1 Button
	GuiButton octaveButtonAdd = new GuiButton(4, this.width / 2 - 60, 160, 20, 20, "+");
	this.buttonList.add(octaveButtonAdd);
	//TODO Grey out button if octave == 5 && note.equals("F_SHARP")

	//Octave -1 Button
	GuiButton octaveButtonSub = new GuiButton(5, this.width / 2 + 40, 160, 20, 20, "-");
	this.buttonList.add(octaveButtonSub);
	//TODO Grey out button if octave == 3


	//Note Text Field
	this.noteTextField = new GuiTextField(2, fontRendererObj, this.width/2 - 30, 130, 60, 20);
	this.noteTextField.setFocused(false);
	this.noteTextField.setCanLoseFocus(true);
	this.noteTextField.setText(NoteUtils.getNoteString(NoteUtils.getBlockNote(this.entityNote)));
	this.noteTextField.setTextColor(-1);
	this.noteTextField.setDisabledTextColour(-1);
	this.noteTextField.setEnableBackgroundDrawing(true);
	this.noteTextField.setMaxStringLength(7);

	//Octave Text Field
	this.octaveTextField = new GuiTextField(3, fontRendererObj, this.width/2 - 30, 160, 60, 20);
	this.octaveTextField.setFocused(false);
	this.octaveTextField.setCanLoseFocus(true);
	this.octaveTextField.setText(NoteUtils.getOctaveString(NoteUtils.getBlockOctave(this.entityNote)));
	this.octaveTextField.setTextColor(-1);
	this.octaveTextField.setDisabledTextColour(-1);
	this.octaveTextField.setEnableBackgroundDrawing(true);
	this.octaveTextField.setMaxStringLength(1);	

	//TODO Add option to merge note and octave text fields into one.
    }

    @Override
    public void keyTyped(char character, int keyCode) throws IOException {
    	super.keyTyped(character, keyCode);
    	if (keyCode == 28 && this.noteTextField.isFocused()) {
        	System.out.println("[DEBUG] Character: "+character);
        	System.out.println("[DEBUG] Code: "+keyCode);        	
		//TODO Send packets
    	} else if (keyCode == 28 && this.octaveTextField.isFocused()) {
        	System.out.println("[DEBUG] Character: "+character);
        	System.out.println("[DEBUG] Code: "+keyCode);        	
		//TODO Send packets
    	}   	
    }
    
    @Override
    public void mouseClicked(int x, int y, int clickedButon) throws IOException {
    	super.mouseClicked(x, y, clickedButon);
    	this.noteTextField.mouseClicked(x, y, clickedButon);
    	this.octaveTextField.mouseClicked(x, y, clickedButon);
    	if (this.noteTextField.isFocused()) {
    		this.noteTextField.setText("");
    	} else if (this.octaveTextField.isFocused()) {
    		this.octaveTextField.setText("");   		
    	}
    	/*Debug
    	System.out.println("[DEBUG] Note focused: "+noteTextField.isFocused());
    	System.out.println("[DEBUG] Octave focused: "+octaveTextField.isFocused());
    	System.out.println("[DEBUG]-------------------END-----------------------");*/
    	}
    
    @Override	
    public void updateScreen() {
    	 this.noteTextField.updateCursorCounter();
    	 this.octaveTextField.updateCursorCounter();
    }
    
    @Override
    public void onGuiClosed() {
    	Keyboard.enableRepeatEvents(false);
        super.onGuiClosed();
    }
    
    @Override
protected void actionPerformed(GuiButton button) throws IOException {
    	switch (button.id) {
    		case 1: //Play
    			Packet playNote = new Packet(x, y, z);
    			//playNote.setText("play");
    			NBGUI.network.sendToServer(playNote);          
    			break;
		case 2: //Note +1
			break;
		case 3: //Note -1
			break;
		case 4: //Octave +1
			break;
		case 5: //Octave -1
			break;
	}
    }

    @Override
    public boolean doesGuiPauseGame() {
        return false;
    }
}

package com.mark.nbgui;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

@SideOnly(Side.CLIENT)
public class GUIHandler implements IGuiHandler {

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
        return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
	if (ID == GUI.GUI_ID) {
		return new GUI(player, world, x, y, z);
	}
	return null;
}

}

package com.mark.nbgui.packet;

import io.netty.buffer.ByteBuf;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntityNote;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class Packet implements IMessage {
    //protected NBTTagCompound compound;
    protected int x;
    protected int y;
    protected int z;

    public Packet() {
        //this.compound = new NBTTagCompound();
    }

    public Packet(int x, int y, int z) {
        this.x = x;
        this.y = y;
        this.z = z;
        		 	
    	//this();
        //entityNote.writeToNBT(this.compound);
    }

    /*public void setText(String text) {
        this.compound.setString("____NBGUIMsg", text);
    }

    public void setPitch(int pitch) {
        this.compound.setString("____NBGUIMsg", "PITCH_" + pitch);
    }*/

    @Override
    public void fromBytes(ByteBuf buf) {
        //this.compound = ByteBufUtils.readTag(buf);
    	x = buf.readInt();
    	y = buf.readInt();
    	z = buf.readInt();
    }

    @Override
    public void toBytes(ByteBuf buf) {
        //ByteBufUtils.writeTag(buf, this.compound);
    	buf.writeInt(x);
    	buf.writeInt(y);
    	buf.writeInt(z);
    }
}

package com.mark.nbgui.packet;

import net.minecraft.client.Minecraft;
import net.minecraft.server.MinecraftServer;
import net.minecraft.tileentity.TileEntityNote;
import net.minecraft.util.BlockPos;
import net.minecraft.util.IThreadListener;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class PacketHandler implements IMessageHandler<Packet, Packet> {
@Override
public Packet onMessage(final Packet packet, final MessageContext ctx) {
	final IThreadListener mainThread = (WorldServer) ctx.getServerHandler().playerEntity.worldObj;
	mainThread.addScheduledTask(new Runnable() {
		@Override
		public void run() {
			World world = (World) mainThread;
			BlockPos pos = new BlockPos(packet.x, packet.y, packet.z);
			TileEntityNote noteBlock = (TileEntityNote) world.getTileEntity(pos);
			System.out.println("[DEBUG] PH World: "+world);
			System.out.println("[DEBUG] PH Pos: "+pos);
			noteBlock.triggerNote(world, pos);

			//DEBUG
			System.out.println("[DEBUG] PH getWorld: "+noteBlock.getWorld());
			System.out.println("[DEBUG] PH getPos: "+noteBlock.getPos());
			System.out.println("[DEBUG] PH note: "+noteBlock.note);
		}
	});
	return null;
}
}

Quote

December 28, 20159 yr

Author

No problem, I appreciate your time.

I'm not too great at using the debugger but I'll see if I can find anything.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/35541-note-block-plays-note-again-after-using-a-play-button-and-closing-the-gui/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

Well, needing help for this didn't last nearly as long as I expected, lol. I figured out the solution, and it's a real face palmer. Basically, the function Type.getInternalName(Class<?> clazz) does NOT work for classes that are obfuscated. This means that it won't work for basically every minecraft class. So running it with the argument EntityTrackerEntry.class won't work, but running it with CustomHandler.class will work! Annoying, but a still bit interesting. So I just replaced my call for Type.getInternalName(EntityTrackerEntry.class) with just "os", as that is the name of the actual class for EntityTrackerEntry at runtime. Hope this solution helps somebody. In the meantime, I'm going to mark this thread as solved.

By Jackson Perr · Monday at 09:57 PM1 day
[1.20.1] Custom Effect Help

Can you send the code pertaining to your custom mod effect? I don't see anything wrong with how you "assemble" the food properties, btw.

By Jackson Perr · Monday at 07:56 PM1 day
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

crazy

By Jonathing · Monday at 07:50 PM1 day
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

For anyone who is running into this issue in the future: The fix for me was updating Intellij. I was using the 2022 version, which apparently had some issues with Java 21 (particularly around enums, which Direction is one).

By CravenCraft · Monday at 07:40 PM1 day
How do you add a mob to spawn around a existing vanilla structure?

Hey dawg!

I think I might be able to help you out with your issue here. I say might because I don't know about 1.16.x or any later version, but I know how to do this kind of thing for 1.12.2 forge. Basically, in the pre-init or init (I don't really remember which one) you just gotta'

Okay, ykw, I just downloaded the 1.14.4 1.20.1 minecraft mdk. I think I actually can help you here. So, the 1.12.2 method actually doesn't work with 1.20.1 minecraft or later. Probably not too far before either. I see two options here for ya':

First, it's important to note that the game stores its spawn data for structures in, well, the Structures class. Here, the game initializes an instance of each Structure class and registers them with the BootstrapContext using its bootstrap function. Each instance of a Structure class is registered with a StructureSettings class as an argument. One of the arguments, the one that you're probably going to be particularly interested in here, would be the spawnOverrides argument. For this argument, the game uses a Map between MOB_CATEGORIES and StructureSpawnOverride. StructureSpawnOverride is essentially the juice of it here. It contains almost everything you would need to control how your custom mob spawns in Pillager Outposts. Now, if you want to change how the Structure class for the pillager outposts is registered with the BootstrapContext in the bootstrap function, you're going to want to change where the function's caller gets the function and replace it with your own custom version of this function. How might you do this? This is where it gets a little tricky. The bootstrap function for the structures class is referenced in VanillaRegistries.BUILDER. However, unfortunately, this field is private and final, so you can't directly change it with reflections, but you can still access it with reflections. Now the VanillaRegistries.BUILDER field is of the type RegistrySetBuilder, which uses a private final field "entires", which is set as a List<RegistrySetBuilder.RegistryStub<?>> type. So here, you could use reflections to access this list field and remove the entry for the structures bootstrap. Then you might be able to create your own structures class and add change the bootstrap function to reflect the changes you wish. Then finally, simply re-add the Structure entry that you made to the list, and you should be completely done! Keep in mind, I haven't actually tested this, so I'm not sure if it would actually work, and even if it did work it's really unorthodox, so I would recommend trying this next idea.

When the game is deciding whether or not to spawn an entity, if the entity is registered with the SpawnPlacements class, is uses the function you specify in the entity class to determine whether or not the entity can spawn in a certain spot. For example, the guardian cannot spawn on a block that is exposed to light from underwater because of this function. So what you could do is make a checkSelfSpawnRules function for your mob and register it with the SpawnPlacements function. Then, you could have your checkSelfSpawnRules function take into account if the block it's trying to spawn on is near a Pillager Outpost. Finally, you can get the coordinates to the chunk of your block and iterate through the ServerLevels in your MinecraftServer class and get their chunk sources and test if the chunk source has the chunk of your block position. If it does, you can then get the StructureManager from the ServerLevel. In there should be some very helpful functions for you to use. Although this is a bit more orthodox, it might be a bit laggy.

It's really up to you which of these options you choose. If you need some additional clarification then please let me know, I would be happy to help you out! Also let me know if any of these options hit your goals for what your looking for here or not. If not then just let me know; I could probably find another method you could try.

By Jackson Perr · Monday at 06:27 PM1 day

Sign In

Note block plays note again after using a play button and closing the GUI

Featured Replies

Join the conversation

Posts

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

[1.20.1] Custom Effect Help

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

How do you add a mob to spawn around a existing vanilla structure?

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)