Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Entity or TileEntity?

xilef11

By xilef11
in Modder Support

 Share

Recommended Posts

xilef11 Stone Miner

xilef11

Posted
Posted

Hello

 

I need to create a TileEntity in a block that already contains one. I've seen a SuperTile/subtile approach in some mods, but it wouldn't work for me since the parent tile is not ticking while the child tile is.

 

A solution I came up with would be creating a normal entity and making it completely unmovable and indestructible, but I'm not sure how to do that (or if it would work).

 

Any advice?

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

Could you replace the existing TE instance with one of your own? Your replacement would need to do all of the work of the original plus whatever data and logic you want to add (hopefully by extending the class). The trick would be to extract the data from the original TE before it's trashed. The risk is that something somewhere else will cough up a lung because the TE class isn't quite what it expected to see there.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Ernio Reality Controller

Ernio

Posted
Posted

Because we still don't know what are you trying to do - I will encolse the idea in few words: TileEntity is a VERY simple idea - a list of objects in world assigned to some x/y/z where each tick, the world calls onUpdate() on TE that need it and save/load the list to/from memory on unload/load.

 

If you really must (and there is no other way, because some stuff can be done on without any big tricks) you can reinvent the wheel and simply add second "TileEntity" layer with your own implementation.

 

Can be done with WorldSaveData, Server/ClientTickEvent and some smart packet system.

 

Been there, done that. So just saying as a last resort.

1.7.10 is no longer supported by forge, you are on your own.

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted
The answer depends on whether this block is added by your mod or not.

The original TE/Block is added by my mod, but the "new" entity may be defined by my mod or by addons (it will have a known interface)

 

Could you replace the existing TE instance with one of your own? Your replacement would need to do all of the work of the original plus whatever data and logic you want to add (hopefully by extending the class). The trick would be to extract the data from the original TE before it's trashed. The risk is that something somewhere else will cough up a lung because the TE class isn't quite what it expected to see there.

 

That is pretty much what I was talking about with the parent/child TE. I want to keep the "logic" (ticking/new) TE as simple as possible, which would be hard in this case. Of course, I could replace it by a third TE that does the work of both the old one and the one I want to add, but that sounds like a bad idea.

 

Because we still don't know what are you trying to do

Basically, I have an inventory and want to create an object that does "stuff" when the container is activated with a certain pattern of items inside. Note that the container TE is provided by my mod, but the "object that does stuff" may be implemented by something else, extending an abstract class I define. Also that object may or may not be visible.

 

Is there something wrong with using an Entity (and making it invulnerable, unmovable and never despawn on its own) instead of a TE?

 

 

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted
You need to make a new interface then which can be implemented by you or other mods and then have a registration for instances of that interface somewhere (possibly on individual TileEntity instances or globally). Then make calls into the interface methods when needed.

 

Thing is, I would like to keep the "logic" object as flexible as possible, which is why I thought of a TileEntity, leading to the problem that I already have a TE at the position where that object would need to exist, and I can't think of a reasonably simple way of making them coexist.

 

I currently have an interface which supplies the pattern to check for in the container, as well as the class (currently an abstract TE, this is the one I'm thinking of changing to an Entity) of the "logic" object.

 

It would be unnecessarily complex and have some overhead that is not needed.

I'd like to know a few things about the differences...

[*]Is it possible for an Entity to do all the things a TileEntity can do (I'm guessing yes)

[*]What are the things an Entity can do that a TileEntity can't (other than moving :P)

[*]What things must be considered when making an Entity but not a TileEntity (the "unnecessarily complex" part)

[*]Same as previous, but specifically for making an Entity that dosen't move or despawn

[*]Is an Entity (much) slower than a TileEntity

[*]What about rendering (or lack thereof)

 

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted

I see that a TileEntity is the most appropriate thing to use, but it leaves two issues:

 

a) having more than one TE at a single BlockPos dosen't seem practical

b) creating a TE (is it always necessary to register them) without an associated Block

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted

The problem is that the TileEntity for my block isn't updating/ticking, and I don't want it to be because it can be used for decoration, and there may be a lot of them around that may not be "active".

 

Also, wouldn't that reduce flexibility compared to a TE (unless the interface defines all functions of a TE)?

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted
There isn't really a way out of this except to apply a different metadata (block state in 1.8) when there is ticking needed and thereby replace the TE with a ticking version.

 

Can't I just replace the TE in the world (without changing the blockstate)?

Ernio Reality Controller

Ernio

Posted
Posted

Can't I just replace the TE in the world (without changing the blockstate)?

 

TileEntity is assigned to block (e.g Furnace has TileEntityFurnace), you can't replace it without breaking stuff.

 

I seriously don't understand your worrying about performance... Just make TileEntity handle additional interfaces. If you need separation between static and ticking ones - just make two of them.

1.7.10 is no longer supported by forge, you are on your own.

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted
TileEntity is assigned to block (e.g Furnace has TileEntityFurnace), you can't replace it without breaking stuff.

But can I replace an existing TileEntityFurnace by something that extends TileEntityFurnace without changing the block at that position (i.e using world.setTileEntity)?

xilef11 Stone Miner

xilef11

Posted
  • Author
Posted

ok. How do I bind different TileEntities to different BlockStates? My Block currently only implements ITileEntityProvider, and createNewTileEntity only has a metadata param, not a BlockState.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • vals_kenway
      Problem Sync Client-server for Entity Mount

      By vals_kenway · Posted

      Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • TileEntity
      Trying to play any world is stuck on 100% loading and shuts down computer

      By TileEntity · Posted

      Also make a test without EMF (Entity Model Features)
    • TileEntity
      Server Keeps Crashing When I Press E in Creative only

      By TileEntity · Posted

      Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Keep on this thread:  
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Remove rubidium - you are already using embeddium, which is a fork of rubidium

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept