Jump to content

[SOLVED] Button click firing too often


Recommended Posts

Whenever i press my button in my gui, it acts, like im pressing it multiple times (random amount of times)

Here's my gui code:

package com.wizcraft.gui.gui;

import java.util.Arrays;

import org.lwjgl.opengl.GL11;

import com.wizcraft.gui.container.ContainerTableLives;
import com.wizcraft.main.MainRegistry;
import com.wizcraft.main.Reference;
import com.wizcraft.packet.KillMessage;
import com.wizcraft.packet.SlotChangeMessage;
import com.wizcraft.tile.entity.TileEntityTableLives;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.GuiButton;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.resources.I18n;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.StatCollector;

public class GuiTableLives extends GuiContainer{

private final ResourceLocation texture = new ResourceLocation(Reference.MODID, "textures/gui/guiLivTable.png");
EntityPlayer player;
TileEntityTableLives tile;

int xL,yL;

public GuiTableLives(EntityPlayer player, TileEntityTableLives tile) {
	super(new ContainerTableLives(player, tile));
	this.tile = tile;
	this.player = player;

protected void drawGuiContainerForegroundLayer(int x, int y) {
	fontRendererObj.drawString(I18n.format("gui.table_lives.name"), 8, 6, 4210752);
	fontRendererObj.drawString(StatCollector.translateToLocal("container.inventory"), 8, ySize - 96 + 2, 4210752);
	GuiButton button = (GuiButton) buttonList.get(0);
	String[] dsc = {I18n.format("gui.table_lives_hover1.name"), I18n.format("gui.table_lives_hover2.name")};
		this.drawHoveringText(Arrays.asList(dsc), x - guiLeft, y - guiTop, fontRendererObj);


protected void drawGuiContainerBackgroundLayer(float a, int b, int c) {
	this.xSize = 176;
	this.ySize = 166;
	GL11.glColor4f(1F, 1F, 1F, 1F);
	buttonList.add(new GuiButton(0, guiLeft + 72, guiTop + 57, 32, 20, "Kill"));
	drawTexturedModalRect(guiLeft, guiTop, 0, 0, xSize, ySize);

protected void actionPerformed(GuiButton button){
		case 0:
				MainRegistry.network.sendToServer(new KillMessage());
				MainRegistry.network.sendToServer(new SlotChangeMessage(tile.xCoord, tile.yCoord, tile.zCoord));


Link to comment
Share on other sites

1. Too fast bump (much too fast).


2. You are adding infinite number of "new GuiButton" to your gui. basically - each FPS, one more button. If buttons overlay each other - all will be pressed, thus - multiple clicks.


3. You should be adding Buttons in initGui() (not neccessary, the point is - do it once).


4. Point of interest: minecraft handles buttonList.clear() for you (just before initGui() is called), but if you were to call initGui() on your own, or add more buttons while gui is alredy opened - remember to clear the list 1st (or remove unused). I am refering to guis that have e.g multiple pages with different buttons on each.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.