[1.8.9] Changing the Values of Bow Damage

[NovaViper]

Also, the reason why I was asking about the damage because I'm trying to hurry and setup my wiki page before I add a ton more stuff into the mod.

[Choonster]

Oh, I did forgot to ask one question (sorry if this counts as bumping, I just want it to stay in the same thread in case someone comes across this) I did finally manage to figure out how to set the damage of the bows. Now my question is how do I know the number im putting in is the acutal damage that an entity takes?

 

Arrows deal damage to the entity they hit in

EntityArrow#onUpdate

(lines 292 to 316 in Forge 1.8.9-11.15.1.1763). This is determined by multiplying the arrow's base damage with its motion (the magnitude of the vector composed of the

motionX

/

Y

/

Z

values) and then adding a random bonus if it's a critical hit.  The base damage of the arrow is set when it's fired from the bow, this is 2.0 by default. If the bow has the Power enchantment, it adds 0.5 damage plus a further 0.5 damage for each level.

 

Edit: The base damage is 2.0, not 20.

[NovaViper]

So it takes 20 hearts by default? What I did in that method that you made is set the arrow damage with a given number like this:

 

		if (!playerNeedsAmmo || playerHasAmmo(stack, player)) {
		float velocity = (float) charge / 20.0f;
		velocity = (velocity * velocity + velocity * 2.0f) / 3.0f;

		if (velocity < 0.1f) {
			return;
		}

		if (velocity > 1.0f) {
			velocity = 1.0f;
		}

		EntityArrow entityArrow = new EntityArrow(world, player, velocity * 2.0f);
		entityArrow.setDamage(damage);
		if (velocity == 1.0f) {
			entityArrow.setIsCritical(true);
		}

		int powerLevel = EnchantmentHelper.getEnchantmentLevel(Enchantment.power.effectId, stack);
		if (powerLevel > 0) {
			entityArrow.setDamage(damage + powerLevel * 0.5D + 0.5D);
		}

 

Which the damage variable is 6 for my Ballistic Bow. Would this be 60 hearts or 12 years?

[Choonster]

1 damage is half a heart.

[NovaViper]

Oh, so that would mean 6 damage is 3 hearts right?

[NovaViper]

Ok.. I notice something odd is going on. I think the numbers I'm putting in for my arrow is being multiplied a lot since I set a mob's health to 20 and the arrow one-hit kills it, I set it to 40 and it takes two shots to kill it

[Choonster]

1 damage takes away 1 health. Each heart is 2 health.

 

Like I said in my previous post, the arrow's base damage is multiplied by the magnitude of its motion vector to determine the actual damage. A decently charged arrow can easily have a velocity of 1.0, which results in a motion of roughly 2.97 when hitting a fairly close target. This is also a critical, which applies bonus damage.

 

I said in my previous post that the base damage of the arrow is 20, it's actually 2.0 (I wasn't paying enough attention).

 

The damage is actually rounded up after being multiplied with the motion, so 2.97 * 2.0 becomes 6 damage (before the critical bonus).

[NovaViper]

Oh.. so the variable I put in makes it to 13-14. Thanks for telling me that ^^