[1.8] Apply Vanilla Enchanted Book to Custom Shears in Anvil

[jeffryfisher]

I have created custom shears extending ItemShears (maybe that was a mistake). I want them to be enchantable in all cases that vanilla (iron) shears are enchantable. Sadly, my custom shears run afoul of a line in vanilla enchantment code where item == Items.shears (not instanceof). I wish the test could be changed to instanceof.

 

The whole chain of "canApply..." methods are written into class Enchantment and the children for specific enchantments. I haven't found any call-backs to item objects where my custom shears could override something to assert their enchantability, even in an anvil. I've made some headway on the enchanting table, but the anvil is thus far resisting my efforts.

 

My test case (on anvil in survival mode): custom shears as input1, and an enchanted book with eff V as input2. The output slot is empty, and there's an ugly red X before it. I want the X to go away, and I want enchanted (Eff V) custom shears in the output slot.

 

If there's a Forge event somewhere in the call chain, I'm not seeing it. I tried overriding isBookEnchantable, but no joy. Maybe I'm almost there but blind to something obvious?

 

For what it's worth, my shears class:

 

public class classRubyShears extends ItemShears {

 

  protected static final Item.ToolMaterial toolMaterial = classNetherGemMod.toolRuby;

  protected static final float efficiencyOnProperMaterial = toolMaterial.getEfficiencyOnProperMaterial ();

 

  public classRubyShears(String name) {

    super ();

    this.setUnlocalizedName (name);

    this.setMaxDamage (toolMaterial.getMaxUses ());

    classNetherGemMod.regItem (this); // set texture & maybe tab, then register

  }

 

  /**

  * Return true if anvil can repair damage on item in stack1 using material item in stack2.

  * This does not enable book application. On the contrary, returning true precludes magic processing,

  * so NEVER return true for enchanted books in stack2

  */

  @Override

  public boolean getIsRepairable(ItemStack tool, ItemStack gem) {

    return gem.getItem () == classNetherGemMod.itemRuby;

  }

 

  @Override

  public int getItemEnchantability() {

    return this.toolMaterial.getEnchantability ();      // Enchantable on a crafting table

  }

 

  /**

  * Allow or forbid the specific book/item combination as an anvil enchant

  *

  * @param stack The item

  * @param book The book

  * @return if the enchantment is allowed

  */

  public boolean isBookEnchantable(ItemStack stack, ItemStack book) {

    NBTTagList enchants = Items.enchanted_book.getEnchantments (book);

 

    if (enchants != null) {

      for (int i = 0; i < enchants.tagCount (); i++ ) {

        short enchId = enchants.getCompoundTagAt (i).getShort ("id");

        switch (enchId) {

          case 32:

          case 33:

          case 34:

          case 35:

          case 70:

            return true;

        }

        if (enchId == classNetherGemMod.smartHarvest.effectId) return true; // Not constant enough to use inside switch

      }

    }

    return false;

  }

}

 

 

EDIT: I've found something called ForgeHooks.onAnvilChange that might fill the bill. I'll give it a go this week.