Search the Forums BEFORE making a new post.

[1.8.9]ITickable not ticking

Posted March 8, 20169 yr

Pretty much as the topic describes, I've got an ITickable object that isn't ticking, and I'm not sure why. (It used to work)

Here's the class:

package com.nosrick.masterofmagic.trackers;

import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.FilenameFilter;
import java.io.IOException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;

import com.nosrick.masterofmagic.MoMMod;
import com.nosrick.masterofmagic.items.wands.ItemBaseWand;
import com.nosrick.masterofmagic.packets.PlayerManaChangePacket;
import com.nosrick.masterofmagic.utils.PlayerUtils;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ITickable;
import net.minecraft.world.World;
import net.minecraft.world.WorldSavedData;
import net.minecraft.world.storage.MapStorage;

public final class PlayerManaTracker extends WorldSavedData implements ITickable
{
protected static final String s_Key = "MoMCraftManaTracker";

protected Map m_ManaTracker;
protected Map m_ManaTickers;

protected static final int STARTING_MANA = 100;
protected static final int MAX_MANA_TICKER = 600;

protected NBTTagCompound m_NBT;

public PlayerManaTracker() 
{
	super(s_Key);
	m_ManaTracker = new HashMap();
	m_ManaTickers = new HashMap();
}

public PlayerManaTracker(String mapName) 
{
	super(mapName);
	m_ManaTracker = new HashMap();
	m_ManaTickers = new HashMap();
}   

public void ModMana(EntityPlayer player, int value)
{
	if(m_ManaTracker == null)
	{
		m_ManaTracker = new HashMap();
	}

	if(m_ManaTickers == null)
	{
		m_ManaTickers = new HashMap();
	}

	if(m_ManaTracker.containsKey(player.getUniqueID()))
	{
		int mana = (Integer)m_ManaTracker.get(player.getUniqueID());

		ItemStack itemStack = PlayerUtils.FindWand(player);
		if(itemStack == null)
			return;

		ItemBaseWand wand = (ItemBaseWand)itemStack.getItem();
		mana = Math.min(wand.GetMaxMana(), mana + value);

		m_ManaTracker.put(player.getUniqueID(), mana);
	}
	else
	{
		m_ManaTracker.put(player.getUniqueID(), STARTING_MANA + value);
	}
	MoMMod.s_NetworkChannel.sendTo(new PlayerManaChangePacket(m_ManaTracker.get(player.getUniqueID()).toString()), (EntityPlayerMP) player);
	markDirty();
}

public void SetMana(EntityPlayer player, int value)
{
	if(m_ManaTracker.containsKey(player.getUniqueID()))
	{
		m_ManaTracker.put(player.getUniqueID(), value);
	}
	else
	{
		m_ManaTracker.put(player.getUniqueID(), STARTING_MANA);
	}
	MoMMod.s_NetworkChannel.sendTo(new PlayerManaChangePacket(Integer.toString(value)), (EntityPlayerMP) player);
	markDirty();
}

public int GetMana(UUID uuid)
{
	if(m_ManaTracker.containsKey(uuid))
	{
		return (Integer)m_ManaTracker.get(uuid);
	}
	else
	{
		m_ManaTracker.put(uuid, STARTING_MANA);
		return STARTING_MANA;
	}
}

@Override
public void update() 
{
	List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

	for(int i = 0; i < players.size(); i++)
	{
		EntityPlayer player = players.get(i);
		UUID uuid = player.getUniqueID();

		if(m_ManaTickers.containsKey(uuid))
		{
			int ticker = (Integer)m_ManaTickers.get(uuid);
			ticker -= 1;

			if(ticker <= 0)
			{
				ItemStack wandStack = PlayerUtils.FindWand(player);
				if(wandStack == null)
					return;

				ItemBaseWand wand = (ItemBaseWand)wandStack.getItem();

				if(!m_ManaTracker.containsKey(uuid))
				{
					m_ManaTracker.put(uuid, STARTING_MANA);
				}

				int mana = (Integer)m_ManaTracker.get(uuid);
				if(mana < wand.GetMaxMana())
				{
					m_ManaTickers.put(uuid, MAX_MANA_TICKER);
					ModMana(player, 1);
				}
			}
			else
			{
				m_ManaTickers.put(uuid, ticker);
			}
		}
		else
		{
			m_ManaTickers.put(uuid, MAX_MANA_TICKER);
		}
	}
}

@Override
public void readFromNBT(NBTTagCompound nbt)
{
	String allPlayersMana = nbt.getString("manaTracker");
	String[] playersAndMana = allPlayersMana.split(",");
	for(int i = 0; i < playersAndMana.length; i++)
	{
		String[] split = playersAndMana[i].split(":");

		UUID playerID;
		int mana;
		playerID = UUID.fromString(split[0].trim());
		mana = Integer.parseInt(split[1].trim());
		m_ManaTracker.put(playerID, mana);			
	}
}

@Override
public void writeToNBT(NBTTagCompound nbt) 
{
	String allPlayersMana = "";
	Object[] players;
	Object[] mana;

	players = m_ManaTracker.keySet().toArray();
	mana = m_ManaTracker.values().toArray();
	for(int i = 0; i < m_ManaTracker.size(); i++)
	{
		allPlayersMana += players[i].toString();
		allPlayersMana += ":" + mana[i].toString() + ",";
	}
	allPlayersMana = (String)allPlayersMana.subSequence(0, allPlayersMana.length() - 1);

	nbt.setString("manaTracker", allPlayersMana);
}

public static PlayerManaTracker Get(World world) 
{
	PlayerManaTracker data = (PlayerManaTracker)world.loadItemData(PlayerManaTracker.class, s_Key);
	if (data == null) 
	{
		data = new PlayerManaTracker();
		world.setItemData(s_Key, data);
	}
	return data;
}
}

Unfortunately, for some reason, update isn't being called at all.

Quote

March 8, 20169 yr

ITickable doesnt work for WorldSavedData. I think it only works for TileEntities

Quote

March 8, 20169 yr

From reading your code it looks like you are triing to give your player mana. You should do that using the new capability system, not worldsaved data https://mcforge.readthedocs.org/en/latest/datastorage/capabilities/

(btw how to make clickable links?)

Quote

March 8, 20169 yr

ITickable

s have to be registered for Minecraft to tick them. This is done automatically for

TileEntities

, but you can register other tickables using

MinecraftServer#registerTickable

(btw how to make clickable links?)

[nobbc]Like this[/nobbc]

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

March 8, 20169 yr

Author

ITickable
s have to be registered for Minecraft to tick them. This is done automatically for
TileEntities
, but you can register other tickables using
MinecraftServer#registerTickable
.

I tried this, but it doesn't seem to be working. No errors or anything, just doesn't bother calling the update() function.

From reading your code it looks like you are triing to give your player mana. You should do that using the new capability system, not worldsaved data https://mcforge.readthedocs.org/en/latest/datastorage/capabilities/

(btw how to make clickable links?)

Thanks for pointing this out; I've never heard of it before, so I'll give it a shot. Will report back with progress.

Quote

March 8, 20169 yr

ITickable
s have to be registered for Minecraft to tick them. This is done automatically for
TileEntities
, but you can register other tickables using
MinecraftServer#registerTickable
.
I tried this, but it doesn't seem to be working. No errors or anything, just doesn't bother calling the update() function.

If you set a breakpoint, is

MinecraftServer#registerTickable

definitely being called? Are you sure your

update

method isn't being called?

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

March 8, 20169 yr

Author

If you set a breakpoint, is
MinecraftServer#registerTickable
definitely being called? Are you sure your
update
method isn't being called?

It's not, but then I'm not sure I'm trying to call it in the right place. My ServerProxy.Init() method is trying calling it, but that method never gets called, either. Is that correct?

And I put a breakpoint on the update() method; it never, ever gets hit.

Quote

March 8, 20169 yr

Author

(Sorry for the double post, but I've been messing around a bit.)

So I've got it calling, but now it tells me there's NoSuchMethod.

Here's the offending line: (Called in an event hook's OnWorldLoad() function)

MinecraftServer.getServer().registerTickable(PlayerManaTracker.Get(event.world));

Now, doing MinecraftServer.registerTickable() tells me I can't use a non-static function from a static instance.

Quote

March 8, 20169 yr

I'm not sure if it's a widely-used convention, but I use

ClassName.memberName

to denote a static method/field and

ClassName#memberName

to denote an instance method/field.

In this case,

registerTickable

is an instance method so it needs to be called on an instance of

MinecraftServer

(returned from the

MinecraftServer.getServer

method). You already seem to be doing this, though.

Could you be more specific about which method the

NoSuchMethodError

is being thrown for?

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

March 8, 20169 yr

Author

Could you be more specific about which method the
NoSuchMethodError
is being thrown for?

Ah, sorry, it's the registerTickable() method that's throwing it. I tried rebuilding all my forge and gradle stuff, as well as a brand new install, but it still throws that error. I'm using Forge 1764, I believe.

EDIT: I tried it with a fresh install of 1722, as well. No dice. Still get the same error.

Quote

March 8, 20169 yr

Could you be more specific about which method the
NoSuchMethodError
is being thrown for?
Ah, sorry, it's the registerTickable() method that's throwing it. I tried rebuilding all my forge and gradle stuff, as well as a brand new install, but it still throws that error. I'm using Forge 1764, I believe.

EDIT: I tried it with a fresh install of 1722, as well. No dice. Still get the same error.

The method certainly exists in my installs of 1764 and 1763. Can you see it in the

MinecraftServer

class in your IDE?

Are you running your mod in your IDE or building it and running it in a normal client?

Upload the FML log (logs/fml-client-latest.log) to Gist and link it here.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

March 8, 20169 yr

Author

Yup, I can see it in the IDE. Also, I've tried running it in both IDE and regular Minecraft. Same thing happens in both.

Here's the Gist:

https://gist.github.com/anonymous/a57d258ae129a993f593

Quote

March 8, 20169 yr

net.minecraft.server.MinecraftServer.registerTickable(Lnet/minecraft/util/ITickable;)

that sounds like it is actually your playermana.get is the one having problems.

Current Project: Armerger

Planned mods: Light Drafter | Ore Swords

Looking for help getting a mod off the ground? Coding | Textures

Quote

March 8, 20169 yr

Author

net.minecraft.server.MinecraftServer.registerTickable(Lnet/minecraft/util/ITickable;)

that sounds like it is actually your playermana.get is the one having problems.

Just tried it with a blank ITickable implementation: same error.

Quote

March 8, 20169 yr

Can you post your CommonProxy imports and init()

Current Project: Armerger

Planned mods: Light Drafter | Ore Swords

Looking for help getting a mod off the ground? Coding | Textures

Quote

March 8, 20169 yr

Author

Here we go:

package com.nosrick.masterofmagic;

import com.nosrick.masterofmagic.blocks.BlockHandler;
import com.nosrick.masterofmagic.enchantments.EnchantmentHandler;
import com.nosrick.masterofmagic.entities.EntityGuardianSpirit;
import com.nosrick.masterofmagic.items.ItemHandler;
import com.nosrick.masterofmagic.tileentities.TileEntityHandler;
import com.nosrick.masterofmagic.trackers.PlayerManaTracker;

import net.minecraft.init.Blocks;
import net.minecraft.server.MinecraftServer;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.registry.EntityRegistry;

public class CommonProxy 
{    
@EventHandler
    public void preInit(FMLPreInitializationEvent event)
    {
	ItemHandler.Initialise();
	EnchantmentHandler.PreInitialise();
	BlockHandler.PreInitialise();
	TileEntityHandler.Initialise();
    }
    
    @EventHandler
    public void init(FMLInitializationEvent event)
    {
    	EnchantmentHandler.Initialise();
    	EntityRegistry.registerModEntity(EntityGuardianSpirit.class, "guardian_spirit", EntityRegistry.findGlobalUniqueEntityId(), 
    			MoMMod.instance, 16, 2, true);
    	//MinecraftServer.getServer().registerTickable(new PlayerManaTracker()); FOR TESTING PURPOSES, USUALLY USE PlayerManaTracker.Get()
    }
    
    @EventHandler
    public void postInit(FMLPostInitializationEvent event)
    {
    }
}

Quote

March 8, 20169 yr

Are you trying to call it on client side ?

You shouldn't.

Also fix this:

@Override
public void update()
{
List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

Quote

March 8, 20169 yr

Author

Are you trying to call it on client side ?

You shouldn't.

Also fix this:
@Override
public void update()
{
List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

Oh dear. That's embarrassing. That was from my first day of Minecraft modding and I haven't updated it since. Sorry about that!

And no, I'm not calling it client side, but I am trying to fetch players the client side way, stupidly. I won't make that mistake again.

Quote

March 8, 20169 yr

Simply make sure you are only MinecraftServer#registerTickables on server side.

Besides, you have @EventHandler annotations in your proxy class. They should be restricted to your @Mod class.

And please don't use

EntityRegistry.findGlobalUniqueEntityId()

You do not need a global entity id.

Quote

March 8, 20169 yr

Author

Simply make sure you are only MinecraftServer#registerTickables on server side.

Besides, you have @EventHandler annotations in your proxy class. They should be restricted to your @Mod class.

And please don't use
EntityRegistry.findGlobalUniqueEntityId()
You do not need a global entity id.

I've done all of these, now. Thanks for the tips!

Quote

March 8, 20169 yr

Author

Guys, guys, what the hell are you doing?

WorldSavedData is not the right tool for this. Stop using it!

Use Capabilities, like BusyBeever already pointed out, or IEEP (deprecated in favor of capabilities).

How would I go about ticking the player's mana so that it slowly restores using capabilities?

Quote

March 8, 20169 yr

Author

Subscribe to PlayerTickEvent (make sure to check event.phase), get the capability and call some method on it.

I'll give it a shot, thank you. Will report back with progress tomorrow.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/36998-189itickable-not-ticking/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · 7 hours ago7 hr
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Yesterday at 12:07 AM1 day
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Wednesday at 04:08 PM1 day
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Wednesday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Wednesday at 04:14 AM2 days

Astoxy

Sign In

[1.8.9]ITickable not ticking

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)