Jump to content

[1.8.9][Packet/GUI] Creating a custom merchant : packet to pass entity to gui ?


Recommended Posts

Posted

Good evening guys,

 

I'm currently trying to create a custom EntityMerchant. Basically, it works the same as the EntityVillager from Minecraft, except that I want to control all the transactions for each merchant (from a DB for example).

 

My entity is currently created, its name is Timmy (yes), and I can't figure out how I could pass the entityId to a gui triggered from server side, so that I can get an Entity object once the gui is open. I took a look at the EntityVillager code : when interacting with the Entity, it displays the villager trade gui passing the Entity (as this) :

 

    /**
     * Called when a player interacts with a mob. e.g. gets milk from a cow, gets into the saddle on a pig.
     */
    public boolean interact(EntityPlayer player)
    {
        ItemStack itemstack = player.inventory.getCurrentItem();
        boolean flag = itemstack != null && itemstack.getItem() == Items.spawn_egg;

        if (!flag && this.isEntityAlive() && !this.isTrading() && !this.isChild() && !player.isSneaking())
        {
            if (!this.worldObj.isRemote && (this.buyingList == null || this.buyingList.size() > 0))
            {
                this.setCustomer(player);
                player.displayVillagerTradeGui(this);
            }

            player.triggerAchievement(StatList.timesTalkedToVillagerStat);
            return true;
        }
        else
        {
            return super.interact(player);
        }
    }

 

Looking more closely at the code, it seems that a S2DPacketOpenWindow packet is sent. The thing that I don't understand is the way I could possibly do the same (or the entityId), using Forge GuiHandler. Sending a packet ? Why not, but what after then ?

 

Furthermore, LexManos shared a trick to pass the entityId through an int (can't find the topic) in the getServerGuiElement method from GuiHandler, but I still don't know what to do next. It is some kind of missunderstanding here that I would like to kill.

 

Thank you for your time and you help. :)

Squirrel ! Squirrel ! Squirrel !

Posted

Thank you guys.

 

Yet, something bugs me : what would be the interest to go through a packet to open a gui instead of opening it directly ?

In my case, I can avoid using a packet to open the gui, since I can directly pass the entity id in the openGui method.

 

I saw few posts on this forum that advise to use packet to open gui.

 

giphy.gif

Squirrel ! Squirrel ! Squirrel !

Posted

If you do stuff on client - server doesn't know about it. Even if you'd send packet telling server that you did something, server might not really "accept it" - meaning: client opens gui, sends packet with request but on server it happens that "you are not allowed to open the gui right now", but its alredy opened on client - boom, not desired outcome. (same goes with interaction - since client only has "predicted" server values, some things might be true on client and false on server).

 

I for one always code stuff in order: client -> req -> server decides -> packet (or GuiHandler call) -> client does stuff server tells.

 

All in all - is depends on what you need and if server needs to know what you do. You can even open gui directly from Minecraft class.

 

Mind that if client alredy has values that need to be displayed on gui and server doesnt need to know shit, you are free to operate on client only. E.g: Display player stats from IEEP/Capabilities which you KNOW are always synced.

1.7.10 is no longer supported by forge, you are on your own.

Posted

If you do stuff on client - server doesn't know about it. Even if you'd send packet telling server that you did something, server might not really "accept it" - meaning: client opens gui, sends packet with request but on server it happens that "you are not allowed to open the gui right now", but its alredy opened on client - boom, not desired outcome. (same goes with interaction - since client only has "predicted" server values, some things might be true on client and false on server).

 

I for one always code stuff in order: client -> req -> server decides -> packet (or GuiHandler call) -> client does stuff server tells.

 

All in all - is depends on what you need and if server needs to know what you do. You can even open gui directly from Minecraft class.

 

Mind that if client alredy has values that need to be displayed on gui and server doesnt need to know shit, you are free to operate on client only. E.g: Display player stats from IEEP/Capabilities which you KNOW are always synced.

 

Ok so if I follow your way of coding in order, in my case it would be :

 

Client right clicks on entity --> sends a packet that will be handle to the server --> server decides whether or not to let the client open the gui --> (admitting yes) call openGui method

 

In there, the packet will just be useful to do some "tests" or requirements before deciding to open the gui or not ?

Squirrel ! Squirrel ! Squirrel !

Posted

If you do stuff on client - server doesn't know about it. Even if you'd send packet telling server that you did something, server might not really "accept it" - meaning: client opens gui, sends packet with request but on server it happens that "you are not allowed to open the gui right now", but its alredy opened on client - boom, not desired outcome. (same goes with interaction - since client only has "predicted" server values, some things might be true on client and false on server).

 

I for one always code stuff in order: client -> req -> server decides -> packet (or GuiHandler call) -> client does stuff server tells.

 

All in all - is depends on what you need and if server needs to know what you do. You can even open gui directly from Minecraft class.

 

Mind that if client alredy has values that need to be displayed on gui and server doesnt need to know shit, you are free to operate on client only. E.g: Display player stats from IEEP/Capabilities which you KNOW are always synced.

 

Ok so if I follow your way of coding in order, in my case it would be :

 

Client right clicks on entity --> sends a packet that will be handle to the server --> server decides whether or not to let the client open the gui --> (admitting yes) call openGui method

 

In there, the packet will just be useful to do some "tests" or requirements before deciding to open the gui or not ?

 

When the player right clicks on an entity, the client sends a packet to the server and then calls the entity's interaction method (this actually happens up to twice, once for

Entity#interactAt

and once for

Entity#interactFirst

; the second packet and call only happen if the first returned

false

). This happens in

Minecraft#rightClickMouse

 

When the server receives these packets, it first checks that the entity exists and the player is close enough to interact with it. If these conditions are met, it calls the interaction method that the packet was sent for. This happens in

NetHandlerPlayServer#processUseEntity

.

 

You should open your GUI from the server-side call of

EntityLiving#interact

(called from

Entity#interactFirst

), i.e. when

world.isRemote

is

false

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

When the player right clicks on an entity, the client sends a packet to the server and then calls the entity's interaction method (this actually happens up to twice, once for

Entity#interactAt

and once for

Entity#interactFirst

; the second packet and call only happen if the first returned

false

). This happens in

Minecraft#rightClickMouse

 

When the server receives these packets, it first checks that the entity exists and the player is close enough to interact with it. If these conditions are met, it calls the interaction method that the packet was sent for. This happens in

NetHandlerPlayServer#processUseEntity

.

 

You should open your GUI from the server-side call of

EntityLiving#interact

(called from

Entity#interactFirst

), i.e. when

world.isRemote

is

false

.

 

Actually, I do this :

 

    @Override
    protected boolean       interact(EntityPlayer player) {
        ItemStack           itemstack = player.inventory.getCurrentItem();
        boolean             flag = itemstack != null && itemstack.getItem() == Items.spawn_egg;
        boolean             flag2 = itemstack != null && itemstack.getItem() == Items.name_tag;

        if (this.isEntityAlive() && !player.isSneaking()) {
            if (this.worldObj.isRemote) {
                player.openGui(Main.instance, Reference.GuiIdentifiers.GUI_MERCHANT, this.worldObj, this.getEntityId(), 0, 0);
            }
            return (true);
        } else if (flag && player.isSneaking())
            this.setDead();
        else if (flag2 && player.isSneaking()) {
            this.changeCustomName();
        }
        return super.interact(player);
    }

 

the isRemote being true is just a test to open a GuiScreen to draw the Entity currently rightclicked the same way it happens when you open a horse inventory. I think I have to tell you what I really want to do. In fact, I have so much questions that are related to my goal but can't be asked in the context of this topic.

 

I want to create an EntityMerchant that acts as an EntityVillager. When rightclicking on it, it opens an interface in which the player can trade with the merchant. While the interface is open,

. The EntityMerchant clicked is being drawn on the gui and all the possible trades that the player can do are related to the entityId. When the player quit the interface, the music stops.

 

For this goal, I suppose I have to trade my GuiScreen for a GuiContainer. This would require a server handling. That is all I've thought about for now.

Squirrel ! Squirrel ! Squirrel !

Posted

When #isRemote is true, that means your code is currently on the logical client side, and is NOT when you want to open container-based GUIs.

 

Entity#interact is called on BOTH client and server side during the interaction process - first on the client during the initial mouse-click, then again on the server after the server receives a packet. You should open the GUI when the world is not remote, i.e. on the server side, since the GuiHandler will open both the Container (server side) and the GUI (client side) automatically when invoked on the server.

 

If you were in a situation that didn't have Minecraft automatically sending packets for you, say you wanted to open your Container-based GUI by a key press instead of entity interaction, then you'd have to do as Ernio said and send your own packet from the client requesting the server to open the GUI.

 

The only time you should open a GUI directly on/from the client side is when there is only a GUI component (no Container) and there are not any important conditions to the GUI being opened. If, for a non-Container based GUI, it is important to know for sure the player is e.g. close enough to the entity, then you should send a packet from the server to the client to open the GUI.

Posted

When #isRemote is true, that means your code is currently on the logical client side, and is NOT when you want to open container-based GUIs.

 

Yes, I did know that, I took some time last days reading the Sides concept on readthedocs.

 

*snip*

 

If you were in a situation that didn't have Minecraft automatically sending packets for you, say you wanted to open your Container-based GUI by a key press instead of entity interaction, then you'd have to do as Ernio said and send your own packet from the client requesting the server to open the GUI.

 

Ok, that makes more sense to me now, thank you all. If I have the possibility to open the gui calling EntityPlayer#openGui directly, then I can do it. Otherwise I would need to send a packet from client to server (will be handled to the server then) that will be able to make some checks then opening the gui.

 

The only time you should open a GUI directly on/from the client side is when there is only a GUI component (no Container) and there are not any important conditions to the GUI being opened. If, for a non-Container based GUI, it is important to know for sure the player is e.g. close enough to the entity, then you should send a packet from the server to the client to open the GUI.

 

That means the packet will be handled in the client ? Which method should I call then ? EntityPlayer#openGui to pass through the GuiHandler or another one from Minecraft base code ?

Squirrel ! Squirrel ! Squirrel !

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • But your Launcher does not find it   Java path is: /run/user/1000/doc/3f910b8/java Checking Java version... Java checker returned some invalid data we don't understand: Check the Azul Zulu site and select your OS and download the latest Java 8 build for Linux https://www.azul.com/downloads/?version=java-8-lts&package=jre#zulu After installation, check the path and put this path into your Launcher Java settings (Java Executable)
    • Try other builds of pehkui and origins++ until you find a working combination
    • Some Create addons are only compatible with Create 6 or Create 5 - so not both versions at the same time Try older builds of Create Stuff and Additions This is the last build before the Create 6 update: https://www.curseforge.com/minecraft/mc-mods/create-stuff-additions/files/6168370
    • ✅ Crobo Coupon Code: 51k3b0je — Get Your \$25 Amazon Gift Card Bonus! If you’re new to Crobo and want to make the most out of your first transaction, you’ve come to the right place. The **Crobo coupon code: 51k3b0je** is a fantastic way to get started. By using this code, you can unlock an exclusive **\$25 Amazon gift card** after completing your first eligible transfer. Let’s dive deep into how the **Crobo coupon code: 51k3b0je** works, why you should use it, and how to claim your reward. --- 🌟 What is Crobo? Crobo is a trusted, modern platform designed for **international money transfers**. It offers fast, secure, and low-cost transactions, making it a favorite choice for individuals and businesses alike. Crobo is committed to transparency, low fees, and competitive exchange rates. And with promo deals like the **Crobo coupon code: 51k3b0je**, it becomes even more attractive. Crobo focuses on providing customers with: * Quick transfer speeds * Minimal fees * Safe, encrypted transactions * Great referral and promo code rewards When you choose Crobo, you’re choosing a platform that values your time, money, and loyalty. And now with the **Crobo coupon code: 51k3b0je**, you can start your Crobo journey with a **bonus reward**! ---# 💥 What is the Crobo Coupon Code: 51k3b0je? The **Crobo coupon code: 51k3b0je** is a **special promotional code** designed for new users. By entering this code during signup, you’ll be eligible for: ✅ A **\$25 Amazon gift card** after your first qualifying transfer. ✅ Access to Crobo’s referral system to earn more rewards. ✅ The ability to combine with future seasonal Crobo discounts. Unlike generic promo codes that just offer small fee reductions, the **Crobo coupon code: 51k3b0je** directly gives you a tangible, valuable reward — perfect for online shopping or gifting. --- ### 🎯 Why Use Crobo Coupon Code: 51k3b0je? There are many reasons why users choose to apply the **Crobo coupon code: 51k3b0je**: 🌟 **Free bonus reward** — Your first transfer can instantly earn you a \$25 Amazon gift card. 🌟 **Trusted platform** — Crobo is known for secure, fast, and affordable transfers. 🌟 **Easy to apply** — Simply enter **Crobo coupon code: 51k3b0je** at signup — no complicated steps. 🌟 **Referral opportunities** — Once you’ve used **Crobo coupon code: 51k3b0je**, you can invite friends and earn more rewards. 🌟 **Stackable savings** — Pair **Crobo coupon code: 51k3b0je** with Crobo’s ongoing offers or holiday deals for even more benefits. --- ### 📝 How to Use Crobo Coupon Code: 51k3b0je Getting started with **Crobo coupon code: 51k3b0je** is quick and easy. Just follow these steps: 1️⃣ **Download the Crobo app** (available on Google Play Store and Apple App Store) or visit the official Crobo website. 2️⃣ **Start the sign-up process** by entering your basic details (name, email, phone number, etc.). 3️⃣ When prompted, enter **Crobo coupon code: 51k3b0je** in the promo code or coupon code field. 4️⃣ Complete your first transaction — be sure to meet the minimum amount required to qualify for the reward (usually specified in Crobo’s promo terms). 5️⃣ After the transaction is verified, receive your **\$25 Amazon gift card** directly via email or within your Crobo account. --- ### 💡 Tips to Maximize Your Crobo Coupon Code: 51k3b0je Bonus 👉 **Transfer the minimum qualifying amount or more** — this ensures you meet the conditions for the gift card. 👉 **Refer friends after your signup** — Crobo allows users who’ve signed up with codes like **Crobo coupon code: 51k3b0je** to share their own code for extra bonuses. 👉 **Check for additional Crobo promotions** — sometimes Crobo offers seasonal or regional deals that stack with the coupon code. 👉 **Complete your transaction soon after signup** — many bonuses have time limits, so act quickly! --- ### 🚀 Frequently Asked Questions about Crobo Coupon Code: 51k3b0je **Q: Can I use Crobo coupon code: 51k3b0je if I already have a Crobo account?** A: No — the **Crobo coupon code: 51k3b0je** is intended for **new users only**. It must be applied during the initial registration process. --- **Q: How long does it take to get the \$25 Amazon gift card after using Crobo coupon code: 51k3b0je?** A: Typically, the gift card is sent **within a few business days** after your first qualifying transfer is completed and verified. --- **Q: Are there hidden fees when using Crobo coupon code: 51k3b0je?** A: No — Crobo is transparent about its fees. The **Crobo coupon code: 51k3b0je** simply adds a bonus reward without increasing your costs. --- **Q: Can I combine Crobo coupon code: 51k3b0je with other promo codes?** A: The **Crobo coupon code: 51k3b0je** is generally applied as a standalone signup bonus. However, Crobo often offers **ongoing promotions** that may apply to future transactions. ---  📌 Reference Crobo promo code: {51k3b0je} Crobo discount code: {51k3b0je} --- # 🌍 Final Thoughts If you want to enjoy safe, fast, and affordable money transfers with an added bonus, **Crobo coupon code: 51k3b0je** is your best option. Not only will you experience excellent service, but you’ll also earn a **\$25 Amazon gift card** — a reward that you can use immediately for shopping or gifts. 👉 **Don’t wait — sign up today using Crobo coupon code: 51k3b0je and claim your bonus!**
    • Does this schematic contain stuff from the mod prettypipes? Looks like Forgematica has issues to load it Try to load the schematic with worldedit - remove the pipes, save it and test it again
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.