Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[1.8] Ore not generating on differend places than the blockpos that I specified

Featured Replies

Posted

Hi,

 

I have 5 ores which I want to generate in the world but the problem is that my customGenerator Is not working correctly.

 

public boolean generate(World worldIn, Random p_180709_2_, BlockPos p_180709_3_)
    {
        float f = p_180709_2_.nextFloat() * (float)Math.PI;
        double d0 = (double)((float)(p_180709_3_.getX() +  + MathHelper.sin(f) * (float)this.maxVainSize / 8.0F);
        double d1 = (double)((float)(p_180709_3_.getX() +  - MathHelper.sin(f) * (float)this.maxVainSize / 8.0F);
        double d2 = (double)((float)(p_180709_3_.getZ() +  + MathHelper.cos(f) * (float)this.maxVainSize / 8.0F);
        double d3 = (double)((float)(p_180709_3_.getZ() +  - MathHelper.cos(f) * (float)this.maxVainSize / 8.0F);
        double d4 = (double)(p_180709_3_.getY() + p_180709_2_.nextInt(3) - 2);
        double d5 = (double)(p_180709_3_.getY() + p_180709_2_.nextInt(3) - 2);

        for (int i = 0; i < this.maxVainSize; ++i)
        {
            float f1 = (float)i / (float)this.maxVainSize;
            double d6 = d0 + (d1 - d0) * (double)f1;
            double d7 = d4 + (d5 - d4) * (double)f1;
            double d8 = d2 + (d3 - d2) * (double)f1;
            double d9 = p_180709_2_.nextDouble() * (double)this.maxVainSize / 16.0D;
            double d10 = (double)(MathHelper.sin((float)Math.PI * f1) + 1.0F) * d9 + 1.0D;
            double d11 = (double)(MathHelper.sin((float)Math.PI * f1) + 1.0F) * d9 + 1.0D;
            int j = MathHelper.floor_double(d6 - d10 / 2.0D);
            int k = MathHelper.floor_double(d7 - d11 / 2.0D);
            int l = MathHelper.floor_double(d8 - d10 / 2.0D);
            int i1 = MathHelper.floor_double(d6 + d10 / 2.0D);
            int j1 = MathHelper.floor_double(d7 + d11 / 2.0D);
            int k1 = MathHelper.floor_double(d8 + d10 / 2.0D);

            for (int l1 = j; l1 <= i1; ++l1)
            {
                double d12 = ((double)l1 + 0.5D - d6) / (d10 / 2.0D);

                if (d12 * d12 < 1.0D)
                {
                    for (int i2 = k; i2 <= j1; ++i2)
                    {
                        double d13 = ((double)i2 + 0.5D - d7) / (d11 / 2.0D);

                        if (d12 * d12 + d13 * d13 < 1.0D)
                        {
                            for (int j2 = l; j2 <= k1; ++j2)
                            {
                                double d14 = ((double)j2 + 0.5D - d8) / (d10 / 2.0D);

                                if (d12 * d12 + d13 * d13 + d14 * d14 < 1.0D)
                                {
                                    BlockPos blockpos1 = new BlockPos(l1, i2, j2); 
                                    
                                   if (this.isReplacable(worldIn, blockpos1, this.genIn))
                                   {
                                	   //worldIn.setBlockState(blockpos1, this.block, 2); Ores Don't generate if this isn't there but the coordinates in the log aren't right
                                	   
                                	   if (this.genNear == null){
                                		   worldIn.setBlockState(blockpos1, this.block, 2);
                                		   if(ExitedBuilderMod.DEBUG)
                                			   System.out.println("Generating at: " + blockpos1.getX() +","+ blockpos1.getY() +","+ blockpos1.getZ());
                                		   
                                	   }else{
                                		   if(this.isNear(blockpos1, this.genNear, this.genDistance, worldIn))
                                			   worldIn.setBlockState(blockpos1, this.block, 2);
                                	   } 
                                   }
                                }
                            }
                        }
                    }
                }
            }
        }
        return true;
    }

 

This is a modified version of the vanilla ore generator but with the ability to specify the blocks it generates in and the blocks it generates near to. if I uncomment the statement in there the blocks will generate on the right spot (if you move that println directly under it it will tell you the coordinates of the ore when generated ) but If I pass it trought the if (Like the code is now) it will not generate at the spot the println sais it does.

 

Example:

 

[21:50:51] [server thread/INFO] [sTDOUT]: [com.miner11crafter.exitedbuildermod.customs.CustomGenerator:generate:112]: Generating at: 265,24,470

 

but it generated at 265,52,471. Why does it do that? how can I fix it? How can I corectly make blocks generate with a way to generate them in specific blocks and or near specific blocks?

 

If you need more code let me know!

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.