Custom GUI Buttons SPAM when clicked once

[ScottehBoeh]

My Custom GUI buttons seem to spam when they are clicked, as if its spaming because I've not added some sort of "End click" event.

 

Any ideas to why this button is spamming when clicked?

 

package com.mcheroesandgenerals.mainmenu.gui;

 

import net.minecraft.client.Minecraft;

import net.minecraft.client.audio.PositionedSoundRecord;

import net.minecraft.client.audio.SoundHandler;

import net.minecraft.client.gui.GuiButton;

import net.minecraft.item.ItemStack;

import net.minecraft.util.EnumChatFormatting;

import net.minecraft.util.ResourceLocation;

import org.lwjgl.opengl.GL11;

 

public class GuiCustomButton extends GuiButton {

 

    public int isOver = 2;

    private ResourceLocation iconTexture = null;

 

    public ItemStack renderStack = null;

 

    public boolean drawBackground = true;

    public boolean drawShadow = true;

    public String buttonColor = "0x2f2f2f";

    public boolean centeredText = true;

 

    public boolean soundPlayed = true;

 

    public GuiCustomButton(int id, int x, int y, int width, int height, String displayString) {

        super(id, x, y, width, height, displayString);

    }

 

    public GuiCustomButton(int id, int x, int y, ItemStack renderStack) {

        super(id, x, y, 18, 18, "");

        this.renderStack = renderStack;

    }

 

    public GuiCustomButton(int id, int x, int y, int width, int height, String par6, String buttonColor) {

        super(id, x, y, width, height, par6);

        this.buttonColor = buttonColor;

    }

 

    public GuiCustomButton(int id, int x, int y, int width, int height, ResourceLocation iconTexture) {

        super(id, x, y, width, height, "");

        this.iconTexture = iconTexture;

    }

 

    public void drawButton(Minecraft minecraft, int mouseX, int mouseY) {

        if (visible) {

            GL11.glColor4f(1.0F, 1.0F, 1.0F, 1.0F);

            hovered = mouseX >= this.xPosition && mouseY >= this.yPosition && mouseX < this.xPosition + this.width && mouseY < this.yPosition + this.height;

            isOver = getHoverState(hovered);

            if (drawBackground) {

                if (drawShadow) {

                    GuiUtils.drawRectWithShadow(xPosition, yPosition, width, height, buttonColor, 1.0F);

                } else {

                    GuiUtils.drawRect(xPosition, yPosition, width, height, buttonColor, 1.0F);

                }

            }

            mouseDragged(minecraft, mouseX, mouseY);

            String displayText = displayString;

            if (isOver == 2) {

                if (!soundPlayed) {

                    Minecraft.getMinecraft().getSoundHandler().playSound(PositionedSoundRecord.createPositionedSoundRecord(new ResourceLocation("gui.button.press"), 3.5F));

                    soundPlayed = true;

                }

            } else {

                soundPlayed = false;

            }

            if (iconTexture != null) {

                if (isOver == 2) {

                    GuiUtils.renderColor(8421504);

                }

                GuiUtils.drawImage(xPosition + width / 2 - 8, yPosition + (height - - 10, iconTexture, 16.0D, 16.0D);

                GL11.glColor3f(1.0F, 1.0F, 1.0F);

                return;

            }

            if (renderStack != null) {

                GuiUtils.renderItemStackIntoGUI(this.renderStack, xPosition, yPosition + 1);

                return;

            }

            if (!enabled) {

                displayText = EnumChatFormatting.GRAY + displayText;

            }

            if (!centeredText) {

                GuiUtils.renderText(displayText, xPosition + 2, yPosition + (height - / 2, isOver == 2 ? 8421504 : 16777215);

                return;

            }

            GuiUtils.renderCenteredText(displayText, xPosition + width / 2, yPosition + (height - / 2, isOver == 2 ? 8421504 : 16777215);

        }

    }

 

    public void playPressSound(SoundHandler soundHandler) {

        soundHandler.playSound(PositionedSoundRecord.createPositionedSoundRecord(new ResourceLocation("gui.button.press"), 2.0F));

    }

}

 

 

 

Is there an event that I've not nerfed or set to happen once?

[Ernio]

I am certain that you just forgot to clear() buttonList in GuiScreen.

 

1. You should NEVER add buttons from outside initGui() method.

* GuiScreen#buttonList is clear()-ed internally: openGui -> constructor -> buttonList.clear() -> initGui()

 

2. If you are adding buttons during display you need to remove old ones or clear buttonList manually - again - you shouldn't do "new" every tick/frame.