Jump to content

Recommended Posts

Posted

I am modding using minecraft 1.9, and have made a custom dimension. In this dimension, all the blocks are transparent. When I descend below y 62, the sky below me turns black, like the void, and all the transparent blocks look ugly below me, and the fog seems to disappear. I was wondering if there is a way to avoid this (and changing the getVoidFogYFactor() does not help either, it only constantly renders the ugly fog down there or gives me the same problem as before). Another thought I had was to move the entire dimension upwards so the bottom bedrock layer is at level 64 (as in offset its y value) so as to avoid this problem of the fog. However, I don't know much about working with noise and chunk providers, etc.. Here's my code:

 

Chunk Provider:

package com.theflash.dimension;

import com.theflash.blocks.FlashBlocks;
import net.minecraft.block.BlockFalling;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EnumCreatureType;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.ChunkCoordIntPair;
import net.minecraft.world.World;
import net.minecraft.world.biome.BiomeGenBase;
import net.minecraft.world.chunk.Chunk;
import net.minecraft.world.chunk.ChunkPrimer;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.gen.MapGenBase;
import net.minecraft.world.gen.MapGenCavesHell;
import net.minecraft.world.gen.NoiseGeneratorOctaves;
import net.minecraft.world.gen.structure.MapGenNetherBridge;

import java.util.List;
import java.util.Random;

public class ChunkProviderSpeedForce implements IChunkGenerator
{
protected static final IBlockState stateAir = Blocks.air.getDefaultState();
protected static final IBlockState stateSpeedForceOre = FlashBlocks.speedForceOre.getDefaultState();
protected static final IBlockState stateBedrock = Blocks.bedrock.getDefaultState();
//protected static final IBlockState field_185943_d = Blocks.lava.getDefaultState();
//protected static final IBlockState field_185944_e = Blocks.gravel.getDefaultState();
//protected static final IBlockState field_185945_f = Blocks.soul_sand.getDefaultState();
private final World world;
private final boolean field_185953_o;
private final Random rand;
public NoiseGeneratorOctaves field_185946_g;
public NoiseGeneratorOctaves field_185947_h;
double[] field_185948_i;
double[] field_185949_j;
double[] field_185950_k;
double[] noiseData4;
double[] field_185951_m;
/**
 * Holds the noise used to determine whether slowsand can be generated at a location
 */
private double[] slowsandNoise = new double[256];
private double[] gravelNoise = new double[256];
private double[] field_185955_s = new double[256];
private double[] field_185956_t;
private NoiseGeneratorOctaves field_185957_u;
private NoiseGeneratorOctaves field_185958_v;
private NoiseGeneratorOctaves field_185959_w;
/**
 * Determines whether slowsand or gravel can be generated at a location
 */
private NoiseGeneratorOctaves slowsandGravelNoiseGen;
/**
 * Determines whether something other than nettherack can be generated at a location
 */
private NoiseGeneratorOctaves netherrackExculsivityNoiseGen;
private MapGenNetherBridge genNetherBridge = new MapGenNetherBridge();
private MapGenBase genNetherCaves = new MapGenCavesHell();

public ChunkProviderSpeedForce(World worldIn, boolean p_i45637_2_, long seed)
{
	this.world = worldIn;
	this.field_185953_o = p_i45637_2_;
	this.rand = new Random(seed);
	this.field_185957_u = new NoiseGeneratorOctaves(this.rand, 16);
	this.field_185958_v = new NoiseGeneratorOctaves(this.rand, 16);
	this.field_185959_w = new NoiseGeneratorOctaves(this.rand, ;
	this.slowsandGravelNoiseGen = new NoiseGeneratorOctaves(this.rand, 4);
	this.netherrackExculsivityNoiseGen = new NoiseGeneratorOctaves(this.rand, 4);
	this.field_185946_g = new NoiseGeneratorOctaves(this.rand, 10);
	this.field_185947_h = new NoiseGeneratorOctaves(this.rand, 16);
	worldIn.setSeaLevel(0);

	net.minecraftforge.event.terraingen.InitNoiseGensEvent.ContextHell ctx = new net.minecraftforge.event.terraingen.InitNoiseGensEvent.ContextHell(
			field_185957_u, field_185958_v, field_185959_w, slowsandGravelNoiseGen, netherrackExculsivityNoiseGen,
			field_185946_g, field_185947_h);
	ctx = net.minecraftforge.event.terraingen.TerrainGen.getModdedNoiseGenerators(worldIn, this.rand, ctx);
	this.field_185957_u = ctx.getLPerlin1();
	this.field_185958_v = ctx.getLPerlin2();
	this.field_185959_w = ctx.getPerlin();
	this.slowsandGravelNoiseGen = ctx.getPerlin2();
	this.netherrackExculsivityNoiseGen = ctx.getPerlin3();
	this.field_185946_g = ctx.getScale();
	this.field_185947_h = ctx.getDepth();
	this.genNetherBridge = (MapGenNetherBridge) net.minecraftforge.event.terraingen.TerrainGen
			.getModdedMapGen(genNetherBridge,
					net.minecraftforge.event.terraingen.InitMapGenEvent.EventType.NETHER_BRIDGE);
	this.genNetherCaves = net.minecraftforge.event.terraingen.TerrainGen.getModdedMapGen(genNetherCaves,
			net.minecraftforge.event.terraingen.InitMapGenEvent.EventType.NETHER_CAVE);
}

public void func_185936_a(int p_185936_1_, int p_185936_2_, ChunkPrimer p_185936_3_)
{
	int i = 4;
	int j = this.world.getSeaLevel() / 2 + 1;
	int k = i + 1;
	int l = 17;
	int i1 = i + 1;
	this.field_185956_t = this.func_185938_a(this.field_185956_t, p_185936_1_ * i, 0, p_185936_2_ * i, k, l, i1);

	for (int j1 = 0; j1 < i; ++j1)
	{
		for (int k1 = 0; k1 < i; ++k1)
		{
			for (int l1 = 0; l1 < 16; ++l1)
			{
				double d0 = 0.125D;
				double d1 = this.field_185956_t[((j1 + 0) * i1 + k1 + 0) * l + l1 + 0];
				double d2 = this.field_185956_t[((j1 + 0) * i1 + k1 + 1) * l + l1 + 0];
				double d3 = this.field_185956_t[((j1 + 1) * i1 + k1 + 0) * l + l1 + 0];
				double d4 = this.field_185956_t[((j1 + 1) * i1 + k1 + 1) * l + l1 + 0];
				double d5 = (this.field_185956_t[((j1 + 0) * i1 + k1 + 0) * l + l1 + 1] - d1) * d0;
				double d6 = (this.field_185956_t[((j1 + 0) * i1 + k1 + 1) * l + l1 + 1] - d2) * d0;
				double d7 = (this.field_185956_t[((j1 + 1) * i1 + k1 + 0) * l + l1 + 1] - d3) * d0;
				double d8 = (this.field_185956_t[((j1 + 1) * i1 + k1 + 1) * l + l1 + 1] - d4) * d0;

				for (int i2 = 0; i2 < 8; ++i2)
				{
					double d9 = 0.25D;
					double d10 = d1;
					double d11 = d2;
					double d12 = (d3 - d1) * d9;
					double d13 = (d4 - d2) * d9;

					for (int j2 = 0; j2 < 4; ++j2)
					{
						double d14 = 0.25D;
						double d15 = d10;
						double d16 = (d11 - d10) * d14;

						for (int k2 = 0; k2 < 4; ++k2)
						{
							IBlockState iblockstate = null;

							if (l1 * 8 + i2 < j)
							{
								//iblockstate = field_185943_d;
							}

							if (d15 > 0.0D)
							{
								iblockstate = stateSpeedForceOre;
							}

							int l2 = j2 + j1 * 4;
							int i3 = i2 + l1 * 8;
							int j3 = k2 + k1 * 4;
							p_185936_3_.setBlockState(l2, i3, j3, iblockstate);
							d15 += d16;
						}

						d10 += d12;
						d11 += d13;
					}

					d1 += d5;
					d2 += d6;
					d3 += d7;
					d4 += d8;
				}
			}
		}
	}
}

public void func_185937_b(int p_185937_1_, int p_185937_2_, ChunkPrimer p_185937_3_)
{
	if (!net.minecraftforge.event.ForgeEventFactory
			.onReplaceBiomeBlocks(this, p_185937_1_, p_185937_2_, p_185937_3_, this.world))
		return;
	int i = this.world.getSeaLevel() + 1;
	double d0 = 0.03125D;
	this.slowsandNoise = this.slowsandGravelNoiseGen
			.generateNoiseOctaves(this.slowsandNoise, p_185937_1_ * 16, p_185937_2_ * 16, 0, 16, 16, 1, d0, d0,
					1.0D);
	this.gravelNoise = this.slowsandGravelNoiseGen
			.generateNoiseOctaves(this.gravelNoise, p_185937_1_ * 16, 109, p_185937_2_ * 16, 16, 1, 16, d0, 1.0D,
					d0);
	this.field_185955_s = this.netherrackExculsivityNoiseGen
			.generateNoiseOctaves(this.field_185955_s, p_185937_1_ * 16, p_185937_2_ * 16, 0, 16, 16, 1, d0 * 2.0D,
					d0 * 2.0D, d0 * 2.0D);

	for (int j = 0; j < 16; ++j)
	{
		for (int k = 0; k < 16; ++k)
		{
			boolean flag = this.slowsandNoise[j + k * 16] + this.rand.nextDouble() * 0.2D > 0.0D;
			boolean flag1 = this.gravelNoise[j + k * 16] + this.rand.nextDouble() * 0.2D > 0.0D;
			int l = (int) (this.field_185955_s[j + k * 16] / 3.0D + 3.0D + this.rand.nextDouble() * 0.20D);
			int i1 = -1;
			IBlockState iblockstate = stateSpeedForceOre;
			IBlockState iblockstate1 = stateSpeedForceOre;

			for (int j1 = 127; j1 >= 0; --j1)
			{
				if (j1 < 127 - this.rand.nextInt(5) && j1 > this.rand.nextInt(5))
				{
					IBlockState iblockstate2 = p_185937_3_.getBlockState(k, j1, j);

					if (iblockstate2.getBlock() != null && iblockstate2.getMaterial() != Material.air)
					{
						if (iblockstate2.getBlock() == Blocks.netherrack)
						{
							if (i1 == -1)
							{
								if (l <= 0)
								{
									iblockstate = stateAir;
									iblockstate1 = stateSpeedForceOre;
								}
								else if (j1 >= i - 4 && j1 <= i + 1)
								{
									iblockstate = stateSpeedForceOre;
									iblockstate1 = stateSpeedForceOre;

									if (flag1)
									{
										//iblockstate = field_185944_e;
										iblockstate1 = stateSpeedForceOre;
									}

									if (flag)
									{
										//iblockstate = field_185945_f;
										//iblockstate1 = field_185945_f;
									}
								}

								if (j1 < i && (iblockstate == null || iblockstate.getMaterial() == Material.air))
								{
									//iblockstate = field_185943_d;
								}

								i1 = l;

								if (j1 >= i - 1)
								{
									p_185937_3_.setBlockState(k, j1, j, iblockstate);
								}
								else
								{
									p_185937_3_.setBlockState(k, j1, j, iblockstate1);
								}
							}
							else if (i1 > 0)
							{
								--i1;
								p_185937_3_.setBlockState(k, j1, j, iblockstate1);
							}
						}
					}
					else
					{
						i1 = -1;
					}
				}
				else
				{
					p_185937_3_.setBlockState(k, j1, j, stateBedrock);
				}
			}
		}
	}
}

public Chunk provideChunk(int x, int z)
{
	this.rand.setSeed((long) x * 341873128712L + (long) z * 132897987541L);
	ChunkPrimer chunkprimer = new ChunkPrimer();
	this.func_185936_a(x, z, chunkprimer);
	this.func_185937_b(x, z, chunkprimer);
	this.genNetherCaves.generate(this.world, x, z, chunkprimer);

	if (this.field_185953_o)
	{
		this.genNetherBridge.generate(this.world, x, z, chunkprimer);
	}

	Chunk chunk = new Chunk(this.world, chunkprimer, x, z);
	BiomeGenBase[] abiomegenbase = this.world.getBiomeProvider()
			.loadBlockGeneratorData((BiomeGenBase[]) null, x * 16, z * 16, 16, 16);
	byte[] abyte = chunk.getBiomeArray();

	for (int i = 0; i < abyte.length; ++i)
	{
		abyte[i] = (byte) BiomeGenBase.getIdForBiome(abiomegenbase[i]);
	}

	chunk.resetRelightChecks();
	return chunk;
}

private double[] func_185938_a(double[] p_185938_1_, int p_185938_2_, int p_185938_3_, int p_185938_4_,
		int p_185938_5_, int p_185938_6_, int p_185938_7_)
{
	if (p_185938_1_ == null)
	{
		p_185938_1_ = new double[p_185938_5_ * p_185938_6_ * p_185938_7_];
	}

	net.minecraftforge.event.terraingen.ChunkGeneratorEvent.InitNoiseField event = new net.minecraftforge.event.terraingen.ChunkGeneratorEvent.InitNoiseField(
			this, p_185938_1_, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_, p_185938_6_, p_185938_7_);
	net.minecraftforge.common.MinecraftForge.EVENT_BUS.post(event);
	if (event.getResult() == net.minecraftforge.fml.common.eventhandler.Event.Result.DENY)
		return event.getNoisefield();

	double d0 = 684.412D;
	double d1 = 2053.236D;
	this.noiseData4 = this.field_185946_g
			.generateNoiseOctaves(this.noiseData4, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_, 1,
					p_185938_7_, 1.0D, 0.0D, 1.0D);
	this.field_185951_m = this.field_185947_h
			.generateNoiseOctaves(this.field_185951_m, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_, 1,
					p_185938_7_, 100.0D, 0.0D, 100.0D);
	this.field_185948_i = this.field_185959_w
			.generateNoiseOctaves(this.field_185948_i, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_,
					p_185938_6_, p_185938_7_, d0 / 80.0D, d1 / 60.0D, d0 / 80.0D);
	this.field_185949_j = this.field_185957_u
			.generateNoiseOctaves(this.field_185949_j, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_,
					p_185938_6_, p_185938_7_, d0, d1, d0);
	this.field_185950_k = this.field_185958_v
			.generateNoiseOctaves(this.field_185950_k, p_185938_2_, p_185938_3_, p_185938_4_, p_185938_5_,
					p_185938_6_, p_185938_7_, d0, d1, d0);
	int i = 0;
	double[] adouble = new double[p_185938_6_];

	for (int j = 0; j < p_185938_6_; ++j)
	{
		adouble[j] = Math.cos((double) j * Math.PI * 6.0D / (double) p_185938_6_) * 2.0D;
		double d2 = (double) j;

		if (j > p_185938_6_ / 2)
		{
			d2 = (double) (p_185938_6_ - 1 - j);
		}

		if (d2 < 4.0D)
		{
			d2 = 4.0D - d2;
			adouble[j] -= d2 * d2 * d2 * 10.0D;
		}
	}

	for (int l = 0; l < p_185938_5_; ++l)
	{
		for (int i1 = 0; i1 < p_185938_7_; ++i1)
		{
			double d3 = 0.0D;

			for (int k = 0; k < p_185938_6_; ++k)
			{
				double d4 = 0.0D;
				double d5 = adouble[k];
				double d6 = this.field_185949_j[i] / 512.0D;
				double d7 = this.field_185950_k[i] / 512.0D;
				double d8 = (this.field_185948_i[i] / 10.0D + 1.0D) / 2.0D;

				if (d8 < 0.0D)
				{
					d4 = d6;
				}
				else if (d8 > 1.0D)
				{
					d4 = d7;
				}
				else
				{
					d4 = d6 + (d7 - d6) * d8;
				}

				d4 = d4 - d5;

				if (k > p_185938_6_ - 4)
				{
					double d9 = (double) ((float) (k - (p_185938_6_ - 4)) / 3.0F);
					d4 = d4 * (1.0D - d9) + -10.0D * d9;
				}

				if ((double) k < d3)
				{
					double d10 = (d3 - (double) k) / 4.0D;
					d10 = MathHelper.clamp_double(d10, 0.0D, 1.0D);
					d4 = d4 * (1.0D - d10) + -10.0D * d10;
				}

				p_185938_1_[i] = d4;
				++i;
			}
		}
	}

	return p_185938_1_;
}

public void populate(int x, int z)
{
	BlockFalling.fallInstantly = true;
	net.minecraftforge.event.ForgeEventFactory.onChunkPopulate(true, this, this.world, x, z, false);
	BlockPos blockpos = new BlockPos(x * 16, 0, z * 16);
	ChunkCoordIntPair chunkcoordintpair = new ChunkCoordIntPair(x, z);

	net.minecraftforge.event.ForgeEventFactory.onChunkPopulate(false, this, this.world, x, z, false);
	net.minecraftforge.common.MinecraftForge.EVENT_BUS
			.post(new net.minecraftforge.event.terraingen.DecorateBiomeEvent.Pre(this.world, this.rand, blockpos));

	net.minecraftforge.common.MinecraftForge.EVENT_BUS
			.post(new net.minecraftforge.event.terraingen.DecorateBiomeEvent.Post(this.world, this.rand, blockpos));

	BlockFalling.fallInstantly = false;
}

public boolean generateStructures(Chunk chunkIn, int x, int z)
{
	return false;
}

public List<BiomeGenBase.SpawnListEntry> getPossibleCreatures(EnumCreatureType creatureType, BlockPos pos)
{
	if (creatureType == EnumCreatureType.MONSTER)
	{
		if (this.genNetherBridge.func_175795_b(pos))
		{
			return this.genNetherBridge.getSpawnList();
		}

		if (this.genNetherBridge.isPositionInStructure(this.world, pos)
				&& this.world.getBlockState(pos.down()).getBlock() == Blocks.nether_brick)
		{
			return this.genNetherBridge.getSpawnList();
		}
	}

	BiomeGenBase biomegenbase = this.world.getBiomeGenForCoords(pos);
	return biomegenbase.getSpawnableList(creatureType);
}

public BlockPos getStrongholdGen(World worldIn, String structureName, BlockPos position)
{
	return null;
}

public void recreateStructures(Chunk chunkIn, int x, int z)
{
	this.genNetherBridge.generate(this.world, x, z, (ChunkPrimer) null);
}
}

 

WorldProvider:

 

package com.theflash.dimension;

import net.minecraft.entity.Entity;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.DimensionType;
import net.minecraft.world.WorldProvider;
import net.minecraft.world.biome.BiomeProviderSingle;
import net.minecraft.world.border.WorldBorder;
import net.minecraft.world.chunk.Chunk;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class WorldProviderSpeedForce extends WorldProvider
{
/**
 * creates a new world chunk manager for WorldProvider
 */
public void registerWorldChunkManager()
{
	this.worldChunkMgr = new BiomeProviderSingle(BiomeGenSpeedForce.instance);
	this.isHellWorld = true;
	this.hasNoSky = false;
}

/**
 * Return Vec3D with biome specific fog color
 */
@SideOnly(Side.CLIENT) public Vec3d getFogColor(float p_76562_1_, float p_76562_2_)
{
	return new Vec3d(0.6, 0.6, 0.0);
}

@SideOnly(Side.CLIENT) public Vec3d getSkyColor(Entity cameraEntity, float partialTicks)
{
	return new Vec3d(1.0, 1.0, 0.0);
}

public float getCloudHeight()
{
	return 4098.0F;
}

@SideOnly(Side.CLIENT) public float getStarBrightness(float par1)
{
	return 0;
}

public double getMovementFactor()
{
	return 64.0D;
}

public void setWorldTime(long time)
{
	this.worldObj.getWorldInfo().setWorldTime(1000);
}

@SideOnly(Side.CLIENT) public Vec3d getCloudColor(float partialTicks)
{
	return new Vec3d(1, 1, 0.0);
}

public boolean canDoLightning(Chunk chunk)
{
	return true;
}

/**
 * Creates the light to brightness table
 */
protected void generateLightBrightnessTable()
{
	float f = 0.1F;

	for (int i = 0; i <= 15; ++i)
	{
		float f1 = 1.0F - (float) i / 15.0F;
		this.lightBrightnessTable[i] = (1.0F - f1) / (f1 * 3.0F + 1.0F) * (1.0F - f) + f;
	}
}

public IChunkGenerator createChunkGenerator()
{
	return new ChunkProviderSpeedForce(this.worldObj, this.worldObj.getWorldInfo().isMapFeaturesEnabled(),
			this.worldObj.getSeed());
}

/**
 * Returns 'true' if in the "main surface world", but 'false' if in the Nether or End dimensions.
 */
public boolean isSurfaceWorld()
{
	return true;
}

/**
 * Will check if the x, z position specified is alright to be set as the map spawn point
 */
public boolean canCoordinateBeSpawn(int x, int z)
{
	return false;
}

/**
 * Calculates the angle of sun and moon in the sky relative to a specified time (usually worldTime)
 */
public float calculateCelestialAngle(long worldTime, float partialTicks)
{
	return 0.5F;
}

/**
 * True if the player can respawn in this dimension (true = overworld, false = nether).
 */
public boolean canRespawnHere()
{
	return false;
}

/**
 * Returns true if the given X,Z coordinate should show environmental fog.
 */
@SideOnly(Side.CLIENT) public boolean doesXZShowFog(int x, int z)
{
	return true;
}

public WorldBorder getWorldBorder()
{
	return new WorldBorder()
	{
		public double getCenterX()
		{
			return super.getCenterX() / 8.0D;
		}

		public double getCenterZ()
		{
			return super.getCenterZ() / 8.0D;
		}
	};
}

public DimensionType getDimensionType()
{
	return DimensionType.getById(2);
}

public String getWelcomeMessage()
{
	return "Entering The Speed Force";
}

public String getDepartMessage()
{
	return "Exiting The Speed Force";
}
}

 

BiomeGen (not really necessary I think, but I'll throw it in here anyways)

 

package com.theflash.dimension;

import net.minecraft.world.biome.BiomeGenBase;

public class BiomeGenSpeedForce extends BiomeGenBase
{
public static BiomeGenSpeedForce instance = new BiomeGenSpeedForce(
		(new BiomeGenBase.BiomeProperties("The Speed Force")));

public BiomeGenSpeedForce(BiomeGenBase.BiomeProperties properties)
{
	super(properties);
	this.spawnableCaveCreatureList.clear();
	this.spawnableCreatureList.clear();
	this.spawnableMonsterList.clear();
	this.spawnableWaterCreatureList.clear();
}
}

 

Thanks!

  • 1 month later...
Posted

If the fog isn't necessarly you can try removing all the fog related methods in the World Provider :) Also could you tell me how you registered the dimension? :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

If the fog isn't necessarly you can try removing all the fog related methods in the World Provider :) Also could you tell me how you registered the dimension? :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.