Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.9][SOLVED] Why registering models only in pre init?


Elix_x
 Share

Recommended Posts

Good day everybody.

I stumbled upon a problem today: why must we register models in pre init?

Due to how my code works, i cannot register them in pre init. And if i register them in init, they don't work.

I have a structure of dynamicaly generated items, depending on configuration and installed mods (including ones that use API to add different types of tool). Any mod can provide tool provider in pre-init and materials are loaded from jsons. Then in init, item for each tool for each material is generated and registered. (Up to this point, everything works). But when i try to register models in init, they don't work. If i move all item registries, and models in pre init, they work... But then nobody can use API, because it is setup and used entirely in pre init.

 

So, why registering item models in init does not work? And what should i do?

 

Note: while i can move materials from item instance to NBT, i cannot move tool types to NBT, as each tool may have different possible usage, thus different classes are needed.

 

Thanks for help!

If you have any questions - just ask!

Link to comment
Share on other sites

I have something similar to this mostly working but the process is somewhat convoluted.

You can look at my code here.

 

You can see most of it in common/draftcore/..., helpers/..., api/

I can try to come up with a path for you to follow to help you understand what is going on.

 

Edit:

this is more or less the path you can follow for looking through the code:

 

*helpers/CommonProxy #preInit, #registerLuxin, #registerCores, #registerParts, #registerItems

They lead to my registries in the API for other mods to use,

a good practice is to use your own api's to accomplish create things.

If something can't be done with your api then expand it so it can be done.

*helpers/ClientProxy #init, you can see me registering my models here

*client/itemrenderers/DraftableModelLoader you will want to use something like this

*client/itemrenderers/DraftableModel yours should be similar to this

*client/itemrenderers/DraftableBakedModel #Quads yours you should be able to almost copy from the default one

*client/itemrenderers/DraftableOverrideList #handleItemState is where you can parse nbt info

 

Current Project: Armerger 

Planned mods: Light Drafter  | Ore Swords

Looking for help getting a mod off the ground? Coding  | Textures

Link to comment
Share on other sites

I have something similar to this mostly working but the process is somewhat convoluted.

You can look at my code here.

 

You can see most of it in common/draftcore/..., helpers/..., api/

I can try to come up with a path for you to follow to help you understand what is going on.

 

Edit:

this is more or less the path you can follow for looking through the code:

 

*helpers/CommonProxy #preInit, #registerLuxin, #registerCores, #registerParts, #registerItems

They lead to my registries in the API for other mods to use,

a good practice is to use your own api's to accomplish create things.

If something can't be done with your api then expand it so it can be done.

*helpers/ClientProxy #init, you can see me registering my models here

*client/itemrenderers/DraftableModelLoader you will want to use something like this

*client/itemrenderers/DraftableModel yours should be similar to this

*client/itemrenderers/DraftableBakedModel #Quads yours you should be able to almost copy from the default one

*client/itemrenderers/DraftableOverrideList #handleItemState is where you can parse nbt info

Thanks, i'll take a look at that.

 

One thing though: my models are in jsons (because vanilla is enough).

Link to comment
Share on other sites

I will just say that adding

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, def);

fixed everything (before i was using only

ModelLoader.setCustomModelResourceLocation(item, 0, def);

).

Now models work in init correctly.

Thanks anyways!

Link to comment
Share on other sites

You should not need

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, def)

. What is your code for

ModelLoader.setCustomModelResourceLocation(item, 0, def)

?

	public void init(FMLInitializationEvent event){
	MinecraftForge.EVENT_BUS.register(new LastRenderWorldEvent());

	for(ColoringToolProvider provider : ColoringToolsManager.getProviders()){
		ModelResourceLocation def = provider.getDefaultModel();
		if(def != null){
			for(Item item : (Collection<Item>) ColoringToolsManager.getAllItems(provider)){
				ModelLoader.setCustomModelResourceLocation(item, 0, def);
				Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, def);
				Minecraft.getMinecraft().getItemColors().registerItemColorHandler(new StandartColoringToolItemColor(0, 1), item);
			}
		}
	}
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Here is my configuration: % java -version java version "18.0.2" 2022-07-19 Java(TM) SE Runtime Environment (build 18.0.2+9-61) Java HotSpot(TM) 64-Bit Server VM (build 18.0.2+9-61, mixed mode, sharing) forge-1.19-41.1.0-mdk on macOS Monterey 12.5 I ran the command: ./gradlew genEclipseRuns and was hoping it will generate the Eclipse project files for me. The run log is at https://gist.github.com/arun-gupta/06b983a6976b4c0a0f510d0dc225ddd3 and the generated directory structure is at https://gist.github.com/arun-gupta/3f5bfc70ec5d3d903b0f97d42840abda. In previous versions (1.12-ish), it used to generate an eclipse directory but 1.19 does not seem to have it. I tried opening the top-level forge directory but Eclipse does not recognize it as a project as well. How do I open this project in Eclipse now?  
    • I didn't put in credentials, I used it only for testing installing forge. But still the problem mentioned above.
    • I am trying to use Forge 1.18.2, I have checked my firewall, redownloaded Forge, deleted the fml.toml file (which keeps reappearing) and looked at countless help pages. I am just trying to download and use forge so that I can play with my friends and it will not download. It tells me there may be an issue with the Java runtime config and that the exit code is one, and I have copied the exit code.   
    • Okay, i think i understand but im getting issues, i create another packet to sync entity to another players like this package com.naim.belloto.networking.packet; import com.naim.belloto.networking.handler.ClientSyncHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.FriendlyByteBuf; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.fml.DistExecutor; import net.minecraftforge.network.NetworkEvent; import java.util.Objects; import java.util.function.Supplier; public class ClientSyncPacket { public ClientSyncPacket() { } public ClientSyncPacket(FriendlyByteBuf buf) { } public void toBytes(FriendlyByteBuf buf) { } public boolean handle(Supplier<NetworkEvent.Context> ctx) { NetworkEvent.Context context = ctx.get(); context.enqueueWork(() -> { assert Minecraft.getInstance().player != null; int idplayer = Minecraft.getInstance().player.getId(); DistExecutor.unsafeCallWhenOn(Dist.CLIENT,() -> () -> ClientSyncHandler.handlePacket(ctx, idplayer)); }); return true; } } And in the handler: public class ClientSyncHandler { public static boolean handlePacket(Supplier<NetworkEvent.Context> ctx, int idPlayer) { Minecraft.getInstance().level.getEntity(idPlayer); return true; } } But is not working :// 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.