Jump to content

[1.8.9] Get villager trade the player is looking at


Aulig

Recommended Posts

Hello,

 

after a conversation with diesieben07 (http://www.minecraftforge.net/forum/index.php/topic,39068.0.html) we noticed that its kind of difficult to get the current villager trade. I want it to work even if the player hasnt put in any items, so ContainerMerchant#getMerchantInventory().getCurrentRecipe() wont work. Maybe its possible to use the MerchantRecipeList or InventoryMerchant#currentRecipeIndex.

 

It just crossed my mind that maybe the GuiMerchant class holds useful information.

Slightly modified code:

//The integer value corresponding to the currently selected merchant recipe.
private int selectedMerchantRecipe;
MerchantRecipe merchantrecipe = (MerchantRecipe)merchantrecipelist.get(selectedMerchantRecipe);

Could this be used?

Link to comment
Share on other sites

Hello,

 

after a conversation with diesieben07 (http://www.minecraftforge.net/forum/index.php/topic,39068.0.html) we noticed that its kind of difficult to get the current villager trade. I want it to work even if the player hasnt put in any items, so ContainerMerchant#getMerchantInventory().getCurrentRecipe() wont work. Maybe its possible to use the MerchantRecipeList or InventoryMerchant#currentRecipeIndex.

 

It just crossed my mind that maybe the GuiMerchant class holds useful information.

Slightly modified code:

//The integer value corresponding to the currently selected merchant recipe.
private int selectedMerchantRecipe;
MerchantRecipe merchantrecipe = (MerchantRecipe)merchantrecipelist.get(selectedMerchantRecipe);

Could this be used?

Link to comment
Share on other sites

I am just going to give you a warning that I'm a complete beginner when it comes to modding but I've dug into minecraft code a lot and I did find kind of a hacky solution that I was hoping you could test. Here's the code and I'll explain below:



import org.lwjgl.input.Keyboard;
import org.lwjgl.input.Mouse;

import net.minecraft.entity.passive.EntityVillager;
import net.minecraftforge.client.event.GuiScreenEvent.ActionPerformedEvent;
import net.minecraftforge.client.event.GuiScreenEvent.KeyboardInputEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent.EntityInteract;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


public class TestClass {
public static boolean guiOpened;
public static int selectedMerchantRecipe;
private int totalRecipes;
@SubscribeEvent
public void getEvent(EntityInteract e)
{
	if(e != null && e.getTarget() instanceof EntityVillager)
	{
		EntityVillager interactedWith = (EntityVillager)e.getTarget();
		totalRecipes = interactedWith.getRecipes(e.getEntityPlayer()).size();
		guiOpened = true; //We know that the gui is open because the player interacted with a villager
                        System.out.println("Merchant GUI Opened!" );
	}
}
@SubscribeEvent
public void buttonClicked(ActionPerformedEvent.Pre e)
{
	final int nextButtonID = 1; //Button IDs from GuiMerchant class
	final int prevButtonID = 2;
	if(guiOpened)
	{
	    if(e.getButton() != null && e.getButton().id == nextButtonID)
	    {
	    	++selectedMerchantRecipe;
	    	if(selectedMerchantRecipe >= totalRecipes)
		    	selectedMerchantRecipe = totalRecipes - 1;
	    	 System.out.println(selectedMerchantRecipe);
	    }
	    else if(e.getButton() != null && e.getButton().id == prevButtonID)
	    {
	    	--selectedMerchantRecipe;
	    	if(selectedMerchantRecipe < 0)
		    	selectedMerchantRecipe = 0;
	    	 System.out.println(selectedMerchantRecipe);
	   	} 			    			    
	}	
}
@SubscribeEvent
public void keyboardButtonPushed(KeyboardInputEvent.Pre e)
{
	if(Keyboard.getEventKey() == 1 && guiOpened) //if escape is pushed
		guiOpened = false;
}
}

Basically what I did was that I hooked up into three events EntityInteract, ActionPeformedEvent.Pre and KeyboardInputEvent.Pre. When the EntityInteract event fires with a villager, we know for sure that the gui is now open for the player. ActionPerformedEvent and KeyboardInputEvent are generic GUI events that fire whenever a mouse or a keyboard is used in a GUI. Combine that with the guiOpened boolean variable and restricting the mouse event to buttons only, you get yourself a simulated GuiMerchant class with a selectedMerchentRecipe variable. If you're going to use this class, don't forget to do MinecraftForge.EVENT_BUS.register(new TestClass()); in your init method.

Link to comment
Share on other sites

I am just going to give you a warning that I'm a complete beginner when it comes to modding but I've dug into minecraft code a lot and I did find kind of a hacky solution that I was hoping you could test. Here's the code and I'll explain below:



import org.lwjgl.input.Keyboard;
import org.lwjgl.input.Mouse;

import net.minecraft.entity.passive.EntityVillager;
import net.minecraftforge.client.event.GuiScreenEvent.ActionPerformedEvent;
import net.minecraftforge.client.event.GuiScreenEvent.KeyboardInputEvent;
import net.minecraftforge.event.entity.player.PlayerInteractEvent.EntityInteract;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;


public class TestClass {
public static boolean guiOpened;
public static int selectedMerchantRecipe;
private int totalRecipes;
@SubscribeEvent
public void getEvent(EntityInteract e)
{
	if(e != null && e.getTarget() instanceof EntityVillager)
	{
		EntityVillager interactedWith = (EntityVillager)e.getTarget();
		totalRecipes = interactedWith.getRecipes(e.getEntityPlayer()).size();
		guiOpened = true; //We know that the gui is open because the player interacted with a villager
                        System.out.println("Merchant GUI Opened!" );
	}
}
@SubscribeEvent
public void buttonClicked(ActionPerformedEvent.Pre e)
{
	final int nextButtonID = 1; //Button IDs from GuiMerchant class
	final int prevButtonID = 2;
	if(guiOpened)
	{
	    if(e.getButton() != null && e.getButton().id == nextButtonID)
	    {
	    	++selectedMerchantRecipe;
	    	if(selectedMerchantRecipe >= totalRecipes)
		    	selectedMerchantRecipe = totalRecipes - 1;
	    	 System.out.println(selectedMerchantRecipe);
	    }
	    else if(e.getButton() != null && e.getButton().id == prevButtonID)
	    {
	    	--selectedMerchantRecipe;
	    	if(selectedMerchantRecipe < 0)
		    	selectedMerchantRecipe = 0;
	    	 System.out.println(selectedMerchantRecipe);
	   	} 			    			    
	}	
}
@SubscribeEvent
public void keyboardButtonPushed(KeyboardInputEvent.Pre e)
{
	if(Keyboard.getEventKey() == 1 && guiOpened) //if escape is pushed
		guiOpened = false;
}
}

Basically what I did was that I hooked up into three events EntityInteract, ActionPeformedEvent.Pre and KeyboardInputEvent.Pre. When the EntityInteract event fires with a villager, we know for sure that the gui is now open for the player. ActionPerformedEvent and KeyboardInputEvent are generic GUI events that fire whenever a mouse or a keyboard is used in a GUI. Combine that with the guiOpened boolean variable and restricting the mouse event to buttons only, you get yourself a simulated GuiMerchant class with a selectedMerchentRecipe variable. If you're going to use this class, don't forget to do MinecraftForge.EVENT_BUS.register(new TestClass()); in your init method.

Link to comment
Share on other sites

Thanks a ton! Your code is great except for a few minor issues, eg it isnt e.getButton() but e.button. Also the detection if the gui was closed didnt work so i replaced it with a few if clauses and Keyboard.isKeyDown(18) and Keyboard.isKeyDown(1). (18 is "e" and 1  is escape)

Wasnt that big of a deal though, just wanted to let you know in case it helps you.

Link to comment
Share on other sites

Thanks a ton! Your code is great except for a few minor issues, eg it isnt e.getButton() but e.button. Also the detection if the gui was closed didnt work so i replaced it with a few if clauses and Keyboard.isKeyDown(18) and Keyboard.isKeyDown(1). (18 is "e" and 1  is escape)

Wasnt that big of a deal though, just wanted to let you know in case it helps you.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.