[1.10] RemoveItem not working correctly

[Egietje]

I have a removeItem() method that if it is called it will remove as much from the item you're holding as the stacks of that item you have in your inventory

Here's my code:

public void removeItem(EntityPlayer playerIn, ItemStack removeitem) {
	IInventory inv = playerIn.inventory;
	for (int i = 0; i < inv.getSizeInventory(); i++) {
		if (inv.getStackInSlot(i) != null) {
			ItemStack j = inv.getStackInSlot(i);
			if (j.getItem() != null && j.getItem() == removeitem.getItem()) {
				inv.decrStackSize(playerIn.inventory.currentItem, 1);
			}
		}
	}
}

[Egietje]

So.. how would I do that?

[Egietje]

Yes, i know what it is, but what parameters do i need to put in?

[Egietje]

I don't want the slot to be empty, i want to remove 1 item from it

[Egietje]

I want that if you right-click the block with a specific item, it takes 1 from the itemstack you're holding

[Egietje]

I had that before, but it takes away as many items as the stacks you have, for example: I have 3 stacks of dirt, right-click the machine and it will take away 3 dirt from the stack I'm holding

[Egietje]

It IS

[Egietje]

On my phone now, can't provide any code

[Ernio]

I think I remember your piece of code and it was something like:

for (index : all)
{
    player.inventory.decrStackSize(index, 1);
}

 

Learn what loop is, you are not supposed to loop through inventory. (because then indeed you will remove 1 from each stack).

 

Just call: (current item is item held)

player.inventory.decrStackSize(player.inventory.currentItem, 1);

[Egietje]

Look at the code at the top, I had that but it didn't work correctly

[Egietje]

So, I need to remove the for-loop?

[Egietje]

Only the for-loop?

[Egietje]

And, what do I need to put in instead of i?

[Egietje]

Thanks!