Jump to content
Currently supported: All versions

[CustomNPCs 1.8.9] How do I get the players held item?

TheDominatedPancake

By TheDominatedPancake
in Noppes' Mods

 Share

Recommended Posts

TheDominatedPancake Tree Puncher

TheDominatedPancake

Posted
Posted

Hi, I'm having trouble with the scripted door in the Custom NPCs mod. I can't figure out how to get the player's held item. I saw on a 1.8 Custom NPCs tutorial video that I had to type player.getHeldItem() but that isn't working. I'm using 1.8.9 and all the resources I've found do not help at all. I would love some help on this.  :-\

 

Also this comes up when I do type player.getHeldItem()

 

Sat Jul 02 23:13:44 BST 2016 tab 1:

javax.script.ScriptException: TypeError: Cannot read property "getHeldItem" from undefined in <eval> at line number 2

at jdk.nashorn.api.scripting.NashornScriptEngine.throwAsScriptException(NashornScriptEngine.java:467)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:389)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeFunction(NashornScriptEngine.java:190)

at noppes.npcs.controllers.ScriptContainer.run(ScriptContainer.java:100)

at noppes.npcs.blocks.tiles.TileScriptedDoor.runScript(TileScriptedDoor.java:91)

at noppes.npcs.EventHooks.onScriptBlockInteract(EventHooks.java:164)

at noppes.npcs.blocks.BlockScriptedDoor.func_180639_a(BlockScriptedDoor.java:52)

at net.minecraft.server.management.ItemInWorldManager.func_180236_a(ItemInWorldManager.java:427)

at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:588)

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:59)

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:10)

at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)

at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)

at java.util.concurrent.FutureTask.run(Unknown Source)

at net.minecraft.util.Util.func_181617_a(SourceFile:44)

at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:660)

at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:605)

at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:251)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:481)

at java.lang.Thread.run(Unknown Source)

Caused by: <eval>:2 TypeError: Cannot read property "getHeldItem" from undefined

at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)

at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:213)

at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:185)

at jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:172)

at jdk.nashorn.internal.runtime.Undefined.get(Undefined.java:157)

at jdk.nashorn.internal.scripts.Script$Recompilation$62$57AAAAAA$\^eval\_.interact(<eval>:2)

at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:655)

at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)

at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)

at jdk.nashorn.api.scripting.ScriptObjectMirror.callMember(ScriptObjectMirror.java:199)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:383)

... 18 more

Sat Jul 02 23:13:19 BST 2016 tab 1:

javax.script.ScriptException: ReferenceError: "players" is not defined in <eval> at line number 2

at jdk.nashorn.api.scripting.NashornScriptEngine.throwAsScriptException(NashornScriptEngine.java:467)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:389)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeFunction(NashornScriptEngine.java:190)

at noppes.npcs.controllers.ScriptContainer.run(ScriptContainer.java:100)

at noppes.npcs.blocks.tiles.TileScriptedDoor.runScript(TileScriptedDoor.java:91)

at noppes.npcs.EventHooks.onScriptBlockInteract(EventHooks.java:164)

at noppes.npcs.blocks.BlockScriptedDoor.func_180639_a(BlockScriptedDoor.java:52)

at net.minecraft.server.management.ItemInWorldManager.func_180236_a(ItemInWorldManager.java:427)

at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:588)

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:59)

at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(SourceFile:10)

at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)

at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)

at java.util.concurrent.FutureTask.run(Unknown Source)

at net.minecraft.util.Util.func_181617_a(SourceFile:44)

at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:660)

at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:605)

at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:251)

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:481)

at java.lang.Thread.run(Unknown Source)

Caused by: <eval>:2 ReferenceError: "players" is not defined

at jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)

at jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)

at jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)

at jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1428)

at jdk.nashorn.internal.scripts.Script$Recompilation$59$57AAAAAA$\^eval\_.interact(<eval>:2)

at jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:635)

at jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)

at jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)

at jdk.nashorn.api.scripting.ScriptObjectMirror.callMember(ScriptObjectMirror.java:199)

at jdk.nashorn.api.scripting.NashornScriptEngine.invokeImpl(NashornScriptEngine.java:383)

... 18 more

 

 

 

And this is the script I'm using

 

function interact(block, player, side, hitX, hitY, hitZ) {

var item = player.getHeldItem();

 

if (item == null || item.getItemName() != "customnpcs:npcKey") {

block.event.setCancelled(true);

}

}

 

  • 3 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      "The game crashed: rendering overlayError: java.lang.NullPointerException: Rendering overlay -1 "

      By TileEntity · Posted

      Add the crash-report or latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
    • TileEntity
      Modded Minecraft 1.20.1 Crash ("Player" is null error)

      By TileEntity · Posted

      Make a test without stevescarts
    • TileEntity
      Game freezes when certain chunks are loaded on modded world

      By TileEntity · Posted

      Hmm I have no idea
    • Whisperwind
      Server crash when launched

      By Whisperwind · Posted

      So i have a forge modded aternos server that worked just fine for a month untill today it suddenly crashes most of the time giving errors and idk which mod is causing the error or its smth else here is the crash log link https://mclo.gs/gGkzGKT
    • GreyM7
      Modded Minecraft 1.20.1 Crash ("Player" is null error)

      By GreyM7 · Posted

      Struggling to decipher a crash report I'm getting in a custom modpack I'm tinkering with. The crash happens on startup, but weirdly, only some of the time. It seems to be related to Steves Carts, but weirdly it only started happening recently, and I can't identify if another mod is conflicting, or why it is only happening some of the time:   java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.player.Player.m_20202_()" because "player" is null at vswe.stevescarts.events.OverlayEventHandler.onRenderTick(OverlayEventHandler.java:24) ~[stevescarts-1.20.1-1.1.14.jar%23527!/:1.20.1-1.1.14] {re:classloading} at net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%23127!/:?] {} at net.minecraftforge.event.ForgeEventFactory.onRenderTickEnd(ForgeEventFactory.java:919) ~[forge-1.20.1-47.1.106-universal.jar%23581!/:?] {re:mixin,re:classloading,pl:mixin:APP:modernfix-forge.mixins.json:perf.potential_spawns_alloc.ForgeEventFactoryMixin,pl:mixin:A} at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1148) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23576!/:?] {re:mixin,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick,xf:fml:xaeroworldmap:xaero_wm_minecraft_runtick_render_call,xf:fml:xaerominimap:xaero_minecraftclient,xf:fml:xaeroworldmap:xaero_wm_minecraftclient,pl:mixin:A,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:218) ~[minecraft-1.20.1-client.jar:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:flywheel.mixins.json:ClientMainMixin,pl:mixin:A,pl:runtimedistcleaner:A}     Including some extra info in case any of it is relevant^. Appreciate any ideas/advice!    

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept