Jump to content

Other mods modifying stackSize directly screws up my mod


copygirl

Recommended Posts

Hey everyone,

 

I'm having a problem with my mod BetterStorage and the Storage Crates they add. Their inventory is dynamic and the internal inventory can't be directly accessed or modified. Instead there is a "block view" and "player view", which is for machines accessing the crates and players opening them, respectively.

 

Now it seems like many mods, if not most/all of them change the stackSize directly if they want to add items in a slot, whereas they should use setInventorySlotContents. ItemStack should be treated as immutable unless it's only used internally.

 

So yeah ... I'm not sure how I should about doing this. Writing a complicated system to add support for "wrong" code in other mods, or somehow getting all the modders to fix this issue which only affects my crates?

 

Any input would be nice, though I'm doing this mainly to get some more attention on this issue.

 

Thanks!

Link to comment
Share on other sites

Personally, I always try to stay universally compatible whenever possible, but if this is not possible with the system you are using, try sending the mod author a message when you narrow down their problem. Typically giving them and equally easy method that would still work for them usually is all it takes.

I also have also used setInventorySlotContents to set the stack in an inventory slot, so all necessary systems are triggered when I change the inventory, so it would be a good idea for those mods to start doing this also.

 

As far as the complicated code to watch for, I suppose this would take a duplicate map? I don't think Itemstacks are .equals compatible, so it might be a bit of a chore, but it would be possible to check this on a scheduled tick.

Link to comment
Share on other sites

I'm now wondering if this is the reason my chests don't seem to work correctly with automation.

I've been looking things over but just couldn't seem to find the problem.

 

Is your issue the same as mine?

 

The tile entity of each chest is storing its own items,

Breaking a chest drops all of the items stored in the tile entity.

GUI shows inventory of all joined chests.

Player can shift click items in and out of any slot, extra items will spill over into the next joined inventory.

 

But when connected to BuildCraft pipes only the tile entity the pipe connects to is ever accessed.

Link to comment
Share on other sites

  • 2 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm using Modrinth as a launcher for a forge modpack on 1.20.1, and can't diagnose the issue on the crash log myself. Have tried repairing the Minecraft instillation as well as removing a few mods that have been problematic for me in the past to no avail. Crash log is below, if any further information is necessary let me know. Thank you! https://paste.ee/p/k6xnS
    • Hey folks. I am working on a custom "Mecha" entity (extended from LivingEntity) that the player builds up from blocks that should get modular stats depending on the used blocks. e.g. depending on what will be used for the legs, the entity will have a different jump strength. However, something unexpected is happening when trying to override a few of LivingEntity's functions and using my new own "Mecha" specific fields: instead of their actual instance-specific value, the default value is used (0f for a float, null for an object...) This is especially strange as when executing with the same entity from a point in the code specific to the mecha entity, the correct value is used. Here are some code snippets to better illustrate what I mean: /* The main Mecha class, cut down for brevity */ public class Mecha extends LivingEntity { protected float jumpMultiplier; //somewhere later during the code when spawning the entity, jumpMultiplier is set to something like 1.5f //changing the access to public didn't help @Override //Overridden from LivingEntity, this function is only used in the jumpFromGround() function, used in the aiStep() function, used in the LivingEntity tick() function protected float getJumpPower() { //something is wrong with this function //for some reason I can't correctly access the fields and methods from the instanciated entity when I am in one of those overridden protected functions. this is very annoying LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 0f return this.jumpMultiplier * super.getJumpPower(); } //The code above does not operate properly. Written as is, the entity will not jump, and adding debug logs shows that when executing the code, the value of this.jumpMultiplier is 0f //in contrast, it will be the correct value when done here: @Override public void tick() { super.tick(); //inherited LivingEntity logic //Custom logic LogUtils.getLogger().info(String.valueOf(this.jumpMultiplier))) //will print 1.5f } } My actual code is slightly different, as the jumpMuliplier is stored in another object (so I am calling "this.legModule.getJumpPower()" instead of the float), but even using a simple float exactly like in the code above didn't help. When running my usual code, the object I try to use is found to be null instead, leading to a crash from a nullPointerException. Here is the stacktrace of said crash: The full code can be viewed here. I have found a workaround in the case of jump strength, but have already found the same problem for another parameter I want to do, and I do not understand why the code is behaving as such, and I would very much like to be able to override those methods as intended - they seemed to work just fine like that for vanilla mobs... Any clues as to what may be happening here?
    • Please delete post. Had not noticed the newest edition for 1.20.6 which resolves the issue.
    • https://paste.ee/p/GTgAV Here's my debug log, I'm on 1.18.2 with forge 40.2.4 and I just want to get it to work!! I cant find any mod names in the error part and I would like some help from the pros!! I have 203 mods at the moment.
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.