Jump to content

[1.8.9][SOLVED] Fluid Model Rendering


Mark136

Recommended Posts

Hello all  :D

I'm writing an RPG mod. but i'm stuck at the part with creating custom fluids.

there aren't much tutorials for custom fluids. but i have found and followed that one from Choonster.

 

the problem is that the code ignores my modelResource location and uses the path that i filled in here:

block.setRegistryName("fluid." + block.getFluid().getName())

 

instead of:

private void registerFluidModels() {
	ModFluids.modFluidBlocks.forEach(this::registerFluidModel);
}

private void registerFluidModel(IFluidBlock fluidBlock) {
	Item item = Item.getItemFromBlock((Block) fluidBlock);

	ModelBakery.registerItemVariants(item);

	ModelResourceLocation MRL = new ModelResourceLocation(modid + ":fluid", fluidBlock.getFluid().getName());

System.out.println("modelResourceLocation is : " + MRL.toString());

	ModelLoader.setCustomMeshDefinition(item, MeshDefinitionFix.create(stack -> MRL));

	ModelLoader.setCustomStateMapper((Block) fluidBlock, new StateMapperBase() {
		@Override
		protected ModelResourceLocation getModelResourceLocation(IBlockState state) {
			return MRL;
		}
	});
}

 

he gives a FileNotFoundExeption with the location : mark13695:blockstates/fluid.bluelava with as variant #level=(Number 1 to 15) metadata from BlockFluidBase.

 

ModelResourceLocation MRL must be right as in the console: modelResourceLocation is : mark13695:fluid#bluelava

 

 

here is my fluidinit class:

package com.modMark.Fluids;

import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
import java.util.function.Consumer;
import java.util.function.Function;

import com.modMark.Main.MainRegistry;

import net.minecraft.block.Block;
import net.minecraft.block.material.MapColor;
import net.minecraft.block.material.Material;
import net.minecraft.block.material.MaterialLiquid;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidRegistry;
import net.minecraftforge.fluids.IFluidBlock;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class MarkFluids {



public static Fluid BlueLava;

public static final Set<Fluid> fluids = new HashSet<>();
public static Set<IFluidBlock> fluidBlocks = new HashSet<IFluidBlock>();


public static void init() {

	BlueLava = createFluid("bluelava", "mark13695:blocks/LavaBlue", Material.lava,
		fluid -> fluid.setViscosity(5500).setDensity(1100).setLuminosity(15),
		fluid -> new BlockMarkLiquid("LavaBlue", fluid, Material.lava));




}

private static <T extends Block & IFluidBlock> Fluid createFluid(String name, String textureName, Material material, Consumer<Fluid> fluidPropertyApplier, Function<Fluid, T> blockFactory) {
	return createFluid(name, textureName, material, 0x0F44E4 , fluidPropertyApplier, blockFactory);
}


private static <T extends Block & IFluidBlock> Fluid createFluid(String name, String textureName, Material material, int color, Consumer<Fluid> fluidPropertyApplier, Function<Fluid, T> blockFactory) {

	if(material == Material.lava){

	Fluid fluid = new MarkLava(name, textureName + "_still", textureName + "_flowing");
	boolean useOwnFluid = FluidRegistry.registerFluid(fluid);

	if (useOwnFluid) {
		fluidPropertyApplier.accept(fluid);
		registerFluidBlock(blockFactory.apply(fluid));
	} else {
		fluid = FluidRegistry.getFluid(name);
	}
	fluids.add(fluid);

	return fluid;
	}
	else{ 

	Fluid fluid = new MarkWater(name, textureName + "_still", textureName + "_flowing", color);
	boolean useOwnFluid = FluidRegistry.registerFluid(fluid);

	if (useOwnFluid) {
		fluidPropertyApplier.accept(fluid);
		registerFluidBlock(blockFactory.apply(fluid));
	} else {
		fluid = FluidRegistry.getFluid(name);
	}
	fluids.add(fluid);

	return fluid;

	}


}


private static <T extends Block & IFluidBlock> T registerFluidBlock(T block) {


	block.setRegistryName("fluid." + block.getFluid().getName());
	GameRegistry.registerBlock(block);

	fluidBlocks.add(block);

	return block;
}


}

 

anyone who knows what i did wrong?

 

sorry for copypasting most of his fluid code, I could'nt make it better that this :(

my Mod: Extended RPG [W.I.P]

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • im stuck in a problem whit BlockEntities i cannot solve so im trying to work around it but in the less complex way possible  i think is posible to store data to the minecraft world  in older versions people talk about  WordDataSave i dont find anything about it for 1.20.4  i find a tutorial for player capability in 1.19    here is an event      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesPlayer(AttachCapabilitiesEvent<Entity> event) {         if(event.getObject() instanceof Player) {             if(!event.getObject().getCapability(PlayerThirstProvider.PLAYER_THIRST).isPresent()) {                 event.addCapability(new ResourceLocation(mercmod.MOD_ID, "properties"), new PlayerThirstProvider());             }         }     }  soo i made this      //########## ########## ########## ##########     @SubscribeEvent     public static void onAttachCapabilitiesLevel(AttachCapabilitiesEvent<Level> event) {     } i think i can do some witchcraft  here  but is many things don't understand  to start whit i dont get yet how to recall the saved data from a BlockEntity  the handler still in progress the plan is to make a Map to store nbt data using the block coordinates as index later store that map as a big nbt      ########## any way the question is if theres alredy a tutorial for 1.20.4 for this ?? or some alredy working code from someone else doing something similar ?           
    • I tried this, and found out that Oculus is the mod that is crashing the game. I have removed it, and it now works fine! Thanks!
    • Hi @DanielderErbauer, I arrived here as I have the "as it does not exist in Block{minecraft:air}" error in a modpack I am trying to start. It's a long-shot, I know, but as the post that led this to being solved is missing, can I ask if you may recall what it said? Thanks in advance
    • Hm yeah sorry, not seeing anything else that's sticking out, I'd need to debug myself probably. Do you have a github or bitbucket repo? I could poke around when I have time to see what the problem might be.
    • looking around for the capabilities thing i found a piece of code and find this piece of code  //########## ########## ########## ########## @SubscribeEvent public static void addCustomTrades(VillagerTradesEvent event) { if(event.getType() == VillagerProfession.FLETCHER) { System.out.println("\n\n### VillagerProfession.FLETCHER \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.ARROW_STEEL.get(), 16); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,1,3,0.02F)); } if(event.getType() == VillagerProfession.TOOLSMITH) { System.out.println("\n\n### VillagerProfession.TOOLSMITH \n\n");//<----------- Int2ObjectMap<List<VillagerTrades.ItemListing>> trades = event.getTrades(); ItemStack stack = new ItemStack(ItemInit.INGOT_STEEL.get(), 1); int villagerLevel = 1; trades.get(villagerLevel).add((trader, rand) -> new MerchantOffer( new ItemStack(Items.EMERALD, 2), stack,10,8,0.02F)); } } //########## ########## ########## ########## the event is aknoledge and execute when the maps load  ### VillagerProfession.FLETCHER  ### VillagerProfession.TOOLSMITH  //########## But is not working      is a random piece of code is not working  could it be than this code is old 1.18 and no valid anymore for 1.20.4 or the thing are this numbers  stack,10,8,0.02F));  i dont know what this numbers means    ########## the question is ¿how to add things to the villager traders    thanks for your attention               
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.