Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.10.2] Villager Trading Prices?

Guest
Guest
in Modder Support

Featured Replies

Posted

My custom trades don't seem to be making any sense! Sometimes they fit perfectly with my code, other times they don't.

 

Code:

 

package net.anti_quark.EssentialFeatures.common.entity;

import net.anti_quark.EssentialFeatures.common.block.ModBlocks;
import net.minecraft.entity.passive.EntityVillager;
import net.minecraft.entity.passive.EntityVillager.ITradeList;
import net.minecraft.entity.passive.EntityVillager.PriceInfo;
import net.minecraft.entity.passive.EntityVillager.EmeraldForItems;
import net.minecraft.entity.passive.EntityVillager.ListItemForEmeralds;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.common.registry.VillagerRegistry;

public class VillagerMechanic {

protected static final VillagerRegistry.VillagerProfession PROFESSION = new VillagerRegistry.VillagerProfession("mechanic", "minecraft:textures/entity/villager/villager.png", "");
    protected static final VillagerRegistry.VillagerCareer CAREER = new VillagerRegistry.VillagerCareer(PROFESSION, "mechanic")
    		.addTrade(1, new EmeraldForItems(Items.REDSTONE, new PriceInfo(20, 1)))
    		.addTrade(1, new ListItemForEmeralds(new ItemStack(Items.REDSTONE), new PriceInfo(4, 64)))
    		.addTrade(2, new ListItemForEmeralds(new ItemStack(Blocks.REDSTONE_LAMP), new PriceInfo(1, 3)))
    		.addTrade(2, new ListItemForEmeralds(new ItemStack(ModBlocks.stainedLamp), new PriceInfo(1, 3)));
        
    public static void addVillagers ()
    {
    	VillagerRegistry.instance().register(PROFESSION);
    }
}

 

 

And here are the trades in-game:

 

Trade 1, works as expected:

 

.addTrade(1, new EmeraldForItems(Items.REDSTONE, new PriceInfo(20, 1)))

trade1.png

 

Trade 2, doesn't work as expected:

 

.addTrade(1, new ListItemForEmeralds(new ItemStack(Items.REDSTONE), new PriceInfo(4, 64)))

trade2.png

 

Trade 3, works as expected:

 

.addTrade(2, new ListItemForEmeralds(new ItemStack(Blocks.REDSTONE_LAMP), new PriceInfo(1, 3)))

trade3.png

 

Trade 4, doesn't work as expected:

 

.addTrade(2, new ListItemForEmeralds(new ItemStack(ModBlocks.stainedLamp), new PriceInfo(1, 3)));

trade4.png

 

  • Quote

    • Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    https://forums.minecraftforge.net/topic/40921-1102-villager-trading-prices/
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.