Jump to content

[1.10.2] TileEntitys Data synchronisation and updating Containers


Recommended Posts

Posted

I'm trying to update my mod from 1.9 to 1.10.2 (forge version 12.16.1.1887 to 12.18.2.2098).

 

Most of my mods work just fine, but with my AccessControl I'm having a little bit of a problem. The access panels can have different colors and some other properties, but on loading a world they all have the default properties on the client side. It seems that on the server side they have correct properties because they are behaving as they should, although looking differently. As soon as they are activated once the clientside gets the correct data and now they are looking as they should.

 

This is my code of the BlockAccessPanel.java

 

  Reveal hidden contents

and this is the TileEntityAccessPanel.java

 

  Reveal hidden contents

 

 

and I can't seem to find a correct way to update this line

((ICrafting)this.crafters.get(j)).sendSlotContents(this, i, itemstack1);

in public void detectAndSendChanges() in the container...

ContainerAccessAdministrator.java:

 

  Reveal hidden contents

 

 

Edit: The solution was to update the line to:

this.listeners.get(0).sendSlotContents(this, i, itemstack1);

The whole code can be found here:

GitHub Repo

Posted

1.9.4 changed

TileEntity

syncing a bit, the initial chunk data sent to the client now includes the update tag (

TileEntity#getUpdateTag

) of every

TileEntity

in the chunk; the update packet (

TileEntity#getUpdatePacket

) is only sent afterwards. This document by williewillus explains the changes in more detail.

 

ICrafting

was renamed to

IContainerListener

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 10/11/2016 at 12:27 PM, Choonster said:

1.9.4 changed

TileEntity

syncing a bit, the initial chunk data sent to the client now includes the update tag (

TileEntity#getUpdateTag

) of every

TileEntity

in the chunk; the update packet (

TileEntity#getUpdatePacket

) is only sent afterwards. This document by williewillus explains the changes in more detail.

Thanks a lot! This solved it. Good explanation too :)

 

  Quote

ICrafting

was renamed to

IContainerListener

.

When I chage

((ICrafting)this.crafters.get(j)).sendSlotContents(this, i, itemstack1);

to

((IContainerListener)this.inventorySlots.get(j)).sendSlotContents(this, i, itemstack1);

(as this.craftes does not seem to exist any more) it does compile but crashes as soon as I open the Gui with a "Cannot be cast" Exception. Is there anythin else but crafters and inventorySlots that I can use there? I didn't find it...

Posted

Container#listeners

contains the

Container

's

IContainerListener

s.

 

Since generics were added to the vanilla codebase in 1.8.9 (or more accurately no longer stripped by Mojang's obfuscation process), you don't need to cast values when retrieving them from collections; the returned values are already the appropriate type. Only cast values when it's required and you already know that the value is of the type you're casting to.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

I know about Generics, I just can't see what that got to do with my problem?

 

Maybe I should be asking differently:

How do I get the client side of the Gui to immediatly display a change made to an item in one of the containers slots on the server side?

Right now the item updates client side (shows the correct tool tip) as soon as I take it out of the slot. How can I update the item so I see the correct tool tip even if I only hover it?

Posted
  On 10/11/2016 at 6:29 PM, Roxane said:

On that one I can't follow you...

 

Right at the moment I'm delaying the problem by simply commenting out the line, but I haven't found a proper solution yet.

 

The basic gist of what I was saying is don't cast unless you have a reason to and you know that the value you're casting is actually an instance of the type you're casting to.

 

Container#inventorySlots

is a

List<Slot>

.

Slot

is completely unrelated to

IContainerListener

, so don't try to cast a

Slot

to

IContainerListener

.

 

Container#listeners

is a

List<IContainerListener>

. You don't need to cast values from this to

IContainerListener

because they're already that type.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • That is incorrect. Use the run.bat or run.sh to run the server.
    • Hello, I have been trying for days to create my server with forge-1.20.1-47.4.1-installer, which installs the server, but the forge-1.20.1-47.4.1.jar file, which is necessary to create the server, does not appear. I no longer know what to do. Help. hola buenas, llevo dias intentando poder hacer mi servidor con forge-1.20.1-47.4.1-installer el cual instalo el server, pero no aparece el archivo forge-1.20.1-47.4.1.jar , el cual es necesario para poder crear el server, ya no se que hacer ayuda.
    • Does this happen if you use the regular vanilla minecraft launcher? Also, unsure if TLauncher ever has a legit usage, as I have always seen it associated with software piracy, but if it has a legit mode, make sure it is using online mode so that it can authenticate your MS account to login. Aside from that, more information is likely needed. Post logs, as well as the paths you are placing files in (screenshots of your file explorer can be helpful as well).
    • I am using a third-party launcher that has pre-installed forge versions of Minecraft.  When I insert mods from CurseForge, I extract the files and as expected put them in the .mods folder. I am guessing that there is an error with the file transfer but I don't know for sure and sometimes I use Forge to test mods that I created before releasing previously on a different pc, so I don't know if it is the if it an extraction error but if are any tips or knowledge reply and I will read it. This is also will be kept on the forum for others that have the issues.
    • I make wires and i need connection 2 wires block. I have BooleanPropertys registered, but in mod loading it show Unknown the property in assets/wuntare/blockState. public static final BooleanProperty CONNECTED_NORTH = BooleanProperty.create("connected_north"); public static final BooleanProperty CONNECTED_SOUTH = BooleanProperty.create("connected_south"); public static final BooleanProperty CONNECTED_WEST = BooleanProperty.create("connected_west"); public static final BooleanProperty CONNECTED_EAST = BooleanProperty.create("connected_east"); public static final BooleanProperty CONNECTED_UP = BooleanProperty.create("connected_up"); public static final BooleanProperty CONNECTED_DOWN = BooleanProperty.create("connected_down"); public CopperWireWithoutInsulation0(Properties properties) { super(properties); this.registerDefaultState(this.stateDefinition.any() .setValue(CONNECTED_NORTH, false) .setValue(CONNECTED_SOUTH, false) .setValue(CONNECTED_WEST, false) .setValue(CONNECTED_EAST, false) .setValue(CONNECTED_UP, false) .setValue(CONNECTED_DOWN, false)); } @Override protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> builder) { builder.add(CONNECTED_NORTH, CONNECTED_SOUTH, CONNECTED_WEST, CONNECTED_EAST, CONNECTED_UP, CONNECTED_DOWN); } In this part blockState have problem "multipart": [ { "apply": { "model": "wuntare:block/copper_wire_without_insulation0" } }, { "when": { "connected_north": true }, "apply": { "model": "wuntare:block/copper_wire_without_insulation0_north" } },  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.