Jump to content

EntityItem Spawning Twice


TLHPoE

Recommended Posts

I have a "recipe" where a player can right click a full cauldron that has 2 entity items in it to create 1 entity item as a product. It consumes 2 gold nuggets and 1 healing potion I or 2 gold ingots and 1 healing potion II.

 

The problem right now is presented below:

2 gold nuggets + 1 healing potion I = 1 healing potion

2 gold ingots + 1 healing potion II = 1 greater healing potion

4 gold nuggets + 1 healing potion I = 2 healing potions

4 gold ingots + 1 healing potion II = 2 greater healing potions

6 gold nuggets + 1 healing potion I = 2 healing potions (remainder of 2 gold nuggets)

6 gold ingots + 1 healing potion II = 2 greater healing potions (remainder of 2 gold ingots)

 

The problematic results are bolded.

 

Code:

    @SubscribeEvent
    public void playerInteract(PlayerInteractEvent.RightClickBlock ev) {
        EntityPlayer p = ev.getEntityPlayer();

        if(!p.world.isRemote) {
            if(p.world.getBlockState(ev.getPos()).getBlock() == Blocks.CAULDRON) {
                if(p.world.getBlockState(ev.getPos()).getValue(BlockCauldron.LEVEL).intValue() == 3) {
                    if(p.getHeldItemMainhand().getItem() == Items.STICK) {
                        List<EntityItem> entities = p.world.getEntitiesWithinAABB(EntityItem.class, new AxisAlignedBB(ev.getPos()));
                        EntityItem goldNE = null, goldE = null, potion1E = null, potion2E = null;

                        for(EntityItem ei : entities) {
                            ItemStack is = ei.getEntityItem();
                            Item i = is.getItem();

                            if(i == Items.GOLD_NUGGET) {
                                if(is.getCount() >= 2) {
                                    goldNE = ei;
                                }
                            } else if(i == Items.GOLD_INGOT) {
                                if(is.getCount() >= 2) {
                                    goldE = ei;
                                }
                            } else if(i == Items.POTIONITEM) {
                                ItemPotion pot = (ItemPotion) i;
                                List<PotionEffect> effects = PotionUtils.getEffectsFromStack(is);

                                for(PotionEffect eff : effects) {
                                    if(eff.getPotion() == Potion.getPotionById(6)) { //TODO: make config to change instant health potion ID
                                        if(eff.getAmplifier() == 0) {
                                            potion1E = ei;
                                        } else if(eff.getAmplifier() == 1) {
                                            potion2E = ei;
                                        }
                                    }
                                }
                            }
                        }

                        if(goldNE != null && potion1E != null) {
                            goldNE.getEntityItem().shrink(2);

                            EntityItem newPot = new EntityItem(p.world, potion1E.posX, potion1E.posY, potion1E.posZ, new ItemStack(QuickConsume.healing_potion, 1)); //PRODUCT 1
                            p.world.spawnEntity(newPot);
                            p.world.removeEntity(potion1E);
                            
                            return;
                        }

                        if(goldE != null && potion2E != null) {
                            goldE.getEntityItem().shrink(2);

                            EntityItem newPot = new EntityItem(p.world, potion2E.posX, potion2E.posY, potion2E.posZ, new ItemStack(QuickConsume.greater_healing_potion, 1)); //PRODUCT 2
                            p.world.spawnEntity(newPot);
                            p.world.removeEntity(potion2E);
                            
                            return;
                        }
                    }
                }
            }
        }
    }

Kain

Link to comment
Share on other sites

I believe this event that you are basing this on, fires once for each side (Server, Client) & once for each hand (Left, Right) the player has.

As such, there are a maximum of 4 different outcomes (Server, Left)...(Client, Right) that can happen.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update: I managed to make the item not disappear after crafting, but it doesn't remove any durability. import net.minecraft.enchantment.EnchantmentHelper; import net.minecraft.enchantment.Enchantments; import net.minecraft.enchantment.UnbreakingEnchantment; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; public class NuggetHammer extends Item { private boolean damage; public NuggetHammer(Properties p_i48487_1_) { super(p_i48487_1_); } @Override public int getMaxDamage(ItemStack stack) { return 54 - 1; } public boolean isBarVisible(ItemStack stack) { return false; } @Override public ItemStack getContainerItem(ItemStack stack) { ItemStack copy = stack.copy(); copy.setCount(1); if (!this.damage) return copy; int unbreaking = EnchantmentHelper.getItemEnchantmentLevel(Enchantments.UNBREAKING, stack); for (int i = 0; i < unbreaking; i++) { if (UnbreakingEnchantment.shouldIgnoreDurabilityDrop(stack, unbreaking, random)) return copy; } copy.setDamageValue(stack.getDamageValue() + 1); if (copy.getDamageValue() > stack.getMaxDamage()) return ItemStack.EMPTY; return copy; } }  
    • I cannot find the answer anywhere public static void onPlayerConsumeXp(PlayerXpEvent.PickupXp event){ if(event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*) != null){ int shorthand = event.getEntity().getMainHandItem().getAllEnchantments().get(*value i need*); I am trying to get my custom enchant inside that *value i need*, I have tried using strings and Enchantments. does not show my enchantment. This is my enchantment class package net.test.tutorialmod.enchants; import net.minecraft.world.entity.EquipmentSlot; import net.minecraft.world.item.enchantment.Enchantment; import net.minecraft.world.item.enchantment.EnchantmentCategory; public class clever extends Enchantment { public clever(Rarity pRarity, EnchantmentCategory pCategory, EquipmentSlot... pApplicableSlots) { super(pRarity, pCategory, pApplicableSlots); } @Override public int getMaxLevel() { return 10; } @Override public int getMinLevel() { return 1; } }  What am i doing wrong?  
    • I had this same issue, it was one of the mods I had installed, some mods seem to break with certain versions of forge and cause others to break as well, trial and error different mods till you find the broken one.  
    • Hi, I'm asking for your help because I can't figure out how to make it so that when an item is crafted on the Crafting Table, it returns the item to the player's inventory and makes the item lose durability. I've tried looking everywhere without success. Like for the crafting of the cake which returns the empty bucket to the player, but also makes it lose durability.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.