Jump to content

Recommended Posts

Posted

So basically, I'm making a mod that involves taking 3 glass bottles (required specifically 3) to one milk bucket, and it returns three milk bottles.

 

The problem I am have is when I craft this I only need to put one glass bottle to get three milk bottles, see code below for what the crafting recipe is.

 

GameRegistry.addShapelessRecipe(new ItemStack(milkBottle,3), new ItemStack(Item.bucketMilk,1,0),new ItemStack(Item.glassBottle,3,0));

 

I have made a special handler which checks to make sure I am using exact three glass bottles and not one just one, and to return the remaining bottles.

 

package ResourcefulMod;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import cpw.mods.fml.common.ICraftingHandler;

public class CraftingWithMilkBottlesHandler implements ICraftingHandler 
{
int maxBottleFillPerBucket = 3;
@Override
public void onCrafting(EntityPlayer player, ItemStack item, IInventory craftMatrix) 
{
	for(int i = 0; i < craftMatrix.getSizeInventory(); i++)
	{
		if(craftMatrix.getStackInSlot(i) != null)
		{
			ItemStack j = craftMatrix.getStackInSlot(i);
			ItemStack j = craftMatrix.getStackInSlot(i);
			if(j.getItem() != null && j == new ItemStack(Item.glassBottle) && j.stackSize == 3)
			{
				ItemStack k = new ItemStack(Item.glassBottle, 0);
				craftMatrix.setInventorySlotContents(i, k);
			}
			else if(j.getItem() != null && j == new ItemStack(Item.glassBottle) && j.stackSize != 3)
			{
				int returnNum = j.stackSize - maxBottleFillPerBucket; // Gets return amount of bottles back.
				if(returnNum < maxBottleFillPerBucket)
				{
					returnNum = 0;
				}
				ItemStack k = new ItemStack(Item.glassBottle, returnNum); // Return extra glass bottles back, if any into a new item stack.
				craftMatrix.setInventorySlotContents(i, k); // Replace itemstack
			}

		}
	}
}

@Override
public void onSmelting(EntityPlayer player, ItemStack item){}

}

 

 

However as I have said before even if I comment out the handler or not, I still can craft 3 milk bottles with just one milk bucket and one glass bottle, rather than one milk bucket and three glass bottles.

 

By the way, here is the whole implementation of the item from the main mod class.

GameRegistry.registerCraftingHandler(new CraftingWithMilkBottlesHandler()); // Starts the milk bottles handler
Item milkBottle = (new ItemFood(525, 2, 0.6F, false)).setIconIndex(5).setItemName("milkBottle").setMaxStackSize(32); // Creates the milk bottle item
LanguageRegistry.addName(milkBottle, "Bottle o' Milk"); // Registers the item with a name
GameRegistry.addShapelessRecipe(new ItemStack(milkBottle,3), new ItemStack(Item.bucketMilk,1,0),new ItemStack(Item.glassBottle,3,0)); // The shapeless recipe from the first line of code at the beginning of the post

 

Any ideas to what I may need to edit or add?

 

Thanks.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Yep I did upgrade just because it showed me a new version available.  I'll redownload the mod list and make sure anything works.  Thanks!
    • The latest log was taken down by pastebin for some reason. Did you try removing the mods you added? The mods you updated, was there a specific reason you updated, or just because? It's possible the updates introduced incompatibilitie, or even need a newer build of forge. If you didn't need the updates for a specific reason, you could also try downgrading those mods.
    • Please read the FAQ, and post logs as described there. https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/
    • I am using forge 1.20.1 (version 47.3.0). My pc has an RTX 4080 super and an i9 14900 KF, I am on the latest Nvidia graphics driver, latest windows 10 software, I have java 23, forge 1.12.2 works and so does all vanilla versions but for some reason no version of forge 1.20.1 works and instead the game just crashes with the error code "-1." I have no mods in my mods fodler, I have deleted my options.txt and forge.cfg files in case my settings were causing a crash and have tried removing my forge version from the installations folder and reinstalling but no matter what I still crash with the same code and my log doesn't tell me anything: 18:34:53.924 game 2025-02-06 18:34:53,914 main WARN Advanced terminal features are not available in this environment 18:34:54.023 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, mrmirchi, --version, 1.20.1-forge-47.3.0, --gameDir, C:\Users\aryam\AppData\Roaming\.minecraft, --assetsDir, C:\Users\aryam\AppData\Roaming\.minecraft\assets, --assetIndex, 5, --uuid, 2db00ea8d678420a8956109a85d90e9d, --accessToken, ????????, --clientId, ZWI3NThkNzMtNmNlZS00MGI5LTgyZTgtYmZkNzcwMTM5MGMx, --xuid, 2535436222989555, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\aryam\AppData\Roaming\.minecraft\quickPlay\java\1738838092785.json, --launchTarget, forgeclient, --fml.forgeVersion, 47.3.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412] 18:34:54.027 game [18:34:54] [main/INFO] [cp.mo.mo.Launcher/MODLAUNCHER]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.8 by Microsoft; OS Windows 10 arch amd64 version 10.0 18:34:54.132 game [18:34:54] [main/INFO] [ne.mi.fm.lo.ImmediateWindowHandler/]: Loading ImmediateWindowProvider fmlearlywindow 18:34:54.191 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Trying GL version 4.6 18:34:54.303 game [18:34:54] [main/INFO] [EARLYDISPLAY/]: Requested GL version 4.6 got version 4.6 18:34:54.367 monitor Process Monitor Process crashed with exit code -1     screenshot of log: https://drive.google.com/file/d/1WdkH88H865XErvmIqAKjlg7yrmj8EYy7/view?usp=sharing
    • I am currently working on a big mod, but I'm having trouble with my tabs, I want to find a way to add tabs inside tabs, like how in mrcrayfishes furniture mod, his furniture tab has multiple other sub tabs to them, so i know it is possible but i just don't know how it is possible, any help would be appreciated, thanks
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.