Jump to content

(Solved)Restrict container slot to a specific item? Shift-right click crash help


XxArchangelz

Recommended Posts

I have a tile entity/container for a block and I want to be able to restrict what can go in its inventory slot to a specific item in my mod, but for the life of me I cannot figure out how. I also have it so that shift clicking crashes the game (not supposed to happen xD) and I can see that I need to have something like

public boolean mergeItemStack(itemStack, start, end, backwards)

But I don't know exactly where to put it and what it does.

Here is my tile entity class

 

package archangel.necromancy.tileentity;

 

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.inventory.IInventory;

import net.minecraft.item.ItemStack;

import net.minecraft.nbt.NBTTagCompound;

import net.minecraft.nbt.NBTTagList;

import archangel.necromancy.lib.Strings;

 

public class TileAltar extends TileNC implements IInventory {

// Then create a ItemStack array (I.E. ItemStack[])

private ItemStack[] inventory;

 

// Then create a super constructor and give the inventory the amount of

// ItemStacks you want (Slots),

// I.E. (for 1 slot: inventory = new ItemStack[1];, for 5 slots: inventory =

// new ItemStack[5];)

public TileAltar() {

inventory = new ItemStack[1];

}

 

// This returns the inventory size

@Override

public int getSizeInventory() {

return inventory.length;

}

 

// This returns the stack that is in the slot you picked

// This has 1 param

// @param int slotIndex is just the index you selected

@Override

public ItemStack getStackInSlot(int slotIndex) {

return inventory[slotIndex];

}

 

// This sets the slots contents, it has 2 params

// @param int slot, this is the slots number

// @param ItemStack stack, this is the stack you want to add

@Override

public void setInventorySlotContents(int slot, ItemStack stack) {

inventory[slot] = stack;

// This checks to make sure the stack is not nothing, and then makes

// sure the stack is not going over the limit

// Of the stack

if (stack != null && stack.stackSize > getInventoryStackLimit()) {

stack.stackSize = getInventoryStackLimit();

}

}

 

// This decreases the stack size

// It has 2 params

// @param int slotIndex, this is the slot number

// @param int amount, this is the amount you want to decreases by

@Override

public ItemStack decrStackSize(int slotIndex, int amount) {

// This gets the stack with the slot number you want

ItemStack stack = getStackInSlot(slotIndex);

 

// Then it checks to make sure it has something in it

if (stack != null) {

// Then it checks to make sure that it has something that is equal

// or lesser than the amount you want to add

if (stack.stackSize <= amount) {

setInventorySlotContents(slotIndex, null);

} else {

stack = stack.splitStack(amount);

if (stack.stackSize == 0) {

setInventorySlotContents(slotIndex, null);

}

}

}

 

// Then it returns the stack

return stack;

}

 

// This returns the stack in the slot you chose

// It has 1 param

// @param int slotIndex this is the slot number you choose to get

@Override

public ItemStack getStackInSlotOnClosing(int slotIndex) {

// This gets the stack in the slot you chose

ItemStack stack = getStackInSlot(slotIndex);

 

// This checks to make sure it has something in it

if (stack != null) {

setInventorySlotContents(slotIndex, null);

}

 

// Then it returns the stack

return stack;

}

 

// This gets the inventory's stack limit

// This is normally 64 but on some conditions it is something lower

@Override

public int getInventoryStackLimit() {

return 1;

}

 

// Basically this makes sure the player is not to far away to activate the

// block and, makes sure its the Entity you are

// Selecting

@Override

public boolean isUseableByPlayer(EntityPlayer player) {

return worldObj.getBlockTileEntity(xCoord, yCoord, zCoord) == this

&& player.getDistanceSq(xCoord + 0.5, yCoord + 0.5,

zCoord + 0.5) < 64;

}

 

// A dummy, mostly un-used method, for a check to do something when you open

// the Gui

@Override

public void openChest() {

}

 

// Another dummy, mostly un-used method, for a check to do something when

// you close the Gui

@Override

public void closeChest() {

}

 

@Override

public void readFromNBT(NBTTagCompound tagCompound) {

super.readFromNBT(tagCompound);

 

NBTTagList tagList = tagCompound.getTagList("Inventory");

 

for (int i = 0; i < tagList.tagCount(); i++) {

NBTTagCompound tag = (NBTTagCompound) tagList.tagAt(i);

 

byte slot = tag.getByte("Slot");

 

if (slot >= 0 && slot < inventory.length) {

inventory[slot] = ItemStack.loadItemStackFromNBT(tag);

}

}

}

 

@Override

public void writeToNBT(NBTTagCompound tagCompound) {

super.writeToNBT(tagCompound);

 

NBTTagList itemList = new NBTTagList();

 

for (int i = 0; i < inventory.length; i++) {

ItemStack stack = inventory;

 

if (stack != null) {

NBTTagCompound tag = new NBTTagCompound();

 

tag.setByte("Slot", (byte) i);

stack.writeToNBT(tag);

itemList.appendTag(tag);

}

}

 

tagCompound.setTag("Inventory", itemList);

}

 

// This returns the inventory's name

@Override

public String getInvName() {

return "container." + Strings.ALTAR_NAME;

}

 

}

 

 

 

and the container class

 

package archangel.necromancy.inventory;

 

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.entity.player.InventoryPlayer;

import net.minecraft.inventory.Container;

import net.minecraft.inventory.Slot;

import net.minecraft.item.ItemStack;

import archangel.necromancy.tileentity.TileAltar;

 

public class ContainerAltar extends Container {

 

private TileAltar altar;

 

public ContainerAltar(InventoryPlayer inventoryPlayer, TileAltar altar) {

 

// Set the instance of the TileAltar for the container

this.altar = altar;

 

// Add the book slot to the container

this.addSlotToContainer(new Slot(altar, 0, 56, 17));

 

// Add the player's inventory slots to the container

for (int inventoryRowIndex = 0; inventoryRowIndex < 3; ++inventoryRowIndex) {

for (int inventoryColumnIndex = 0; inventoryColumnIndex < 9; ++inventoryColumnIndex) {

this.addSlotToContainer(new Slot(inventoryPlayer,

inventoryColumnIndex + inventoryRowIndex * 9 + 9,

8 + inventoryColumnIndex * 18,

94 + inventoryRowIndex * 18));

}

}

 

// Add the player's action bar slots to the container

for (int actionBarSlotIndex = 0; actionBarSlotIndex < 9; ++actionBarSlotIndex) {

this.addSlotToContainer(new Slot(inventoryPlayer,

actionBarSlotIndex, 8 + actionBarSlotIndex * 18, 152));

}

}

 

public boolean canInteractWith(EntityPlayer player) {

 

return true;

}

 

@Override

public ItemStack transferStackInSlot(EntityPlayer player, int slot) {

ItemStack stack = null;

Slot slotObject = (Slot) inventorySlots.get(slot);

 

// null checks and checks if the item can be stacked (maxStackSize > 1)

if (slotObject != null && slotObject.getHasStack()) {

ItemStack stackInSlot = slotObject.getStack();

stack = stackInSlot.copy();

 

// merges the item into player inventory since its in the tileEntity

if (slot < 9) {

if (!this.mergeItemStack(stackInSlot, 9, 45, true)) {

return null;

}

}

// places it into the tileEntity is possible since its in the player

// inventory

else if (!this.mergeItemStack(stackInSlot, 0, 9, false)) {

return null;

}

 

if (stackInSlot.stackSize == 0) {

slotObject.putStack(null);

} else {

slotObject.onSlotChanged();

}

 

if (stackInSlot.stackSize == stack.stackSize) {

return null;

}

slotObject.onPickupFromSlot(player, stackInSlot);

 

}

return stack;

}

 

}

 

 

Link to comment
Share on other sites

I figured it out and fixed the shift right click crash

I use

@Override

public ItemStack transferStackInSlot(EntityPlayer entityPlayer, int slot) {

Slot slotObject = (Slot) inventorySlots.get(slot);

if(slotObject != null && slotObject.getHasStack()) {

ItemStack stackInSlot = slotObject.getStack();

ItemStack stack = stackInSlot.copy();

if(slot <= 1) {

if(!mergeItemStack(stackInSlot, 2, inventorySlots.size(), true))

return null;

} else if(slot != 1 && stack.itemID == ModItems.necronomicon.itemID && !getSlot(0).getHasStack()) {

ItemStack copy = slotObject.decrStackSize(1);

getSlot(0).putStack(copy);

return null;

 

} else {

return null;

}

 

if(stackInSlot.stackSize == 0)

slotObject.putStack(null);

else

slotObject.onSlotChanged();

 

return stack;

}

return null;

}

 

 

 

But I don't entirely understand it and I still cannot restrict ONLY allowing a specific item into the slot

Link to comment
Share on other sites

NINJA EDIT

I figured it all out. The solution is to create a custom slot (non vanilla slot) and specify it in the class to only allow said items

example

 

package archangel.necromancy.inventory;

 

import net.minecraft.inventory.IInventory;

import net.minecraft.inventory.Slot;

import net.minecraft.item.ItemStack;

import archangel.necromancy.item.ModItems;

 

public class SlotNecronomicon extends Slot {

public SlotNecronomicon(IInventory inventory, int par2, int par3, int par4) {

super(inventory, par2, par3, par4);

}

 

@Override

public boolean isItemValid(ItemStack itemstack) {

return itemstack.itemID == ModItems.necronomicon.itemID;

}

 

@Override

public int getSlotStackLimit() {

return 1;

}

}

 

 

the slot inside container class

 

// Add the book slot to the container

this.addSlotToContainer(new SlotNecronomicon(altar, 0, 56, 17));

 

  • Thanks 1
Link to comment
Share on other sites

  • 6 months later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.