So I've tried several different methods to try to find my ore in game after the world has been created so first and foremost I wanna know if I have gone wrong somewhere and if so can you please spot it because im not sure myself. here's the code.

package com.crim.parallelworlds.world;

import java.util.Random;

import com.crim.parallelworlds.handlers.BlockHandler;

import net.minecraft.block.state.IBlockState;
import net.minecraft.world.World;
import net.minecraft.world.chunk.IChunkGenerator;
import net.minecraft.world.chunk.IChunkProvider;
import net.minecraftforge.fml.common.IWorldGenerator;

public class OreGen implements IWorldGenerator{
	
	@Override
	public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider){
		if(world.provider.getDimension() == 0){
			generateOverworld(random, chunkX, chunkZ, world, chunkGenerator, chunkProvider);
		}
	}
	private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider){
		generateOre(BlockHandler.nightOre.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 1, 40, 4 + random.nextInt(4), 12);
	}
	private void generateOre(IBlockState ore, World world, Random random, int x, int z, int minY, int maxY, int size, int chance){
		
	}

}

In my preInit method

GameRegistry.registerWorldGenerator(new OreGen(), 3);

5 minutes ago, Criminox said:

	private void generateOverworld(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider){
		generateOre(BlockHandler.nightOre.getDefaultState(), world, random, chunkX * 16, chunkZ * 16, 1, 40, 4 + random.nextInt(4), 12);
	}
	private void generateOre(IBlockState ore, World world, Random random, int x, int z, int minY, int maxY, int size, int chance){
		
	}

 

You're calling generateOre, which is a method that does nothing.

13 minutes ago, Jay Avery said:

You're calling generateOre, which is a method that does nothing.

What exactly do I put in that method? I thought you just used it to initialize the generateOre used in generateOverworld 

30 minutes ago, Criminox said:

What exactly do I put in that method? I thought you just used it to initialize the generateOre used in generateOverworld 

You need to create a WorldGenerator object for your ore and call generate() on it - either construct an instance of a vanilla class (WorldGenMinable is used for most vanilla ores so could be fine for your purposes) - or make your own implementation for specific generation rules. Take a look at the vanilla WorldGen___ classes to see how they work (they're in net.minecraft.world.gen.feature)