Jump to content

[1.8.9] Not really sure whats wrong


Fuffles

Recommended Posts

 

Hello everyone!

I just recently started modding and well, as usual, something is wrong with the item rendering model. Not sure why, you are my only hope

The Log

Spoiler

[00:01:20] [Client thread/ERROR] [FML]: Exception loading model for variant collision:shambler_chest#inventory for item "tc_collision:shambler_chest"
java.lang.Exception: Could not load model definition for variant collision:shambler_chest#inventory
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:215) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadItems(ModelLoader.java:259) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:116) ~[ModelLoader.class:?]
    at net.minecraft.client.resources.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:120) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.startGame(Minecraft.java:515) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:360) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:116) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.RuntimeException: Encountered an exception when loading model definition of model tc_collision:blockstates/shambler_chest.json
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:165) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
Caused by: java.io.FileNotFoundException: collision:blockstates/shambler_chest.json
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getAllResources(SimpleReloadableResourceManager.java:82) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:143) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
[00:01:20] [Client thread/ERROR] [FML]: Exception loading model for variant collision:shambler_helm#inventory for item "tc_collision:shambler_helm"
java.lang.Exception: Could not load model definition for variant collision:shambler_helm#inventory
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:215) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadItems(ModelLoader.java:259) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:116) ~[ModelLoader.class:?]
    at net.minecraft.client.resources.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:120) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.startGame(Minecraft.java:515) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:360) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:116) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.RuntimeException: Encountered an exception when loading model definition of model collision:blockstates/shambler_helm.json
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:165) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
Caused by: java.io.FileNotFoundException: collision:blockstates/shambler_helm.json
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getAllResources(SimpleReloadableResourceManager.java:82) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:143) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
[00:01:20] [Client thread/ERROR] [FML]: Exception loading model for variant collision:shambler_legs#inventory for item "tc_collision:shambler_legs"
java.lang.Exception: Could not load model definition for variant collision:shambler_legs#inventory
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:215) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.loadItems(ModelLoader.java:259) ~[ModelLoader.class:?]
    at net.minecraftforge.client.model.ModelLoader.setupModelRegistry(ModelLoader.java:116) ~[ModelLoader.class:?]
    at net.minecraft.client.resources.model.ModelManager.onResourceManagerReload(ModelManager.java:28) [ModelManager.class:?]
    at net.minecraft.client.resources.SimpleReloadableResourceManager.registerReloadListener(SimpleReloadableResourceManager.java:120) [SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.Minecraft.startGame(Minecraft.java:515) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:360) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:116) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_121]
    at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_121]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.RuntimeException: Encountered an exception when loading model definition of model collision:blockstates/shambler_legs.json
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:165) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
Caused by: java.io.FileNotFoundException: collision:blockstates/shambler_legs.json
    at net.minecraft.client.resources.SimpleReloadableResourceManager.getAllResources(SimpleReloadableResourceManager.java:82) ~[SimpleReloadableResourceManager.class:?]
    at net.minecraft.client.resources.model.ModelBakery.getModelBlockDefinition(ModelBakery.java:143) ~[ModelBakery.class:?]
    at net.minecraftforge.client.model.ModelLoader.getModelBlockDefinition(ModelLoader.java:211) ~[ModelLoader.class:?]
    ... 19 more
[00:01:20] [Client thread/ERROR] [FML]: Model definition for location collision:shambler_chest#inventory not found
[00:01:20] [Client thread/ERROR] [FML]: Suppressed additional 6 model loading errors for domain collision

Render Class

Spoiler

package com.fuffles.cc.render;

import com.fuffles.cc.CCGlobal;
import com.fuffles.cc.items.CCItems;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;

public class CCItemRender {
    
    public static void resgisterItemRender () {
        
        regItem(CCItems.shambler_helm);
        regItem(CCItems.shambler_chest);
        regItem(CCItems.shambler_legs);
        
    }
    public static void regItem(Item item) {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(CCGlobal.MOD_ID + ":" + item.getUnlocalizedName().substring(5), "inventory"));
    }

}

JSON Files

Spoiler

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "fuff:items/shambler_helm"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "fuff:items/shambler_chest"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "fuff:items/shambler_legs"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}

 

Sorry if the mistake is obvious, Im just really really new to this

 

Edited by Fuffles
Link to comment
Share on other sites

12 minutes ago, diesieben07 said:
  • Do not use the ItemModelMesher to register your models, use ModelLoader.setCustomModelResourceLocation in preInit from your client proxy.
  • Do not use the unlocalized name to generate your ModelResourceLocation. Use something like new ModelResourceLocation(item.getRegistryName(), "inventory")
  • Update to 1.11.2, there is no point in developing for outdated versions.

okay, thanks, how would I exactly use ModelBakery.ModelLoader in that code line? If its not a problem to ask for a corrected line

 

Edited by Fuffles
t
Link to comment
Share on other sites

8 minutes ago, diesieben07 said:

I did not say anything about ModelBakery. And setCustomModelResourceLocation should be self-explanatory, it takes the same parameters as the method you are using now.

Maybe not to someone who worked with forge for over 4 hours sitting on 3 items that still dont work, sorry for time wasting, maybe will figure it out sooner/later

 

Link to comment
Share on other sites

40 minutes ago, Fuffles said:

okay, thanks, how would I exactly use ModelBakery.ModelLoader in that code line? If its not a problem to ask for a corrected line

 

You just need to replace this: Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register, with this: ModelLoader.setCustomModelResourceLocation. The method parameters are the same so the part inside the brackets doesn't need to change (except for diesieben07's point about using registry name and not unlocalised name).

 

This line from your console log shows another problem:

Quote

Caused by: java.io.FileNotFoundException: collision:blockstates/shambler_helm.json

 

It's looking for a file inside an assets folder called collision, but your assets folder is called fuff. Which one is your modid? Everything should use the same ID so that assets are in the logical place.

Edited by Jay Avery
Link to comment
Share on other sites

Thanks for the help :( Especially since Im a beginner, I really appreciete the help. Sadly I still dont see my items in game, files that got changed
 

Item Render

Spoiler

package com.fuffles.cc.render;

import com.fuffles.cc.items.CCItems;

import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class CCItemRender {
    
    public static void resgisterItemRender () {
        
        //Shambling Set
        regItem(CCItems.shambler_helm);
        regItem(CCItems.shambler_chest);
        regItem(CCItems.shambler_legs);
        
    }
    public static void regItem(Item item) {
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
    }

}

JSON's
 

Spoiler

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "tc_collision:items/shambler_chest"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}

{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "tc_collision:items/shambler_helm"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}
{
    "parent": "builtin/generated",
    "textures": {
        "layer0": "tc_collision:items/shambler_legs"
    },
    "display": {
        "thirdperson": {
            "rotation": [ -90, 0, 0 ],
            "translation": [ 0, 1, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 0, -135, 25 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        }
    }
}
 

changed fuff to c_collision since thats my MOD_ID

Edited by Fuffles
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.