Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.11.2] What consequences could have the use of FMLClientHandler in this specific situation?


ctbe
 Share

Recommended Posts

In an overridden method that doesn't tell me the facing on which a block was hit after breaking (onBlockDestroyed), I am using FMLClientHandler.instance().getClient() and if it is not null I try to get what face of the block was hit with FMLClientHandler.instance().getClient().objectMouseOver.sideHit.

 

Everything works fine and I have not had any problems. I don't know if this is the best way, it is the only way I found. I call this inside the logical server and I am playing in single player. 

 

If the mod is used in a multiplayer server in which the server as well the client have the mod installed, would that cause trouble?

 

If the answer is yes, would there be a preferred way to get the side of the block that was hit?

Link to comment
Share on other sites

This is a bad idea.

  1. On the logical server, you are reaching across logical sides. This will not work reliably. Sometimes it will give you wrong answers, sometimes it will crash, the outcome is basically unpredictable. You also ignore the fact that single player is not always single player. If the player opened the world up to LAN and someone joined, that someone would still get the main player's objectMouseOver here, because the server is running on their machine and therefor it can only access their client.
  2. On a dedicated server, this will just outright crash the game with a ClassNotFoundException, because the server has no idea what FMLClientHandler is.

As for how to do this: What are you trying to achieve, functionality wise (not how you intend to code that functionality).

  • Like 1
Link to comment
Share on other sites

I understand. Thanks for explaining. I could have messed up really bad. I must change my code.

 

I am trying to get which face of the block was hit when a block broke because depending on the face that it was hit, I will perform operations on neighbor blocks. If it was hit on the West or East side I will ignore the East and West offset blocks and work on the North and South offsets. If it was hit on the North and South offsets I will ignore the North and South offsets and work on the East and West offsets. But the block has to first break before I can perform operations on the neighbor blocks.

 

I have an item that extends ItemPickaxe and I override the onBlockDestroyed method which has signature

public Boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntitiLivingBase entityLiving)

 

I thought I could get the face it was hit from the IBlockState, but I can't find any method that would return it. Or maybe I'm not searching well.

To get that information I later thought I could override the onBlockStartBreak method which gets called right before onBlockDestroyed gets called, but that one has less information passed as arguments. onBlockStartBreak has only an ItemStack, BlockPos, and EntityPlayer on its signature.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • pos1 and pos2 are the same position. As such your AABB is completely empty.
    • There are various classes available that you can extend. The most meaningful one probably being AbstractJarFileLocator.
    • Any dynamic item data must be stored in the ItemStack. There is only one instance of your Item class. Use ItemStack#getOrCreateTagElement with your ModID to get a CompoundTag. You can store whatever data you want in this tag.
    • You don't. Technic Launcher needs to use the established mechanisms for Minecraft versions (.minecraft/versions). Only the vanilla launcher is supported by Forge. If you have issues using a different launcher, speak to them.
    • So I am porting code from 1.17 to 1.18 and there is a problem. When you throw / spawn the projectile entity it crashes the game. The full log can be found here: https://www.toptal.com/developers/hastebin/vifidaxibo.yaml I do not know why this is happening. Here is the class where I register the renderers: @Mod.EventBusSubscriber(modid = Catty.MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public class ClientEventBusSubscriber { private static final Logger LOGGER = LogManager.getLogger(); //@SubscribeEvent OLD //public static void clientSetup(FMLClientSetupEvent event) { // ItemRenderer renderer = Minecraft.getInstance().getItemRenderer(); // // LOGGER.info("Entity renderers registered!"); //} @SubscribeEvent public void RegisterEntityRenderers(EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityInit.PUSHEEN_PROJECTILE.get(), ThrownItemRenderer::new); LOGGER.info("Catty entity renderers registered!"); } }   Here is the PusheenEntity Class:  public class PusheenEntity extends ThrowableItemProjectile { public PusheenEntity(EntityType<? extends PusheenEntity> type, Level world) { super(type, world); } public PusheenEntity(Level world, LivingEntity entity) { super(EntityInit.PUSHEEN_PROJECTILE.get(), entity, world); } public PusheenEntity(Level world, double x, double y, double z) { super(EntityInit.PUSHEEN_PROJECTILE.get(), x, y, z, world); } @ParametersAreNonnullByDefault @Override protected void onHit(HitResult rtResult) { super.onHit(rtResult); Explosion.BlockInteraction explosion$mode = net.minecraftforge.event.ForgeEventFactory.getMobGriefingEvent(this.level, this.getOwner()) ? Explosion.BlockInteraction.DESTROY : Explosion.BlockInteraction.NONE; this.level.explode(this, this.getX(), this.getY(), this.getZ(), 2.0F, explosion$mode); if (!this.level.isClientSide) { this.discard(); } } @Nonnull @Override protected Item getDefaultItem() { return ItemInit.PUSHEEN.get().asItem(); } @Nonnull @Override public Packet<?> getAddEntityPacket() { return NetworkHooks.getEntitySpawningPacket(this); } } The entity is registered here: public class EntityInit { public static final DeferredRegister<EntityType<?>> ENTITY_TYPES = DeferredRegister.create(ForgeRegistries.ENTITIES, Catty.MOD_ID); public static final RegistryObject<EntityType<PusheenEntity>> PUSHEEN_PROJECTILE = ENTITY_TYPES.register("pusheen_projectile", () -> EntityType.Builder.<PusheenEntity>of(PusheenEntity::new, MobCategory.MISC).sized(0.25F, 0.25F).clientTrackingRange(4).updateInterval(10).build("pusheen_projectile")); } Any help will be appreciated
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.