Jump to content

[Forge 1.10.2] How to create multi-block structure (3x3 and the entity sit in) that find entity and convert it into a spawn egg?


Recommended Posts

Posted (edited)
1 hour ago, Jay Avery said:

That is another extremely broad question. This forum isn't for getting people to write your code for you. What have you got so far, and what problems are you having?

I'm having a problem that I don't know how to check whether the entity match the spawn egg or not

Edited by lethinh
Posted
13 minutes ago, lethinh said:

I'm having a problem that I don't know how to check whether the entity match the spawn egg or not

 

Use EntityList.getKey(Entity) to get the registry name of an entity, check if that registry name exists as a key in EntityList.ENTITY_EGGS (i.e. the entity has a spawn egg registered) and then create an ItemStack of Items.SPAWN_EGG with the registry name in the NBT.

 

Look at ItemMonsterPlacer.applyEntityIdToItemStack to see the NBT structure you need to create for the spawn egg. You can't use the method directly because it's client-only.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
On 27/4/2017 at 8:22 PM, Choonster said:

 

Use EntityList.getKey(Entity) to get the registry name of an entity, check if that registry name exists as a key in EntityList.ENTITY_EGGS (i.e. the entity has a spawn egg registered) and then create an ItemStack of Items.SPAWN_EGG with the registry name in the NBT.

 

Look at ItemMonsterPlacer.applyEntityIdToItemStack to see the NBT structure you need to create for the spawn egg. You can't use the method directly because it's client-only.

But there is no method getKey and field ENITITY_EGGS in EntityList

Posted (edited)
29 minutes ago, lethinh said:

But there is no method getKey and field ENITITY_EGGS in EntityList

 

That advice was for 1.11.2, I missed that you were using 1.10.2.

 

In 1.10.2, use EntityList.getEntityString to get the registry name of an entity instead of using EntityList.getKey. The rest of my previous post still applies to 1.10.2.

 

EntityList.ENTITY_EGGS should exist in 1.10.2 if you're using recent MCP mappings. If it doesn't exist in your workspace, either update your mappings or look for the field with type Map<String, EntityList.EntityEggInfo>.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
On 29/4/2017 at 4:00 PM, Choonster said:

 

That advice was for 1.11.2, I missed that you were using 1.10.2.

 

In 1.10.2, use EntityList.getEntityString to get the registry name of an entity instead of using EntityList.getKey. The rest of my previous post still applies to 1.10.2.

 

EntityList.ENTITY_EGGS should exist in 1.10.2 if you're using recent MCP mappings. If it doesn't exist in your workspace, either update your mappings or look for the field with type Map<String, EntityList.EntityEggInfo>.

I have followed what you said but didn't work. It didn't spawn the correct spawn egg. Here is my code:

 

public boolean itemInteractionForEntity(ItemStack stack, EntityPlayer playerIn, EntityLivingBase target,
            EnumHand hand) {
        if (target.worldObj.isRemote || !(target instanceof EntityAnimal) || target instanceof EntityMob) {
            return false;
        }

        String entityId = EntityList.getEntityString(target);

        if (EntityList.ENTITY_EGGS.containsKey(entityId)) {
            ItemStack spawnEgg = new ItemStack(Items.SPAWN_EGG);

            NBTTagCompound compound = spawnEgg.hasTagCompound() ? spawnEgg.getTagCompound() : new NBTTagCompound();
            NBTTagCompound tagCompound = new NBTTagCompound();
            tagCompound.setString("id", entityId);
            compound.setTag("AnimalTag", tagCompound);
            spawnEgg.setTagCompound(compound);

            playerIn.worldObj.removeEntity(target);
            InventoryUtils.dropItemStack(target.worldObj, target.getPosition(), spawnEgg);
        }

        return true;
    }

Posted

Please post code in a code block (the <> button in the editor) or on Gist/Pastebin with syntax highlighting.

 

That's not the same NBT structure created by ItemMonsterPlacer.applyEntityIdToItemStack, it uses "EntityTag" rather than "AnimalTag".

 

The target instanceof EntityMob condition is pointless, as it will always be false. When it's reached, target will always be an instance of EntityAnimal and can't be an instance of EntityMob.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
Just now, Choonster said:

Please post code in a code block (the <> button in the editor) or on Gist/Pastebin with syntax highlighting.

 

That's not the same NBT structure created by ItemMonsterPlacer.applyEntityIdToItemStack, it uses "EntityTag" rather than "AnimalTag".

 

The target instanceof EntityMob condition is pointless, as it will always be false. When it's reached, target will always be an instance of EntityAnimal and can't be an instance of EntityMob.

 

Thanks. I finally got it to work but it doesn't work with other mods. Could you show me how to make it work with other mods?

Posted
21 minutes ago, lethinh said:

Thanks. I finally got it to work but it doesn't work with other mods. Could you show me how to make it work with other mods?

 

It should work for any mob with a spawn egg registered, regardless of which mod it's from.

 

What makes you think it isn't working with other mods?

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted (edited)
Just now, Choonster said:

 

It should work for any mob with a spawn egg registered, regardless of which mod it's from.

 

What makes you think it isn't working with other mods?

I have tried with Chickens mod but didn't work

Edited by lethinh
Posted (edited)
7 minutes ago, lethinh said:

I have tried with Chickens mod but didn't work

 

The Chickens mod doesn't use the vanilla spawn egg system for its entities, since they're all subtypes of a single class. It has its own spawn egg item.

 

You'll need to handle any mod that uses its own spawn eggs individually if you want your system to work with entities from those mods.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted (edited)
Just now, Choonster said:

 

The Chickens mod doesn't use the vanilla spawn egg system for its entities, since they're all subtypes of a single class. It has its own spawn egg item.

 

You'll need to handle any mod that uses its own spawn eggs individually if you want your system to work with entities from those mods.

Thanks!

Edited by lethinh

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.