Jump to content

[Forge 1.10.2] How to create multi-block structure (3x3 and the entity sit in) that find entity and convert it into a spawn egg?


Recommended Posts

Posted (edited)
  On 4/27/2017 at 11:22 AM, Jay Avery said:

That is another extremely broad question. This forum isn't for getting people to write your code for you. What have you got so far, and what problems are you having?

Expand  

I'm having a problem that I don't know how to check whether the entity match the spawn egg or not

Edited by lethinh
Posted
  On 4/27/2017 at 1:04 PM, lethinh said:

I'm having a problem that I don't know how to check whether the entity match the spawn egg or not

Expand  

 

Use EntityList.getKey(Entity) to get the registry name of an entity, check if that registry name exists as a key in EntityList.ENTITY_EGGS (i.e. the entity has a spawn egg registered) and then create an ItemStack of Items.SPAWN_EGG with the registry name in the NBT.

 

Look at ItemMonsterPlacer.applyEntityIdToItemStack to see the NBT structure you need to create for the spawn egg. You can't use the method directly because it's client-only.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 4/27/2017 at 1:22 PM, Choonster said:

 

Use EntityList.getKey(Entity) to get the registry name of an entity, check if that registry name exists as a key in EntityList.ENTITY_EGGS (i.e. the entity has a spawn egg registered) and then create an ItemStack of Items.SPAWN_EGG with the registry name in the NBT.

 

Look at ItemMonsterPlacer.applyEntityIdToItemStack to see the NBT structure you need to create for the spawn egg. You can't use the method directly because it's client-only.

Expand  

But there is no method getKey and field ENITITY_EGGS in EntityList

Posted (edited)
  On 4/29/2017 at 8:30 AM, lethinh said:

But there is no method getKey and field ENITITY_EGGS in EntityList

Expand  

 

That advice was for 1.11.2, I missed that you were using 1.10.2.

 

In 1.10.2, use EntityList.getEntityString to get the registry name of an entity instead of using EntityList.getKey. The rest of my previous post still applies to 1.10.2.

 

EntityList.ENTITY_EGGS should exist in 1.10.2 if you're using recent MCP mappings. If it doesn't exist in your workspace, either update your mappings or look for the field with type Map<String, EntityList.EntityEggInfo>.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 4/29/2017 at 9:00 AM, Choonster said:

 

That advice was for 1.11.2, I missed that you were using 1.10.2.

 

In 1.10.2, use EntityList.getEntityString to get the registry name of an entity instead of using EntityList.getKey. The rest of my previous post still applies to 1.10.2.

 

EntityList.ENTITY_EGGS should exist in 1.10.2 if you're using recent MCP mappings. If it doesn't exist in your workspace, either update your mappings or look for the field with type Map<String, EntityList.EntityEggInfo>.

Expand  

I have followed what you said but didn't work. It didn't spawn the correct spawn egg. Here is my code:

 

public boolean itemInteractionForEntity(ItemStack stack, EntityPlayer playerIn, EntityLivingBase target,
            EnumHand hand) {
        if (target.worldObj.isRemote || !(target instanceof EntityAnimal) || target instanceof EntityMob) {
            return false;
        }

        String entityId = EntityList.getEntityString(target);

        if (EntityList.ENTITY_EGGS.containsKey(entityId)) {
            ItemStack spawnEgg = new ItemStack(Items.SPAWN_EGG);

            NBTTagCompound compound = spawnEgg.hasTagCompound() ? spawnEgg.getTagCompound() : new NBTTagCompound();
            NBTTagCompound tagCompound = new NBTTagCompound();
            tagCompound.setString("id", entityId);
            compound.setTag("AnimalTag", tagCompound);
            spawnEgg.setTagCompound(compound);

            playerIn.worldObj.removeEntity(target);
            InventoryUtils.dropItemStack(target.worldObj, target.getPosition(), spawnEgg);
        }

        return true;
    }

Posted

Please post code in a code block (the <> button in the editor) or on Gist/Pastebin with syntax highlighting.

 

That's not the same NBT structure created by ItemMonsterPlacer.applyEntityIdToItemStack, it uses "EntityTag" rather than "AnimalTag".

 

The target instanceof EntityMob condition is pointless, as it will always be false. When it's reached, target will always be an instance of EntityAnimal and can't be an instance of EntityMob.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 5/3/2017 at 4:40 AM, Choonster said:

Please post code in a code block (the <> button in the editor) or on Gist/Pastebin with syntax highlighting.

 

That's not the same NBT structure created by ItemMonsterPlacer.applyEntityIdToItemStack, it uses "EntityTag" rather than "AnimalTag".

 

The target instanceof EntityMob condition is pointless, as it will always be false. When it's reached, target will always be an instance of EntityAnimal and can't be an instance of EntityMob.

Expand  

 

Thanks. I finally got it to work but it doesn't work with other mods. Could you show me how to make it work with other mods?

Posted
  On 5/3/2017 at 4:49 AM, lethinh said:

Thanks. I finally got it to work but it doesn't work with other mods. Could you show me how to make it work with other mods?

Expand  

 

It should work for any mob with a spawn egg registered, regardless of which mod it's from.

 

What makes you think it isn't working with other mods?

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted (edited)
  On 5/3/2017 at 5:13 AM, Choonster said:

 

It should work for any mob with a spawn egg registered, regardless of which mod it's from.

 

What makes you think it isn't working with other mods?

Expand  

I have tried with Chickens mod but didn't work

Edited by lethinh
Posted (edited)
  On 5/3/2017 at 5:19 AM, lethinh said:

I have tried with Chickens mod but didn't work

Expand  

 

The Chickens mod doesn't use the vanilla spawn egg system for its entities, since they're all subtypes of a single class. It has its own spawn egg item.

 

You'll need to handle any mod that uses its own spawn eggs individually if you want your system to work with entities from those mods.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted (edited)
  On 5/3/2017 at 5:26 AM, Choonster said:

 

The Chickens mod doesn't use the vanilla spawn egg system for its entities, since they're all subtypes of a single class. It has its own spawn egg item.

 

You'll need to handle any mod that uses its own spawn eggs individually if you want your system to work with entities from those mods.

Expand  

Thanks!

Edited by lethinh

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Managed to solve the issue myself. Solved by a fresh modpack instance.
    • Hello, so straight to the problem. Today i wanted to startup Enigmatica as usual and it just wont startup. Last night everything worked fine, i didnt even turn off my pc. Crash log: https://mclo.gs/GJ6Kcy1
    • Rubidium and Embeddium are versions of the same mod, you can only have one. I believe Embeddium is the one that's actively maintained.
    • Hello, New to modding, but have a solid CS foundation. I've created multiple custom BlockEntities that all have the same issue, which is that the inventory only updates on right click (overriding the useItemOn method). I've seen multiple posts on here outlining a similar issue to mine, but I've already implemented the solution of: overriding the correct methods in the BlockEntity class and calling setChanged(). I've tried every different place for setChanged() to no success. I'm wondering if I'm missing something else or if there was some change to sending data to the client in 1.21.5? Or will I have to use a custom packet sender? Here is the code for one of my BlockEntity classes with a single inventory slot: public class MyCustomBlockEntity extends BlockEntity { public final ItemStackHandler inventory = new ItemStackHandler(1) { @Override protected int getStackLimit(int slot, @NotNull ItemStack stack) { return 1; } @Override protected void onContentsChanged(int slot) { setChanged(); if (!level.isClientSide()) { level.setBlockAndUpdate(getBlockPos(), getBlockState()); } } }; public MyCustomBlockEntity(BlockPos pPos, BlockState pBlockState) { super(ModBlockEntities.MY_CUSTOM_BE.get(), pPos, pBlockState); } public void clearContents() { inventory.setStackInSlot(0, ItemStack.EMPTY); } public void dropItem() { SimpleContainer inv = new SimpleContainer(inventory.getSlots()); inv.setItem(0, inventory.getStackInSlot(0)); Containers.dropContents(this.level, this.worldPosition, inv); } @Override public void setRemoved() { dropItem(); super.setRemoved(); } @Override protected void saveAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.saveAdditional(pTag, pRegistries); pTag.put("inventory", inventory.serializeNBT(pRegistries)); } @Override protected void loadAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.loadAdditional(pTag, pRegistries); inventory.deserializeNBT(pRegistries, pTag.getCompound("inventory").get()); } @Override public Packet<ClientGamePacketListener> getUpdatePacket() { return ClientboundBlockEntityDataPacket.create(this); } @Override public CompoundTag getUpdateTag(HolderLookup.Provider pRegistries) { return saveWithoutMetadata(pRegistries); } } Mostly encountering the issue when calling the clearContents() method anywhere outside of useItemOn() in the Block class. I've also tried overriding both the handleUpdateTag() and onDataPacket() methods, calling their super along with loadAdditional(), but neither changed the outcome. Thanks in advance for any replies.
    • Hi all! I’m working on a Jurassic Park-themed mod for Minecraft 1.20.1, aiming to include dinosaurs, fossils, DNA extraction, and cool machines. This is a free project, mainly passion-driven, and I’ll give full credit to everyone involved. this is the perfect opportunity for beginners of modeling and coding. This project will give you experience and a creative freedom If you love dinosaurs and Minecraft modding, hit me up! Thanks! Add Me ogfrost. <--- Discord
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.