Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.11.2] Custom Sound Issues


MinecraftWero
 Share

Recommended Posts

Hello, I wanted to add a custom sound to my mod and it registers but it sounds different than the sound I want to use, here's my code:

 

SoundHandler

package com.minecraftwero.baconmod.handlers;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.util.Utils;

import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundEvent;

public class BaconSoundHandler {

	private static int size = 0;
	
	
	public static SoundEvent BACON_SHOOT;
	
	public static void init(){
		size = SoundEvent.REGISTRY.getKeys().size();
	
		BACON_SHOOT = register("item.bacon_shoot.shoot");
	}

	
	public static SoundEvent register(String name){
		ResourceLocation location = new ResourceLocation(Reference.MODID, name);
		SoundEvent e = new SoundEvent(location);
	
		SoundEvent.REGISTRY.register(size, location, e);
		size++;
		Utils.getLogger().info("Registered sound: " + name);
		return e;
	}
}


	

 

Sound .json

{
    "item.bacon_shoot.shoot": {
        "category": "item",
        "subtitle": "item.bacon_shoot.shoot",
        "sounds": [ { "name": "bmod:item/bacon_shoot/shoot", "stream": true } ]
    }
   }

 

and here's my Item class that I want the sound for (basically ItemSnowball class:

package com.minecraftwero.baconmod.items;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.entities.EntityBacon;
import com.minecraftwero.baconmod.handlers.BaconSoundHandler;
import com.minecraftwero.baconmod.init.ModItems;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArrow;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.items.ItemStackHandler;

public class BaconLauncher extends Item
{
	public BaconLauncher(String unlocalizedName, String registryName) {
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));
		this.setMaxStackSize(1);
	}
    /**
     * Called when the equipped item is right clicked.
     */
	
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
    {
        ItemStack itemStack = playerIn.getHeldItem(handIn);
       
        for (int i = 0; i < playerIn.inventory.getSizeInventory(); ++i){
            
        	ItemStack itemstack = playerIn.inventory.getStackInSlot(i);
            
        	if (itemstack.getItem()==ModItems.rawbacon){
            
        		itemstack.shrink(1);
               
                if (!worldIn.isRemote)
                {
                    EntityBacon entitybacon = new EntityBacon(worldIn, playerIn);
                    entitybacon.setHeadingFromThrower(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 1.5F, 1.0F);
                    worldIn.spawnEntity(entitybacon);
                    worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, BaconSoundHandler.BACON_SHOOT, SoundCategory.NEUTRAL, 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
                }
                break;
            }
        }
        
        
        playerIn.addStat(StatList.getObjectUseStats(this));
        return new ActionResult(EnumActionResult.SUCCESS, itemStack);
    }
}

 

I would appreciate it if someone could point out what I am doing wrong, oh I and I also registered the SoundHandlers inside my Init on main class.

Screen Shot 2017-06-05 at 9.26.31 PM.png

Link to comment
Share on other sites

6 minutes ago, DimensionsInTime said:

0.4F / (itemRand.nextFloat() * 0.4F + 0.8F

 

Why is your pitch that complicated formula and not 1.0F for normal speed?

wow I feel so dumb now.. that fixed it! thank you.

 

Edit: is there anyway to make it sound as soon as I press the right click? it's working now but it has a tiny delay.

Edited by MinecraftWero
Link to comment
Share on other sites

14 minutes ago, diesieben07 said:

How did you get to that conclusion? You posted where you register your sound. Great. That tells us nothing about where and how you play it.

 

I guess there was an issue with formatting in the main post..

anyways I  managed to fix it, here is my item class:

Spoiler

package com.minecraftwero.baconmod.items;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.entities.EntityBacon;
import com.minecraftwero.baconmod.handlers.BaconSoundHandler;
import com.minecraftwero.baconmod.init.ModItems;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArrow;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.items.ItemStackHandler;

public class BaconLauncher extends Item
{
	public BaconLauncher(String unlocalizedName, String registryName) {
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));
		this.setMaxStackSize(1);
	}
    /**
     * Called when the equipped item is right clicked.
     */
	
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
    {
        ItemStack itemStack = playerIn.getHeldItem(handIn);
       
        for (int i = 0; i < playerIn.inventory.getSizeInventory(); ++i){
            
        	ItemStack itemstack = playerIn.inventory.getStackInSlot(i);
            
        	if (itemstack.getItem()==ModItems.rawbacon){
            
        		itemstack.shrink(1);
               
                if (!worldIn.isRemote)
                {
                    EntityBacon entitybacon = new EntityBacon(worldIn, playerIn);
                    entitybacon.setHeadingFromThrower(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 1.5F, 1.0F);
                    worldIn.spawnEntity(entitybacon);
                    worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, BaconSoundHandler.BACON_SHOOT, SoundCategory.NEUTRAL, 1.0F, 2.0F);
                }
                    break;
            }
        }
        
        
        playerIn.addStat(StatList.getObjectUseStats(this));
        return new ActionResult(EnumActionResult.SUCCESS, itemStack);
    }
}

 

 

Edited by MinecraftWero
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hello, I want to register a seed reprocessor recipe from mystical agriculture in my mod. The recipe is at modid\src\main\resources\data\mysticalagriculture\recipes\seed\reprocessor The recipe works when mystical agriculture is loaded. But when MA isn't loaded, it throws an error: Parsing error loading recipe mysticalagriculture:seed/reprocessor/magical com.google.gson.JsonSyntaxException: Invalid or unsupported recipe type 'mysticalagriculture:reprocessor' How can I disable this recipe loading when MA isn't here ? Thanks !
    • Hello. I am tracking an Int Array to sync the data value between server and client. For some reason the tracked IntArray's max value is the Short Max Value, 32767 and when passing that, it overloads. https://github.com/Beardlessbrady/Currency-Mod/blob/master-1.16/src/main/java/com/beardlessbrady/gocurrency/blocks/vending/VendingContainer.java#L113 Is this normal, if not any ideas what could be causing this? The value is fine when being set up until I get the value from the client
    • Here's the crash report Why it crashes when i play with create mod without this mod is working fine but when i load it with this mod is crashing ---- Minecraft Crash Report ---- // Sorry :(   Time: 03.12.2021 17:47 Description: Unexpected error   java.lang.RuntimeException: GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT  at net.minecraft.client.shader.Framebuffer.func_147611_b(Framebuffer.java:164) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at net.minecraft.client.shader.Framebuffer.func_216492_b(Framebuffer.java:143) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at net.minecraft.client.shader.Framebuffer.func_227586_d_(Framebuffer.java:58) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at net.minecraft.client.shader.Framebuffer.func_216491_a(Framebuffer.java:46) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at net.minecraft.client.shader.Framebuffer.enableStencil(Framebuffer.java:307) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at com.simibubi.create.foundation.gui.UIRenderHelper.createFramebuffer(UIRenderHelper.java:48) ~[create:mc1.16.5_v0.3.2g] {re:mixin,re:classloading}  at com.simibubi.create.foundation.gui.UIRenderHelper.lambda$init$0(UIRenderHelper.java:40) ~[create:mc1.16.5_v0.3.2g] {re:mixin,re:classloading}  at com.mojang.blaze3d.systems.RenderSystem.replayQueue(SourceFile:116) ~[?:?] {re:classloading}  at com.mojang.blaze3d.systems.RenderSystem.flipFrame(SourceFile:103) ~[?:?] {re:classloading}  at net.minecraft.client.MainWindow.func_227802_e_(MainWindow.java:305) ~[?:?] {re:classloading,pl:runtimedistcleaner:A}  at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:996) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}  at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:mixin:APP:flywheel.mixins.json:ShaderCloseMixin,pl:mixin:APP:create.mixins.json:WindowResizeMixin,pl:mixin:A,pl:runtimedistcleaner:A}  at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.5-forge-36.2.2.jar:?] {re:classloading,pl:runtimedistcleaner:A}  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0-internal] {}  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0-internal] {}  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0-internal] {}  at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0-internal] {}  at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.2.jar:36.2] {}  at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}  at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}  at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}  at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}     A detailed walkthrough of the error, its code path and all known details is as follows: ---------------------------------------------------------------------------------------   -- System Details -- Details:  Minecraft Version: 1.16.5  Minecraft Version ID: 1.16.5  Operating System: Linux (arm) version Android-10  Java Version: 1.8.0-internal, Oracle Corporation  Java VM Version: OpenJDK Client VM (mixed mode), Oracle Corporation  Memory: 619526352 bytes (590 MB) / 962985984 bytes (918 MB) up to 962985984 bytes (918 MB)  CPUs: 8  JVM Flags: 3 total; -Xms949M -Xmx949M -Xbootclasspath/p:/storage/emulated/0/Android/data/net.kdt.pojavlaunch/files/caciocavallo/ResConfHack.jar:/storage/emulated/0/Android/data/net.kdt.pojavlaunch/files/caciocavallo/cacio-androidnw-1.10-SNAPSHOT.jar:/storage/emulated/0/Android/data/net.kdt.pojavlaunch/files/caciocavallo/cacio-shared-1.10-SNAPSHOT.jar  ModLauncher: 8.0.9+86+master.3cf110c  ModLauncher launch target: fmlclient  ModLauncher naming: srg  ModLauncher services:    /mixin-0.8.2.jar mixin PLUGINSERVICE    /eventbus-4.0.0.jar eventbus PLUGINSERVICE    /forge-1.16.5-36.2.2.jar object_holder_definalize PLUGINSERVICE    /forge-1.16.5-36.2.2.jar runtime_enum_extender PLUGINSERVICE    /accesstransformers-3.0.1.jar accesstransformer PLUGINSERVICE    /forge-1.16.5-36.2.2.jar capability_inject_definalize PLUGINSERVICE    /forge-1.16.5-36.2.2.jar runtimedistcleaner PLUGINSERVICE    /mixin-0.8.2.jar mixin TRANSFORMATIONSERVICE    /forge-1.16.5-36.2.2.jar fml TRANSFORMATIONSERVICE   FML: 36.2  Forge: net.minecraftforge:36.2.2  FML Language Providers:    javafml@36.2   minecraft@1  Mod List:    forge-1.16.5-36.2.2-client.jar |Minecraft |minecraft |1.16.5 |ENQUEUE_IM|Manifest: NOSIGNATURE   forge-1.16.5-36.2.2-universal.jar |Forge |forge |36.2.2 |ENQUEUE_IM|Manifest: 22:af:21:d8:19:82:7f:93:94:fe:2b:ac:b7:e4:41:57:68:39:87:b1:a7:5c:c6:44:f9:25:74:21:14:f5:0d:90   flywheel-1.16-0.2.5.jar |Flywheel |flywheel |1.16-0.2.5 |ENQUEUE_IM|Manifest: NOSIGNATURE   create-mc1.16.5_v0.3.2g.jar |Create |create |v0.3.2g |ENQUEUE_IM|Manifest: NOSIGNATURE  Crash Report UUID: 92c1896e-9478-4361-a7cf-aae00a584ee1  Launched Version: 1.16.5  Backend library: LWJGL version 3.2.3 SNAPSHOT  Backend API: GL4ES wrapper GL version 2.1 gl4es wrapper 1.1.5, ptitSeb  GL Caps: Using framebuffer using ARB_framebuffer_object extension  Using VBOs: Yes  Is Modded: Definitely; Client brand changed to 'forge'  Type: Client (map_client.txt)  Graphics mode: fancy  Resource Packs:   Current Language: English (US)  CPU: 9x ARMv8 Processor rev 4 (v8l)
    • Does this work? public static final RegistryObject<ForgeSpawnEggItem> SKELETON_SPAWN_EGG = ITEMS.register("skeleton_spawn_egg", () -> new ForgeSpawnEggItem(new Supplier<EntityType<? extends Mob>>() { @Override public EntityType<? extends Mob> get() { return EntityType.SKELETON; } }, 0x00FFA8, 0x326D59, new Item.Properties().tab(CreativeModeTab.TAB_MATERIALS)));  
  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.