Jump to content

[SOLVED][1.11.2] EventListeners


IvanSteklow

Recommended Posts

I want to change Event Listener of glass bottle. This EL does glass bottle turn into exp bottle. I have already write code, but it isn't works.

protected ItemStack turnBottleIntoItem(ItemStack originalstack, EntityPlayer player, ItemStack stack)
    {
		originalstack.shrink(1);

        if (p_185061_1_.isEmpty())
        {
            return stack;
        }
        else
        {
            if (!player.inventory.addItemStackToInventory(stack))
            {
                player.dropItem(stack, false);
            }

            return originalstack;
        }
    }
	
	@EventHandler
	public void onItemRightClick(PlayerInteractEvent.RightClickItem event){
		Notifier.info("Event Called", "Bottle");
		if(event.getItemStack() == new ItemStack(Items.GLASS_BOTTLE)){
			if(event.getEntityPlayer().experienceLevel >= 1){
				event.getEntityPlayer().removeExperienceLevel(1);
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				turnBottleIntoItem(event.getItemStack(), event.getEntityPlayer(), new ItemStack(Items.EXPERIENCE_BOTTLE, 4));
			}else{
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
			}
		}
	}

 

Please help me!

Edited by IvanSteklow
Solved
  • Like 1
Link to comment
Share on other sites

@Mod.EventHandler is only for FML lifecycle events that extend net.minecraftforge.fml.common.event.FMLEvent, e.g. FMLPreInitializationEvent or FMLServerStartedEvent and only works in your @Mod class.

 

@SubscribeEvent is used for gameplay events that extend net.minecraftforge.fml.common.eventhandler.Event, e.g. PlayerInteractEvent.RightClickItem or TickEvent.ServerTickEvent.

 

Forge's documentation explains events in more detail here.

 

The ItemStack returned by PlayerInteractEvent#getItemStack will never be reference equal to an ItemStack you've just created, because they're not the same object (which is what the == operator checks). To compare ItemStacks, either get the Item, metadata, etc. and compare those or use the static equality methods in the ItemStack class. Since you're only checking the Item, use ItemStack#getItem to get the Item and check if it's equal to (==Items.GLASS_BOTTLE.

Edited by Choonster
  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

7 minutes ago, Choonster said:

@Mod.EventHandler is only for FML lifecycle events that extend net.minecraftforge.fml.common.event.FMLEvent, e.g. FMLPreInitializationEvent or FMLServerStartedEvent and only works in your @Mod class.

 

@SubscribeEvent is used for gameplay events that extend net.minecraftforge.fml.common.eventhandler.Event, e.g. PlayerInteractEvent.RightClickItem or TickEvent.ServerTickEvent.

 

Forge's documentation explains events in more detail here.

 

The ItemStack returned by PlayerInteractEvent#getItemStack will never be reference equal to an ItemStack you've just created, because they're not the same object (which is what the == operator checks). To compare ItemStacks, either get the Item, metadata, etc. and compare those or use the static equality methods in the ItemStack class. Since you're only checking the Item, use ItemStack#getItem to get the Item and check if it's equal to (==Items.GLASS_BOTTLE.

 

I changed code, but it doesn't work

 

EventListener.java

public class EventListener {

	protected ItemStack turnBottleIntoItem(ItemStack originalstack, EntityPlayer player, ItemStack stack)
    {
		originalstack.shrink(1);

        if (originalstack.isEmpty())
        {
            return stack;
        }
        else
        {
            if (!player.inventory.addItemStackToInventory(stack))
            {
                player.dropItem(stack, false);
            }

            return originalstack;
        }
    }
	
	@SubscribeEvent
	public void onItemRightClick(PlayerInteractEvent.RightClickItem event){
		Notifier.info("Event Called", "Bottle");
		if(event.getItemStack().getItem() == Items.GLASS_BOTTLE){
			if(event.getEntityPlayer().experienceLevel >= 1){
				event.getEntityPlayer().removeExperienceLevel(1);
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				turnBottleIntoItem(event.getItemStack(), event.getEntityPlayer(), new ItemStack(Items.EXPERIENCE_BOTTLE, 4));
			}else{
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				event.getEntityPlayer().sendMessage(new TextComponentString("Not enough levels! Minimum: 1").setStyle(new Style().setColor(TextFormatting.YELLOW)));
			}
		}
	}
	
}

 

ModCore.java

@EventHandler
	public void preInit(FMLPreInitializationEvent e){
		Notifier.info("Pre Initialization event started successfully", Refs.NAME);
		MinecraftForge.EVENT_BUS.register(new EventListener().getClass());
	}

 

What's wrong?

  • Like 1
Link to comment
Share on other sites

Just now, IvanSteklow said:

What's wrong?

 

You're registering the Class with the event bus, but your event handler method isn't static. If you register the Class, you need to use a static method. If you register an instance, you need to use an instance method. The documentation explains this.

 

There's no reason to create a new object of a known class and immediately call Object#getClass on it, just use a class literal.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

23 minutes ago, Choonster said:

 

You're registering the Class with the event bus, but your event handler method isn't static. If you register the Class, you need to use a static method. If you register an instance, you need to use an instance method. The documentation explains this.

 

There's no reason to create a new object of a known class and immediately call Object#getClass on it, just use a class literal.

Thank you!

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.