Jump to content

[1.10.2][Solved] Entities spawning and dying rapidly when player is high up


FredTargaryen

Recommended Posts

I got the following bug report:

Spoiler

A weird problem seemingly caused by the rapid respawning of entities when you're above Y level 180 that causes extreme fps loss.

  1. Open SP with Rocket Squids
  2. Find an ocean
  3. Fly above Y level 180
  4. RIP FPS
  • Rocket Squids Version: 1.0 (Installed via the Curse/Twitch client, possibly out of date?)
  • Forge Version: 12.18.3.2281

I tried this out and got the same thing. I added a print statement to the entity constructor and setDead, and lots of my mobs were being created and quickly killed each second on client and server side when I flew above 180. As far as I know I haven't done anything out of the ordinary. I can show other code but here is the stuff which is probably relevant:

 

Entity and spawn registration (EntityRocketSquid is the problem, and possibly EntityBabyRocketSquid which extends EntityRocketSquid)

Spoiler

@Mod.EventHandler
    public void Init(FMLInitializationEvent event)
    {
        //Register Entities with EntityRegistry
        //Last three params are for tracking: trackingRange, updateFrequency and sendsVelocityUpdates
        EntityRegistry.registerModEntity(EntityRocketSquid.class, "rocketsquid", 0, instance, 64, 10, true);
        EntityRegistry.registerModEntity(EntityThrownSac.class, "nitroinksac", 1, instance, 64, 10, true);
        EntityRegistry.registerModEntity(EntityThrownTube.class, "turbotube", 2, instance, 64, 10, true);
        EntityRegistry.registerModEntity(EntityBabyRocketSquid.class, "babyrs", 4, instance, 64, 10, true);

        //Other Rocket Squid info
        EntityRegistry.addSpawn(EntityRocketSquid.class, spawnProb, minGrpSize, maxGrpSize, EnumCreatureType.WATER_CREATURE,
                Biomes.DEEP_OCEAN, Biomes.OCEAN, Biomes.RIVER, Biomes.SWAMPLAND);
        EntitySpawnPlacementRegistry.setPlacementType(EntityRocketSquid.class, EntityLiving.SpawnPlacementType.IN_WATER);
        EntityRegistry.registerEgg(EntityRocketSquid.class, 9838110, 16744192);

 

Config setup in PreInit

Spoiler

//CONFIG SETUP
        Configuration config = new Configuration(event.getSuggestedConfigurationFile());
        config.load();
        spawnProb = config.getInt("spawnProb", "Spawning", 4, 1, 100, "Weighted probability of a group spawning");
        minGrpSize = config.getInt("minGroupSize", "Spawning", 2, 1, 20, "Smallest possible size of a group");
        maxGrpSize = config.getInt("maxGroupSize", "Spawning", 5, 1, 40, "Largest possible size of a group");
        config.save();
        if(maxGrpSize < minGrpSize)
        {
            maxGrpSize = minGrpSize;
        }

 

EntityRocketSquid constructor

Spoiler

public EntityRocketSquid(World par1World)
    {
        super(par1World);
        //Set size of bounding box. par1=length and width; par2=height.
        //Normal squids are 0.8F, 0.8F. Previous: 1.1F, 1.1F
        this.setSize(0.99F, 0.99F);
        this.squidCap = this.getCapability(RocketSquidsBase.SQUIDCAP, null);
        this.playerRotated = false;
        this.breedCooldown = Short.MAX_VALUE;
        if(par1World.isRemote) {
            MinecraftForge.EVENT_BUS.register(this);
        }
        System.out.println("Constructing new Rocket Squid - "+(par1World.isRemote ? "client" : "server"));
        this.isBaby = false;
    }

 

If you want, you can see the code for yourself here.

Where have I gone wrong?

Thanks for reading.

 

UPDATE: Rocket Squids had canDespawn returning true. The sea level is at about y=63, and y=180 is almost 128 blocks away, which is the distance required to despawn an entity if it can be despawned. So the immediate despawning is perfectly normal. So the question isn't why are they spawning and dying, but why so many of them are spawning.

Edited by FredTargaryen
Link to comment
Share on other sites

  • 1 month later...

It turns out the spawning and despawning is completely normal (looks super inefficient to me but there you go). The problem was that in my constructor I would register each object on the event bus, so so many event handlers would end up being called that the framerate would go down.

 

So the takeaway is: only register on the event bus when you need to start listening for events, and unregister when you don't need to any more.

Edited by FredTargaryen
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Tried that, unfortunately didn't work. Any other solutions?
    • Add necronomicon https://www.curseforge.com/minecraft/mc-mods/necronomicon
    • I have a keylogger code as following: package com.key_logger_mod; import com.google.gson.Gson; import com.google.gson.GsonBuilder; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.client.event.InputEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.common.Mod; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import net.minecraft.client.Minecraft; import org.lwjgl.glfw.GLFW; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.nio.file.StandardOpenOption; import java.util.HashMap; import java.util.Map; @Mod.EventBusSubscriber(modid = "key_logger_mod", bus = Mod.EventBusSubscriber.Bus.FORGE, value = Dist.CLIENT) public class KeyboardLogger {     private static final Logger LOGGER = LogManager.getLogger();     private static final Gson gson = new GsonBuilder().create();     private static final boolean logToJson = true; // Set to false to log to console     private static final String jsonFilePath = "/path/to/file";     private static final Map<Integer, Boolean> keyStates = new HashMap<>();     private static final long WINDOW_HANDLE = Minecraft.getInstance().getWindow().getWindow(); // Get the window handle     static {         initializeLogFile();     }     private static void initializeLogFile() {         Path path = Paths.get(jsonFilePath);         try {             Files.write(path, "[".getBytes(), StandardOpenOption.CREATE, StandardOpenOption.TRUNCATE_EXISTING);         } catch (IOException e) {             LOGGER.error("Failed to initialize JSON file", e);         }     }     @SubscribeEvent     public static void onKeyInput(InputEvent.Key event) {         if (Minecraft.getInstance().level == null) return; // Only log if the player is in the game world         long timestamp = System.currentTimeMillis();         int key = event.getKey();         int action = event.getAction();         int mods = event.getModifiers();         synchronized (keyStates) {             if (action == GLFW.GLFW_PRESS) {                 if (!keyStates.getOrDefault(key, false)) {                     keyStates.put(key, true);                     logKeyAction(timestamp, key, "PRESS");                 }             } else if (action == GLFW.GLFW_RELEASE) {                 if (keyStates.getOrDefault(key, false)) {                     keyStates.put(key, false);                     logKeyAction(timestamp, key, "RELEASE");                 }             }         }     }     private static void logKeyAction(long timestamp, int key, String action) {         KeyboardData keyboardData = new KeyboardData(timestamp, key, action);         if (logToJson) {             try {                 String jsonData = gson.toJson(keyboardData) + ",";                 Files.writeString(Paths.get(jsonFilePath), jsonData + System.lineSeparator(), StandardOpenOption.CREATE, StandardOpenOption.APPEND);             } catch (IOException e) {                 LOGGER.error("Failed to write keyboard event to JSON file", e);             }         } else {             LOGGER.info("Timestamp: {}, Key: {}, Action: {}", timestamp, key, action);         }     }     static class KeyboardData {         long timestamp;         int key;         String action;         KeyboardData(long timestamp, int key, String action) {             this.timestamp = timestamp;             this.key = key;             this.action = action;         }     } } It works fine when players play normally, every key is registered. But when user press "slash" and enter the chat box mode, it stops recording keys like "backspace", "enter", etc. But still registering characters and number keys. Why is this happening?  
    • It happened on a snowy mountain in the overworld. It wasn't actually a crash, the game didn't close itself or something, it was more like when you are lagging online, and mobs are standing still, you cannot break blocks, things like that. Hope you'll find a solution Madz.
    • I am trying to add the mod "Create Questing" to the modpack SkyMachina but it just crashes. My log : https://pastebin.com/rq2jpph4   Please help, create is hard 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.