[1.12] JSON recipe input nbt insensitive

[thommy101]

Opening a topic here before reporting it to Github as I'm not 100% sure it's a bug. Posting to get some more input.

 

I've got an issue with setting up an JSON crafting recipe with items with specific nbt tags. Setting the output works perfect. The input is read correctly as it's displaying correctly through JEI.

I'm setting up one with input of type "minecraft:item_nbt" and the code path for loading it is as follows:

 

(Based on Forge build #2359)

On ShapedOreRecipe#210 it loads every crafting ingredient with CraftingHelper.getIngredient(...)

CraftingHelper.getIngredient(...) tries to load it with a factory defined at CraftingHelper#530 which correctly creates an ItemStack with NBT data defined.

CraftingHelpers method getIngredient returns an Ingredient, which apply method is used to verify if a stack matches the given item.

 

The problem I think there is, is that that method is NBT insensitive, it only checks the item and metadata even if the ItemStack has NBT data defined.

 

This could be solved by defining my own Ingredient, but I think there's a usecase within Forge for this too as many mods may use it.

 

Am I right this is issue worthy or should I just make my own Ingredient which overrides the default apply and make a NBT sensitive version of it?

[Choonster]

I made my own Ingredient class for this, but it would make sense for minecraft:item_nbt to create an NBT-sensitive Ingredient.

[thommy101]

Luckily I'm not the only one who thought so. Your implementation is exactly what I was going to write when no-one was gonna respond.

I think I'll open an issue over at the Github as you're also having the same "issue".