Jump to content

[1.10.2] Add a potion effect to an armor


themistik

Recommended Posts

Hello.

 

A pretty simple question for you maybe, but for me, I just feel PAIN. I've search for hours, and no one technique works...

Like the title of the topic, all I want is to add a Potion effect to an armor.

 

public class ItemModArmor extends ItemArmor{
	
	private PotionEffect[] effects;
	
	public ItemModArmor(ArmorMaterial materialIn, int renderIndexIn, EntityEquipmentSlot equipmentSlotIn, String unlocalizedName) {
		super(materialIn, renderIndexIn, equipmentSlotIn);
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName));
	}
	
	public ItemModArmor(ArmorMaterial materialIn, int renderIndexIn, EntityEquipmentSlot equipmentSlotIn, String unlocalizedName, PotionEffect...potionEffects) {
		super(materialIn, renderIndexIn, equipmentSlotIn);
		this.setUnlocalizedName(unlocalizedName);
		this.effects = potionEffects;
		this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName));
	}
	
	protected void onArmorTick(ItemStack stack, World worldIn, EntityPlayer player)
	{
	    if (stack.getItem() == ModArmor.canardChestplate) {
			for(PotionEffect effect : effects) {
				player.addPotionEffect(new PotionEffect(effect));
			}
	    }
	}

 

this is my main class for the armor. Easy to use.

 

First, I wanted to stay in this "easy to use" way. So I was think if the armor works like the food ; You added a potion effect to your constructor, like this :

 

public class ItemModFood extends ItemFood{

	private PotionEffect[] effects;
	
	public ItemModFood(String unlocalizedName, int amount, boolean isWolfFood, PotionEffect...potionEffects) {
		super(amount, isWolfFood);
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName));
		this.effects = potionEffects;
		// TODO Auto-generated constructor stub
	}
	
	public ItemModFood(String unlocalizedName, int amount, float saturation, boolean isWolfFood, PotionEffect...potionEffects) {
		super(amount, saturation, isWolfFood);
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName));
		this.effects = potionEffects;
		// TODO Auto-generated constructor stub
	}


	protected void onFoodEaten(ItemStack stack, World worldIn, EntityPlayer player)
	{
		for(PotionEffect effect : effects) {
			player.addPotionEffect(new PotionEffect(effect));
		}
	}

 

And I define the potion effects in my ModFood class, the one who is initalized.

 

	public static void init() {
		weed = new ItemModFood("weed", 1, 1, false, new PotionEffect(Potion.getPotionById(9), 500, 0), new PotionEffect(Potion.getPotionById(1), 500, 0));
	}
	
	public static void register() {
		registerItem(weed);
	}
	
	public static void registerRenders() {
		registerRender(weed);
	}
	
	public static void registerItem(Item item) {
		item.setCreativeTab(MainClass.Tab);
		GameRegistry.register(item);
		Utools.getLogger().info("Register item for" + item.getUnlocalizedName().substring(5));
	}
	
	public static void registerRender(Item item) {
		ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(new ResourceLocation(References.MODID, item.getUnlocalizedName().substring(5)), "inventory"));
		Utools.getLogger().info("Registered render for " + item.getUnlocalizedName().substring(5));
	}
}

 

(Sorry for the weed'joke, It was a request from a friend of mine, and I've seen in this item a good way to learn how to add potion effect to food stuff)

 

So, this works. There is a way to make this for an armor ? Because I've tried, but it dosen't work this way, obviously. So I've tried many things from other tutorials/videos, but I dosen't work.

 

After a decade, I've abandonned this "easy to use" method, and try an "harder" method. BUT ! This one dosen't work too !

 

	protected void onArmorTick(ItemStack stack, World worldIn, EntityPlayer player)
	{
	    if (stack.getItem() == ModArmor.canardChestplate) {
			for(PotionEffect effect : effects) {
				player.addPotionEffect(new PotionEffect(effect));
			}
	    }
	}

 

This is in my main class for armor.

 

I'm so lost I'm ready to throw anything up...

 

All I want, is to add a potion effect to an armor. If this is possibile, making the potion effect easy to add like the food method.

 

Thanks for the help.

 

Ps : Sorry if you don't understand all of this, English is not my native langage. Don't hestitate to ask me something.

Link to comment
Share on other sites

The constructor you're using for your new PotionEffect() is one which assigns a duration of 0 to the effect. Most effects won't actually be visible with a zero duration. You should try using one of the other constructors which takes in a duration and using a non-zero duration with it. If that still doesn't work, try adding a System.out.println() debug output inside that FOR loop to see if it's even running, and what the effect is if so; that should give you some more insight into the problem.

Whatever Minecraft needs, it is most likely not yet another tool tier.

Link to comment
Share on other sites

Are you sure ? Beacause I have this :

 

595760d983b4c_Sanstiqzdqzdqzdqzdtre.png.040c227680621912f96a2a091fb31a5f.png

 

I'll give a try for the PrintIn.

 

EDIT :

It seems its my For who dosen't work.

 

I have tried that :

 

Captqzdqzdure.PNG.ff86f29e2b0d8ef915a935a9f70e1c47.PNG

 

The console dosent show me anything about it.

Edited by themistik
added screenshot
Link to comment
Share on other sites

2 minutes ago, IceMetalPunk said:

The constructor you're using for your new PotionEffect() is one which assigns a duration of 0 to the effect.

No, he isn't. The constructor for PotionEffect takes in a Potion, duration and then amplifier so OP is passing 500 as the duration.

 

Getting potions by ID though... 

19 minutes ago, themistik said:

Potion.getPotionById(9)

Should not be used. I personaly have no idea what is potion with an ID of 9. And what if it changes later? Potions should be referenced from the MobEffects class instead of their IDs.

 

22 minutes ago, themistik said:

this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName));

Unlocalized names have nothing to do with registry names.

 

26 minutes ago, themistik said:

onArmorTick(ItemStack stack, World worldIn, EntityPlayer player)

This signature doesn't look right to me. I think that the method params have a different order. Add an Override annotation to the method. If eclipse reports an error then I am correct. You should not manually write overrides, let your IDE do that for you.

  • Like 1
Link to comment
Share on other sites

1 minute ago, V0idWa1k3r said:

No, he isn't. The constructor for PotionEffect takes in a Potion, duration and then amplifier so OP is passing 500 as the duration.

 

Getting potions by ID though... 

Should not be used. I personaly have no idea what is potion with an ID of 9. And what if it changes later? Potions should be referenced from the MobEffects class instead of their IDs.

 

Unlocalized names have nothing to do with registry names.

 

This signature doesn't look right to me. I think that the method params have a different order. Add an Override annotation to the method. If eclipse reports an error then I am correct. You should not manually write overrides, let your IDE do that for you.

The tutorial i'm using uses PotionEffect with an Id. I don't want to screw up things so I don't try anything this way

Same thing for " this.setRegistryName(new ResourceLocation(References.MODID, unlocalizedName)); "

 

For the signature, yes your are correct.

Link to comment
Share on other sites

1 minute ago, V0idWa1k3r said:

No, he isn't. The constructor for PotionEffect takes in a Potion, duration and then amplifier so OP is passing 500 as the duration.

*Facepalm* Whoops, I was looking at an entirely different line of code when I wrote that... I probably shouldn't try to help people at 4AM without sleep. I guess I'm taking the "Always Be Coding" motto too far...

Sorry, themistik! But, yes, as voidwalker pointed out, you've got your order of parameters mixed up; the ItemStack comes last, not first.

  • Like 1

Whatever Minecraft needs, it is most likely not yet another tool tier.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Minecraft java and forge seem to have it out for me, any ideas? I have had issues with exit code 1 while loading forge -fabric was having the same issues, but I seemed to fix it in these repairs? (tried different versions upwards from 1.19 to 1.20.2 for forge, nothing worked and I'm confident older versions wouldn't either) -The launcher itself loads fine, it will load the game within the launcher, and then crash the moment it tries to load outside of the launcher. I have tried the default launcher, legacy launcher, and the curse forge launcher, none have worked! (all have had the same problem) I think this started when I took a break and upgraded to windows 11 and wonder if that changed anything? I have tried the following: uninstalled & reinstalled java, (I have having issues where I download jdk 17 but only 8 would show up (would not show up anywhere but the control panel, not even the official uninstaller, I *think* I got that fixed) tried jarfix uninstalled & reinstalled minecraft tried alternate launchers -forge & legacy, & repaired them too. tried without mods updated game drivers uninstalled and reinstalled forge -including completely wiping it from my system changed java excutable path followed everything in the error code 1 post completely reset my pc I tried to change the launch path but couldn't seem to get it to work -the default launcher wont let me even see properties as an option, i have yet to try with the other two (i did try on legacy but it was being weird) I want to include my debug log; but its over the max size? sorry my brains gone numb from trying to fix this for the past 2 days
    • I personally create registries using DataPackRegistryEvent.NewRegistry. It's pretty powerful as long as you know how to make codecs. In some class, make a registry key like so: public static final ResourceKey<Registry<MyDataType>> MY_REGISTRY = ResourceKey.createRegistryKey(new ResourceLocation(MyMod.MOD_ID, "registry_name")); This will make a registry that holds objects of type "MyDataType". JSON files stored in data/<datapack_namespace>/modid/registryname/ will be parsed and put into this registry. Note that the directory structure has a folder named after your mod inside your datapack directory, so the actual path would look like: data/my_mod/my_mod/registry_name (or if another mod uses your registry: data/their_mod/my_mod/registry_name. To register this registry, subscribe to the DataPackRegistryEvent.NewRegistry event on the MOD event bus and call event.dataPackRegistry() for every registry you have. An example of what I'm doing for my mod (this is in the constructor for the main mod file): IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus(); bus.addListener((DataPackRegistryEvent.NewRegistry event) -> { event.dataPackRegistry(ModRegistries.INSULATOR_DATA, InsulatorData.CODEC); }); CODEC is a public static field inside the class for the custom data type I am registering. It holds a Codec<InsulatorData> that tells Minecraft how to serialize/deserialize the data. Most of my data so far can be represented by records, so I use RecordCodecBuilder.create() to do this: public static final Codec<InsulatorData> CODEC = RecordCodecBuilder.create(instance -> instance.group( // Yadda yadda ).apply(instance, InsulatorData::new)); What exactly to put here depends on what you're trying to do, so that's up to you. But basically you're just defining a list of codecs that correspond to the parameters of the record (data type). Most primitive data types have records in the Codec class (ex. Codec.INT) that you can use, and other classes like ResourceLocation have their own codecs as a static field (ex. ResourceLocation.CODEC). Hopefully this is what you're looking for, and that this helps.
    • Good days  I finnaly manage to fix and get a working gui from BlockItem and from BlockEntity the next issues i have to fix is this the block Entity model for some reason is moved to the south west  this briefcase model must be centered but is moved to a side, i have nothing weird in the code but this is happening // ########## ########## ########## ########## @Override public RenderShape getRenderShape(BlockState blkstate) {     return RenderShape.MODEL; } the block model is out of place However The hitBox of the block is right in place   ########################################################################################################### This next issue  Mi gui also adds the 5 slots from the player equipment the thing is theres no filter to determine whats can be put in an armor slot and what not      i have this method that draws the slots for the armor, the part i dont get i slike wheres the code that responds when you set an item in a item slot to do checks and allow the item to be set or not  //########## ########## ########## //Draw Player Armor private void addPlayerArmorSlots(Inventory playerInventory) { // 36 this.addSlot(new Slot(playerInventory, 39, 8, 8)); this.addSlot(new Slot(playerInventory, 38, 8, 26)); this.addSlot(new Slot(playerInventory, 37, 8, 44)); this.addSlot(new Slot(playerInventory, 36, 8, 62)); this.addSlot(new Slot(playerInventory, 40, 26, 53)); }   theres must be a method that triggers when you set a itemstack inside an slot and allows to do a check if its a valid item for that slot                                             
    • No like how do I use my new PreperableReloadListener, I know how to set it up now and register it, I just need to know how to use it in other classes.
    • Completely out of the blue my forge loader is lagging, although at 120 fps. Like when I turn it lags, or hit mobs it lags, or run sometimes although staying at 120 fps. I found another person having a similar problem:  But there was no solution I dont think. I tried everything from: 1. Updating my computer 2. Updating/reinstalling forge 3. Testing if allocated memory was problem (if it was low or high or mid nothing changed) 4. Adding various performance mods 5. Deleting most of my profiles if storage was a problem.   Really not sure what to do next or if forge is just broken for ever for me now.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.