Jump to content

Recommended Posts

Posted

Hi there! I'm sure this is a noobish question, since I am new with forge, but I want to ask it anyway.

 

I'm updating a mod that integrates the YouTube Live Stream chat into the MC chat to 1.8.9. But after I make the necessary changes, the command won't execute. Not even a usage message (however, I do get one of those in the "mock" command). I'm not seeing anything in the MC client log, nor is it spitting out errors at me in the chat. It's just that nothing happens!

 

Here is my code: https://github.com/PeregrineZ/youtube-chat-for-minecraft/

 

Can anyone kindly explain to me what I've done wrong?

 

Thanks!

Posted

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted
  On 7/8/2017 at 4:47 AM, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

Expand  

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

Posted
  On 7/8/2017 at 4:47 AM, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

Expand  

 

  On 7/8/2017 at 5:54 AM, Irrational said:

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

Expand  

Alright, now I've got another problem. 

 

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

 

Thanks!

Posted
  On 7/8/2017 at 2:56 PM, Irrational said:

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

Expand  

 

The ICommandSender will usually be the client player, but this isn't guaranteed. Mods can execute client commands with their own ICommandSender if they want.

 

The Minecraft#player field contains the current client player.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Add the crash-report or latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
    • I removed yetanotherchance booster and now it says Invalid player identity
    • Cracked Launchers are not supported
    • After some time minecraft crashes with an error. Here is the log https://drive.google.com/file/d/1o-2R6KZaC8sxjtLaw5qj0A-GkG_SuoB5/view?usp=sharing
    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I'm not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.