Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Difference between EntityJoinWorldEvent and LivingSpawnEvent?

salmjak

By salmjak
in Modder Support

 Share

Recommended Posts

salmjak Tree Puncher

salmjak

Posted
Posted (edited)

I have a hard time grasping the difference between these two events (except that EntityJoinWorld probably is called for any entity).

Would Event.Result.DENY in LivingSpawnEvent have the same result as setCancelled(true) in EntityJoinWorldEvent? Is one called after the other? What effect does denying/cancelling have, is one temporary and the other permanent (i.e. is the entity removed and cleared from memory (eventually) in both or only one of them)?

 

EDIT: From what I can gather LivingSpawnEvent is called before EntityJoinWorldEvent, it might even be called before some of the constructors (since some variables were not available in the class I was using in LivingSpawnEvent but were available in EntityJoinWorldEvent, but that's entirely dependent on how the entity-class is built).

Edited by salmjak
Choonster Reality Controller

Choonster

Posted
Posted

LivingSpawnEvent is the parent of several events, don't subscribe to it directly unless you want to receive every child and you don't care which one is which (which usually isn't the case).

 

LivingSpawnEvent.CheckSpawn is only fired for living entities that spawn passively (in WorldEntitySpawner) and for entities that spawn from mob spawners (in MobSpawnerBaseLogic). Setting the result to DENY will prevent the entity from spawning.

 

LivingSpawnEvent.SpecialSpawn is fired just after LivingSpawnEvent.CheckSpawn in the same places. Cancelling it will prevent the entity from spawning.

 

LivingSpawnEvent.AllowDespawn is fired when a living entity is about to despawn, setting the result to DENY will prevent the entity from despawning.

 

EntityJoinWorldEvent is fired when any entity is about to be spawned (regardless of what kind of entity or where it's being spawned from). Cancelling it will prevent the entity from spawning.

 

LivingSpawnEvent.CheckSpawn, LivingSpawnEvent.SpecialSpawn and EntityJoinWorldEvent can all be used to prevent entities from spawning, the difference is which entities the events are fired for and which additional effects will be prevented when you cancel/deny the event. If the entity is covered by the LivingSpawnEvent children, you should prevent the spawn as early as possible (i.e. with LivingSpawnEvent.CheckSpawn) to stop any additional effects related to the spawning from happening.

  • Like 2

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

salmjak Tree Puncher

salmjak

Posted
  • Author
Posted (edited)

Ok, thanks for clarifying! So essentially CheckSpawn is called earlier while entityJoinWorld is called later. Seem like checkspawn was too early in my case (using an API for another mod so don't really have any control over how the entities are constructed/variables instatiated).

Edited by salmjak
Choonster Reality Controller

Choonster

Posted
Posted (edited)
  On 8/8/2017 at 4:27 PM, salmjak said:

Ok, thanks for clarifying! So essentially CheckSpawn is called earlier while entityJoinWorld is called later.

Expand  

 

Yes, the order is CheckSpawn, SpecialSpawn and then EntityJoinWorldEvent.

 

If an entity with a mount or passengers is spawned, CheckSpawn/SpecialSpawn will only be fired for the main entity; but EntityJoinWorldEvent will be fired for every entity.

 

SpecialSpawn is only fired by mob spawners when only the ID of the entity has been specified in the WeightedSpawnerEntity NBT. If the NBT tag has anything except the ID in it, SpecialSpawn won't be fired.

Edited by Choonster
  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Daeruin Diamond Finder

Daeruin

Posted
Posted

 

  On 8/8/2017 at 11:36 AM, Choonster said:

LivingSpawnEvent.CheckSpawn is only fired for living entities that spawn passively (in WorldEntitySpawner) and for entities that spawn from mob spawners (in MobSpawnerBaseLogic).

Expand  

 

What do you mean by "entities that spawn passively"? When I tried using LivingSpawnEvent I found it couldn't detect any mob spawning that I was interested in (passive mobs that spawn when chunks load, hostile mobs that spawn at night).

Choonster Reality Controller

Choonster

Posted
Posted
  On 8/8/2017 at 9:23 PM, Daeruin said:

What do you mean by "entities that spawn passively"? When I tried using LivingSpawnEvent I found it couldn't detect any mob spawning that I was interested in (passive mobs that spawn when chunks load, hostile mobs that spawn at night).

Expand  

 

Anything spawned by WorldEntitySpawner#findChunksForSpawning.

 

This includes any passive or hostile entities spawned in the chunks surrounding players, but not entities spawned in a newly-generated chunk.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      mouseclicked event handler

      By TileEntity · Posted

      You are using Create 6 - some addons are not compatible with it Remove all addons and add these one by one littlecontraptions is mentioned - keep this one removed
    • graciegreen123
      HORROR

      By graciegreen123 · Posted

      HEY
    • violetrose334
      i really need help and i dont know why my game is crashing and i dont want my singleplayer to be deleted

      By violetrose334 · Posted

      omg THANKK U yeah these two was the issues thank u
    • Crossback
      mouseclicked event handler

      By Crossback · Posted

      Different problem now. https://paste.ee/p/iDo8lS35
    • NightAnasazi
      LootItemCondition (when mod is loaded) - showing error "Couldn't parse element"

      By NightAnasazi · Posted

      I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept