Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.12] Give potion effect to looking entity

JimiIT92

By JimiIT92
in Modder Support

 Share

Recommended Posts

JimiIT92 Dragon Slayer

JimiIT92

Posted
Posted

I'm trying to create a wand that when right clicked will give a potion effect to the entity the player is looking at. But for some reason the effect is not applied :/ Here's the code i'm using right now

 
	package com.mw.items;
	import com.mw.MW;
import com.mw.core.MWTabs;
import com.mw.utils.EnumWands;
import com.mw.utils.Utils;
	import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.MobEffects;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.SoundCategory;
import net.minecraft.world.World;
	public class ItemWand extends Item{
	    private EnumWands type;
    
    public ItemWand(EnumWands typeIn) {
        this.setCreativeTab(MWTabs.TOOLS);
        this.maxStackSize = 1;
        this.setMaxDamage(256);
        this.type = typeIn;
    }
    
    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
        if(!worldIn.isRemote) {
            if(this.type == EnumWands.CORRUPTER || this.type == EnumWands.HEALER) {
                Entity pointed = Utils.getLookingEntity();
                if(pointed != null && pointed instanceof EntityLiving) {
                    Potion potion;
                    int effect = MW.RANDOM.nextInt(5);
                    if(this.type == EnumWands.CORRUPTER) {
                        switch(effect) {
                        case 0:
                        default:
                            potion = MobEffects.POISON;
                            break;
                        case 1:
                            potion = MobEffects.BLINDNESS;
                            break;
                        case 2:
                            potion = MobEffects.LEVITATION;
                            break;
                        case 3:
                            potion = MobEffects.SLOWNESS;
                            break;
                        case 4:
                            potion = MobEffects.WEAKNESS;
                            break;
                        }
                        worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, SoundEvents.ENTITY_ENDERMITE_AMBIENT, SoundCategory.NEUTRAL, 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
                        
                    } else {
                        switch(effect) {
                        case 0:
                        default:
                            potion = MobEffects.REGENERATION;
                            break;
                        case 1:
                            potion = MobEffects.RESISTANCE;
                            break;
                        case 2:
                            potion = MobEffects.ABSORPTION;
                            break;
                        case 3:
                            potion = MobEffects.INSTANT_HEALTH;
                            break;
                        case 4:
                            potion = MobEffects.STRENGTH;
                            break;
                        }
                        worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, SoundEvents.ENTITY_PLAYER_LEVELUP, SoundCategory.NEUTRAL, 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
                    }
                    
                    ((EntityLiving)pointed).addPotionEffect(new PotionEffect(potion, 30 * 20));
                    
                    ItemStack itemstack = playerIn.getHeldItem(handIn);
	                    if (!playerIn.capabilities.isCreativeMode)
                    {
                        itemstack.damageItem(1, playerIn);
                    }
                    
                    Utils.setCooldown(playerIn, this, 3);
                }
            }
            
        }
        return super.onItemRightClick(worldIn, playerIn, handIn);
    }
}


I'm sure the code got called because the wand goes in cooldown and the sound is played, it's just the effect doesn't apply to the mob (and both effect and entity are corrects). How can i fix this? :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

  • 1 month later...
JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Any suggest? :( If i try to do other things, like change the position of the looked entity or if i give the effect to the player it works, just giving the effect to the entity doesn't :/

Don't blame me if i always ask for your help. I just want to learn to be better :)

oldcheese Creeper Killer

oldcheese

Posted
Posted (edited)

Are you sure you're getting the right Entity? It seems like trying to get the mob you're looking at on the server side is a bit of a stretch.

 

Rather than that I'd try to get an Minecraft.getMinecraft().objectMouseOver which is a raytraceresult. Then use a packet to tell your server to add a potion effect to it. That seems like a more reasonable and foolproof idea, since the server doesn't know your exact position at all times, it just updates it with a client package every x ticks. 

 

I'm not an expert, but that's what I'd attempt. hopefully that can get you going.

 

Edit: If you're sure this should work, the least you can do is implement a System.out.Println Message with the entity and the effect, just so you can be sure that whatever you think should happen is occuring.

Edited by oldcheese
JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

@oldcheese If it can help, this is the cod ei'm using to get the entity the player is looking at

 
	Entity entity = Minecraft.getMinecraft().getRenderViewEntity();
        Entity pointedEntity = null;
        if (entity != null)
        {
            if (Minecraft.getMinecraft().world != null)
            {
                Minecraft.getMinecraft().mcProfiler.startSection("pick");
                Minecraft.getMinecraft().pointedEntity = null;
                double d0 = (double)Minecraft.getMinecraft().playerController.getBlockReachDistance() * 2;
                Minecraft.getMinecraft().objectMouseOver = entity.rayTrace(d0, 20);
                Vec3d vec3d = entity.getPositionEyes(20);
                boolean flag = false;
                int i = 3;
                double d1 = d0;
	                if (Minecraft.getMinecraft().playerController.extendedReach())
                {
                    //d1 = 6.0D;
                    d1 = 14.0D;
                    d0 = d1;
                }
                else
                {
                    if (d0 > 3.0D)
                    {
                        flag = true;
                    }
                }
	                if (Minecraft.getMinecraft().objectMouseOver != null)
                {
                    d1 = Minecraft.getMinecraft().objectMouseOver.hitVec.distanceTo(vec3d);
                }
	                Vec3d vec3d1 = entity.getLook(1.0F);
                Vec3d vec3d2 = vec3d.addVector(vec3d1.x * d0, vec3d1.y * d0, vec3d1.z * d0);
                pointedEntity = null;
                Vec3d vec3d3 = null;
                float f = 1.0F;
                List<Entity> list = Minecraft.getMinecraft().world.getEntitiesInAABBexcluding(entity, entity.getEntityBoundingBox().expand(vec3d1.x * d0, vec3d1.y * d0, vec3d1.z * d0).grow(1.0D, 1.0D, 1.0D), Predicates.and(EntitySelectors.NOT_SPECTATING, new Predicate<Entity>()
                {
                    public boolean apply(@Nullable Entity p_apply_1_)
                    {
                        return p_apply_1_ != null && p_apply_1_.canBeCollidedWith();
                    }
                }));
                double d2 = d1;
	                for (int j = 0; j < list.size(); ++j)
                {
                    Entity entity1 = list.get(j);
                    AxisAlignedBB axisalignedbb = entity1.getEntityBoundingBox().grow((double)entity1.getCollisionBorderSize());
                    RayTraceResult raytraceresult = axisalignedbb.calculateIntercept(vec3d, vec3d2);
	                    if (axisalignedbb.contains(vec3d))
                    {
                        if (d2 >= 0.0D)
                        {
                            pointedEntity = entity1;
                            vec3d3 = raytraceresult == null ? vec3d : raytraceresult.hitVec;
                            d2 = 0.0D;
                        }
                    }
                    else if (raytraceresult != null)
                    {
                        double d3 = vec3d.distanceTo(raytraceresult.hitVec);
	                        if (d3 < d2 || d2 == 0.0D)
                        {
                            if (entity1.getLowestRidingEntity() == entity.getLowestRidingEntity() && !entity1.canRiderInteract())
                            {
                                if (d2 == 0.0D)
                                {
                                    pointedEntity = entity1;
                                    vec3d3 = raytraceresult.hitVec;
                                }
                            }
                            else
                            {
                                pointedEntity = entity1;
                                vec3d3 = raytraceresult.hitVec;
                                d2 = d3;
                            }
                        }
                    }
                }
	                if (pointedEntity != null && flag && vec3d.distanceTo(vec3d3) > 3.0D)
                {
                    pointedEntity = null;
                    Minecraft.getMinecraft().objectMouseOver = new RayTraceResult(RayTraceResult.Type.MISS, vec3d3, (EnumFacing)null, new BlockPos(vec3d3));
                }
	                if (pointedEntity != null && (d2 < d1 || Minecraft.getMinecraft().objectMouseOver == null))
                {
                    Minecraft.getMinecraft().objectMouseOver = new RayTraceResult(pointedEntity, vec3d3);
	                    if (pointedEntity instanceof EntityLivingBase || pointedEntity instanceof EntityItemFrame)
                    {
                        Minecraft.getMinecraft().pointedEntity = pointedEntity;
                    }
                }
	                Minecraft.getMinecraft().mcProfiler.endSection();
            }
        }
        return pointedEntity;


I've already tried to see if the entity i'm looking is correct by printing the entity's class and the effect choosen and both works as well (if i point a Cow it prints EntityCow). I will try to see if using packets will solve the problem :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

You mean the getLookingEntity code? If yes than i guess i should get that entity trhough a packet and not through a static method, right?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Ugdhar
      Help me with registries

      By Ugdhar · Posted

      When you name a method like that, with no return value, it is a constructor. The constructor must have the same name as the class it constructs, in this case, ModItems. I would strongly advise reading up on some basic Java tutorials, because you will definitely be running into a lot more issues as you go along without the basics. *I should also add that the Forge documentation is a reference, not a tutorial. Even following tutorials, you should know Java basics, otherwise the smallest of mistakes will trip you up as you copy someone elses code.
    • quase
      Help me with registries

      By quase · Posted

      so, I'm starting modding and I'm following the official documantation for forge: https://docs.minecraftforge.net, but in the registries part it is not working as it is in the docs:   public class ModItems { private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, DarkStarvation.MOD_ID); public static final RegistryObject<Item> TEST_ITEM = ITEMS.register("test_item", () -> new Item(new Item.Properties())); public DarkStarvation(FMLJavaModLoadingContext context) { ITEMS.register(context.getModEventBus()); } } in 'public DarkStarvation(...' the DarkStarvation has this error: Invalid method declaration; return type required and the getModEventBus(): Cannot resolve method 'getModEventBus' in 'FMLJavaModLoadingContext' please help, I asked gpt but it is saying that I'm using an old method, but I'm following the latest version of Forge Docs???
    • Ugdhar
      Reply to my question please

      By Ugdhar · Posted

      I merged your second post with the original , there is no need to post a new thread asking for an answer. If someone sees your post and can help, they will reply. If you are seeking a quicker response, you could try asking in the Minecraft Forge diacord.
    • TileEntity
      Cobblemon modpack keeps crashing idk why

      By TileEntity · Posted

      Create a new instance and start with cobblemon - if this works, add the rest of your mods in groups   Maybe another mod is conflicting - like Sodium/Iris or Radical Cobblemon Trainers
    • Loghan
      Reply to my question please

      By Loghan · Posted

      https://forums.minecraftforge.net/topic/157393-1201-forge-rocket-flame-particle-trail-moves-up-and-crashes-into-the-rocket-during-flight/#comment-584134

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept