OsHeaven Posted October 3, 2017 Posted October 3, 2017 i am creating a mod to generate all the ores... so i need to change the behavior of the vanilla ones or replace these with my own ones... for example the ore should drop cobble and nuggets, thats not the problem, the prob is, i cant prevent the ores of gold and iron to drop (this) (thats should only done with silktouch)... how can i override the setItemDropped method in Block.class or replace Item.getItemFromBlock(this) with Item.getItemFromBlock(Blocks.COBBLESTONE) without changing the original class? if this isnt possible, how can i replace the vanilla ores with custom ores, at the moment i am searching for a way to remove vanilla ores from the block registry... but all i find is outdated... thanks for any help Quote
Choonster Posted October 3, 2017 Posted October 3, 2017 Removing blocks from the registry isn't possible. It is possible to override registry entries with your own, but that should be avoided where possible because it can cause compatibility issues if multiple mods try to override the same entry. Instead, you should subscribe to HarvestDropsEvent and add items to/remove items from the drops list as needed. Quote Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.
OsHeaven Posted October 3, 2017 Author Posted October 3, 2017 ok, thanks, I thought the method getItemDropped() in Block.class is not affected by HarvestDropsEvent Quote if (event.getState() == Blocks.GOLD_ORE.getDefaultState()) { event.getDrops().clear(); event.getDrops().add(new ItemStack(Items.GOLD_NUGGET, amount_nuggets)); } works fine... Quote
jabelar Posted October 3, 2017 Posted October 3, 2017 Are you sure? I think the event returns all the drops and you can fully replace it if you want. Quote Check out my tutorials here: http://jabelarminecraft.blogspot.com/
OsHeaven Posted October 3, 2017 Author Posted October 3, 2017 i am sure... ok i am using Quote if (event.getState() == Blocks.GOLD_ORE.getDefaultState()) { event.getDrops().clear(); if (event.isSilkTouching()) event.getDrops().add(new ItemStack(Item.getItemFromBlock(Blocks.GOLD_ORE), 1)); else { event.getDrops().add(new ItemStack(Item.getItemFromBlock(Blocks.COBBLESTONE), 1)); event.getDrops().add(new ItemStack(Items.GOLD_NUGGET, amount_nuggets)); } } but it does exactly what it is supposed to do for this block... or what do you mean? Quote
jabelar Posted October 4, 2017 Posted October 4, 2017 What is going wrong exactly? You should check that your code is actually executing by either setting a breakpoint and running in debug mode or putting a console print statement inside the if statement. Assuming that it does run, then it should work. If you look at the call hierarchy for the HarvestDropsEvent, it is called by the fireHarvestDrops() which is called either by harvest methods or the drop with chance methods. The harvest methods will either do some silk touch drops or will call the drop with chance methods. In all cases, the actual item entities creates are directly from the drops list. Quote Check out my tutorials here: http://jabelarminecraft.blogspot.com/
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.