Jump to content

[1.11.2] [SOLVED] TileEntity null while it shouldn't


Bektor

Recommended Posts

Hi,

 

I've got the following problem:

 

	protected boolean canCableConnect(IBlockAccess worldIn, BlockPos pos, EnumFacing facing) {
	    // 188 72 265
	    BlockPos posi = pos.offset(facing); // correct
	    TileEntity tile = worldIn.getTileEntity(posi); // correct
	    if(tile != null) // why null????
	        return EnergyUtils.hasCapability(tile, facing.getOpposite());
	    
	    return false;
	}

(debugging got me to the point that I can write the comments behind the line of code)

 

The method is called in 

public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {

.

 

My problem here is that the tile is null while it shouldn't be null. I checked the positions and the positions match perfectly the one of my transfer pipe.

 

public class BlockTransfer extends Block {
    @Override
    public boolean hasTileEntity() {
        return true;
    }
    
    @Override
    public TileEntity createTileEntity(World world, IBlockState state) {
        return new TileEntityPipeTransferEnergy();
    }
}

 

Why is my method's tile null when my BlockTransfer has a tile entity?

 

Note: the canCableConnect method checks to which blocks the cable can connect to in order to display the correct block state (connected to south, not connected, etc.).

 

Thx in advance.

Bektor

 

EDIT:

public class BlockTransfer extends Block {
    @Override
    public boolean hasTileEntity(IBlockState state) {
        return true;
    }
    
    @Override
    public TileEntity createTileEntity(World world, IBlockState state) {
        return new TileEntityPipeTransferEnergy();
    }
}

 

Edited by Bektor
update code

Developer of Primeval Forest.

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

Please verify using World::getBlockState that the block actually exists at the position.

It exists. 

	    IBlockState state = worldIn.getBlockState(posi);
	    
	    TileEntity tile = worldIn.getTileEntity(posi);
	    if(tile != null)
	        return EnergyUtils.hasCapability(tile, facing.getOpposite());

Output using debugger:
state	BlockStateContainer$StateImplementation  (id=15672)	   justanotherenergy:transfer

tile    null

 

Developer of Primeval Forest.

Link to comment
Share on other sites

Just now, diesieben07 said:

Post updated code, ideally the whole block class.

public class BlockTransfer extends Block {
    
    public BlockTransfer() {
        super(Material.ROCK);
        this.setCreativeTab(ModCreativeTabs.mcpowerTab);
    }
    
    @Override
    public void onNeighborChange(IBlockAccess world, BlockPos pos, BlockPos neighbor) {
    	super.onNeighborChange(world, pos, neighbor);
    	
    	// World implements IBlockAccess
    	if(((World)world).isRemote)
    	    return;
    	
    	// add direct connections to the tile entity
    	TileEntity tile = world.getTileEntity(pos);
    	if(tile instanceof TileEntityPipeTransferEnergy) {
    		TileEntityPipeTransferEnergy pipe = (TileEntityPipeTransferEnergy) tile;
    		
    		if(world.getTileEntity(neighbor) != null) {
    			// check for all directions
    			TileEntity neighbor_te = world.getTileEntity(neighbor);
    			if(neighbor_te instanceof TileEntityEnergy)
    			    pipe.shouldRecalculate = true;
    			else {
    			    // check the facing of the block to make sure which side is connected to us
    			    for(EnumFacing face : EnumFacing.VALUES) {
    			        BlockPos offset = pos.offset(face);
    			        if(offset == neighbor) {
    			            if(EnergyUtils.hasCapability(neighbor_te, face))
    			                pipe.shouldRecalculate = true;
    			        }
    			    }
    			}
    		} else {
    			// remove dead objects from the list
    			pipe.shouldRecalculate = true;
    		}
    	}
    }
    
    @Override
    public boolean hasTileEntity(IBlockState state) {
        return true;
    }
    
    @Override
    public TileEntity createTileEntity(World world, IBlockState state) {
        return new TileEntityPipeTransferEnergy();
    }
}
public class BlockCable extends BlockConnectorBase {
    
	[...]
	
	public BlockCable() {
		super(Material.IRON);
		this.setHardness(.25f);
		this.setResistance(3f);
		
		this.setCreativeTab(ModCreativeTabs.mcpowerTab);
	}
	
	@Override
	protected boolean canCableConnect(IBlockAccess worldIn, BlockPos pos, EnumFacing facing) {
	    // 188 72 265
	    BlockPos posi = pos.offset(facing);
	    
	    IBlockState state = worldIn.getBlockState(posi);
	    
	    TileEntity tile = worldIn.getTileEntity(posi);
	    if(tile != null)
	        return EnergyUtils.hasCapability(tile, facing.getOpposite());
	    
	    return false;
	}
	
	@Override
	public void onBlockAdded(World worldIn, BlockPos pos, IBlockState state) {
	    super.onBlockAdded(worldIn, pos, state);
	    
	    TileEntity tile = worldIn.getTileEntity(pos);
	    if(tile != null && tile instanceof TileEntityPipeEnergy) {
	        TileEntityPipeEnergy cable = (TileEntityPipeEnergy) tile;
	        cable.searchNetwork();
	    }
	}
	
	@Override
	public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
       TileEntity tile = worldIn.getTileEntity(pos);
        if(tile != null && tile instanceof TileEntityPipeEnergy) {
            TileEntityPipeEnergy cable = (TileEntityPipeEnergy) tile;
            cable.searchNetwork();
        }
        
        super.breakBlock(worldIn, pos, state);
	}
	
	@Override
    public IBlockState getActualState(IBlockState state, IBlockAccess worldIn, BlockPos pos) {
        for(final EnumFacing facing : EnumFacing.VALUES)
            state = state.withProperty(CONNECTED.get(facing.getIndex()), this.canCableConnect(worldIn, pos, facing));
        
        return state;
    }
	
	[...] (Collision box related stuff)
	
	    @Override
    protected BlockStateContainer createBlockState() {
        return new BlockStateContainer(this, CONNECTED.toArray(new IProperty[CONNECTED.size()]));
    }
    
    @Override
    public int getMetaFromState(IBlockState state) {
        return 0;
    }
    
    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState();
    }
	
    @Override
    public boolean hasTileEntity(IBlockState state) {
        return true;
    }
	
	@Override
	public TileEntity createTileEntity(World world, IBlockState state) {
	    return new TileEntityPipeEnergy();
	}
}

 

Developer of Primeval Forest.

Link to comment
Share on other sites

I also have this kind of problem. I do null check in my getActualBlock state. I think possible reason can be, sometimes the IBlockState passed into getActualBlock() can be implemented by a ChunkCache, and the TileEntity doesn't exist in it yet.

My mod: SimElectricity - High Voltages, Electrical Power Transmission & Distribution

https://github.com/RoyalAliceAcademyOfSciences/SimElectricity

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.