Kporal Posted December 6, 2017 Posted December 6, 2017 I've made a custom dimension, but rather than using a chunk generator, my own is just a "copy" of the overworld and i want replace some blocks by other. So i need to get a list of all block on the chunk and replacing them by the wanted block or remove them, but i don't know how to get a list of block in the chunk, maybe this way is just impossible ? Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 I'm doing something like this, doesn't test it yet but i think i'm on the right way : package com.kporal.lau.events; import java.util.Map; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.math.BlockPos; import net.minecraft.world.chunk.Chunk; import net.minecraftforge.event.world.ChunkEvent.Load; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; public class OnChunkEvent { @SubscribeEvent public void EditChunk( Load e ) { Chunk c = e.getChunk(); Map<BlockPos, TileEntity> map = c.getTileEntityMap(); for( BlockPos p : map.keySet() ) { c.removeTileEntity( p ); } } } removeTileEntity may remove my desired block ? then i should replace a new block at the position, or i need to use setBlockState ? Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Ok, my custom dimension is a mimic of the overworld, it work, i can teleport, spawn etc, but now, because i don't use a custom chunk generator i try to use the chunk Load event to replace undesired block by other, my actual code is more like : package com.kporal.lau.events; import java.util.Map; import net.minecraft.init.Blocks; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.math.BlockPos; import net.minecraft.world.chunk.Chunk; import net.minecraftforge.event.world.ChunkEvent.Load; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; public class OnChunkEvent { @SubscribeEvent public void EditChunk( Load e ) { Chunk c = e.getChunk(); Map<BlockPos, TileEntity> map = c.getTileEntityMap(); for( BlockPos p : map.keySet() ) { if( c.getBlockState( p ).getBlock() == Blocks.DIRT ) { c.removeTileEntity( p ); //c.addTileEntity( p, ); } } } } it's just an exemple for dirt block, but when i'm doing a better job here i'm gonna use some array, i hope to give you suffisant information ( sorry if my english is bad ) Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 my explanation isn't good, it's not a mimic, the "erzine" ( my custom one ) doens't mimic stuff from the overworld, it was just generated with the same seed, but totally separate dimension. Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Actually my code is : package com.kporal.lau.events; import java.util.Map; import com.kporal.lau.LAU; import net.minecraft.block.Block; import net.minecraft.block.BlockSand; import net.minecraft.block.BlockStaticLiquid; import net.minecraft.init.Blocks; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.math.BlockPos; import net.minecraft.world.World; import net.minecraft.world.chunk.Chunk; import net.minecraftforge.event.world.ChunkEvent.Load; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; public class OnChunkEvent { //private final Block[] toNetherrack = { Blocks.SAND }; //private final Blocks[] toLava = { Blocks.WATER }; @SubscribeEvent public void EditChunk( Load e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.erzineId ) { Chunk c = e.getChunk(); Map<BlockPos, TileEntity> map = c.getTileEntityMap(); for( BlockPos p : map.keySet() ) { Block b = c.getBlockState( p ).getBlock(); /*if( ArrayUtils.contains( toNetherrack, c.getBlockState( p ).getBlock() )) { c.removeTileEntity( p ); }*/ if( b instanceof BlockSand ) { // Convert to soulsand c.removeTileEntity( p ); c.setBlockState( p, Blocks.SOUL_SAND.getDefaultState() ); } if( b instanceof BlockStaticLiquid ) { // Convert to lava c.removeTileEntity( p ); c.setBlockState( p, Blocks.LAVA.getDefaultState() ); } } } } } But it doesn't work, i mean nothing happen, i register the event on the FMLInit @EventHandler public void Init( FMLInitializationEvent e ) { MinecraftForge.EVENT_BUS.register( new OnChunkEvent() ); } But i have no error at all, so i know i'm wrong because nothing happen, but i don't know where i'm wrong Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Ok so finally i check ... nothing so this is why nothing is replace ... theire is a way to get all chunk block directly ? or i need to use a for <<4 loop ? Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Yes, i've made some test and i think i've found a way to ensure the game do not load heavily by using nbttag when a chunk is converted, may work but for now my "converter" work ( and like you said it's pretty laggy but not everywhere almost at the first generation ). So i need to know if i can use nbttag into chunk, maybe not but in world should be better by saving something like that : chunk_0_-1_0 as id with isConverted to avoid a second convertion. But in case of needed, i'm also gonna make an admin command to re convert a chunk ! And my last possibility but actually ... i think it don't work ... changing the height of the map ... because i don't need 256 but ... should be better with 96 height trying to do it with : ErzineProvider.class package com.kporal.lau.dimensions; import com.kporal.lau.LAU; import net.minecraft.init.Biomes; import net.minecraft.util.math.BlockPos; import net.minecraft.util.math.Vec3d; import net.minecraft.world.DimensionType; import net.minecraft.world.World; import net.minecraft.world.WorldProvider; import net.minecraft.world.biome.Biome; import net.minecraft.world.biome.BiomeProviderSingle; import net.minecraftforge.fml.relauncher.Side; import net.minecraftforge.fml.relauncher.SideOnly; public class ErzineProvider extends WorldProvider { public World worldObj; public void registerWorldChunkManager() { this.biomeProvider = new BiomeProviderSingle( Biomes.VOID ); this.setDimension( LAU.erzineId ); this.setAllowedSpawnTypes( false, false ); this.hasNoSky = false; this.doesWaterVaporize = true; } public Biome getBiomeGenForCoords( BlockPos pos ) { return Biomes.VOID; } @Override public boolean canRespawnHere() { return false; } @Override public boolean isSurfaceWorld() { return false; } @Override public DimensionType getDimensionType() { return LAU.ERZINE_DIMENSION; } @Override public float calculateCelestialAngle( long worldTime, float partialTicks ) { return 0.0F; } @Override @SideOnly( Side.CLIENT ) public float[] calcSunriseSunsetColors( float celestialAngle, float partialTicks ) { return null; } @Override @SideOnly( Side.CLIENT ) public Vec3d getFogColor( float p_76562_1_, float p_76562_2_ ) { return new Vec3d(0.20000000298023224D, 0.029999999329447746D, 0.029999999329447746D); } @Override @SideOnly( Side.CLIENT ) public float getCloudHeight() { return 12.0F; } @SideOnly( Side.CLIENT ) public boolean doesXZShowFog( int x, int z ) { return true; } @Override public int getHeight() { return 96; } @Override public int getActualHeight() { return 96; } } But ... because my "Erzine" dimension is a "copy" of the overworld it's doesn't work ( i need to check something ... ). Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Ok it work really fine with nbt package com.kporal.lau.events; import com.kporal.lau.LAU; import net.minecraft.block.Block; import net.minecraft.block.BlockDirt; import net.minecraft.block.BlockFalling; import net.minecraft.block.BlockLiquid; import net.minecraft.block.BlockOre; import net.minecraft.block.BlockSandStone; import net.minecraft.block.BlockStone; import net.minecraft.init.Blocks; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.util.math.BlockPos; import net.minecraft.world.World; import net.minecraft.world.chunk.Chunk; import net.minecraftforge.event.world.ChunkEvent; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; public class OnChunkEvent { //private final Block[] toNetherrack = { Blocks.SAND }; //private final Block[] toEndstone = { Blocks.END_STONE }; //private final Block[] toDestroy = { Blocks.OAK_STAIRS }; @SubscribeEvent public void EditChunk( ChunkEvent.Load e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { NBTTagCompound nbt = w.getWorldInfo().getDimensionData( LAU.ERZINEID ); Chunk c = e.getChunk(); String chunkid = "erzineChunk:" + c.xPosition + "_" + c.zPosition; if( nbt.hasKey( chunkid ) ) { return; } int cx = c.xPosition << 4; int cy = w.getHeight(); int cz = c.zPosition << 4; for( int x = cx - 16; x < cx; x++ ) { for( int y = 0; y < cy; y++ ) { for( int z = cz - 16; z < cz; z++ ) { BlockPos p = new BlockPos( x, y, z ); Block b = c.getBlockState( p ).getBlock(); if( b instanceof BlockFalling && b != Blocks.SOUL_SAND ) { c.setBlockState( p, Blocks.SOUL_SAND.getDefaultState() ); } if( b instanceof BlockLiquid && b != Blocks.LAVA ) { c.setBlockState( p, Blocks.LAVA.getDefaultState() ); } if(( b instanceof BlockOre || b instanceof BlockStone || b instanceof BlockSandStone ) && b != Blocks.END_STONE ) { c.setBlockState( p, Blocks.END_STONE.getDefaultState() ); } if( b instanceof BlockDirt && b != Blocks.NETHERRACK ) { c.setBlockState( p, Blocks.NETHERRACK.getDefaultState() ); } //w.destroyBlock( p, false ); } } } nbt.setBoolean( chunkid, true ); w.getWorldInfo().setDimensionData( LAU.ERZINEID, nbt ); } } } And now i need to clean up entity spawn, and decorate event, if i'm right tree is on the decorate event ? I also need to clear every structure ( with event too ... to prevent them to spawn ) Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Like you can see ... it's not yet fully operational i need to work deeper into it Reveal hidden contents Quote
Kporal Posted December 6, 2017 Author Posted December 6, 2017 Now i'm here : ErzineConverter.class Reveal hidden contents package com.kporal.lau.events; import com.kporal.lau.LAU; import net.minecraft.block.Block; import net.minecraft.block.BlockDirt; import net.minecraft.block.BlockFalling; import net.minecraft.block.BlockLiquid; import net.minecraft.block.BlockOre; import net.minecraft.block.BlockSandStone; import net.minecraft.block.BlockStone; import net.minecraft.init.Blocks; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.util.math.BlockPos; import net.minecraft.world.World; import net.minecraft.world.chunk.Chunk; import net.minecraftforge.event.entity.living.LivingSpawnEvent; import net.minecraftforge.event.terraingen.DecorateBiomeEvent; import net.minecraftforge.event.terraingen.PopulateChunkEvent; import net.minecraftforge.event.world.ChunkEvent; import net.minecraftforge.fml.common.eventhandler.Event.Result; import net.minecraftforge.fml.common.eventhandler.EventPriority; import net.minecraftforge.fml.common.eventhandler.SubscribeEvent; public class ErzineConverter { @SubscribeEvent( priority = EventPriority.HIGH ) public void EditChunk( ChunkEvent.Load e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { NBTTagCompound nbt = w.getWorldInfo().getDimensionData( LAU.ERZINEID ); Chunk c = e.getChunk(); String chunkid = "erzineChunk:" + c.xPosition + "_" + c.zPosition; if( nbt.hasKey( chunkid ) ) { return; } int cx = c.xPosition << 4; int cy = w.getHeight(); int cz = c.zPosition << 4; for( int x = cx - 16; x < cx; x++ ) { for( int y = 0; y < cy; y++ ) { for( int z = cz - 16; z < cz; z++ ) { BlockPos p = new BlockPos( x, y, z ); Block b = c.getBlockState( p ).getBlock(); // Removing unwanted liquids if( b instanceof BlockLiquid && b != Blocks.LAVA ) { c.setBlockState( p, Blocks.LAVA.getDefaultState() ); } // Converting sand and gravel if( b instanceof BlockFalling ) { c.setBlockState( p, Blocks.SOUL_SAND.getDefaultState() ); } // Converting "stones" if( b instanceof BlockOre || b instanceof BlockStone || b instanceof BlockSandStone ) { c.setBlockState( p, Blocks.END_STONE.getDefaultState() ); } // Populating netherack if( b instanceof BlockDirt || b == Blocks.GRASS || b == Blocks.GRASS_PATH ) { c.setBlockState( p, Blocks.NETHERRACK.getDefaultState() ); } // Finishing by cleaning every unwanted blocks /*if( b != Blocks.LAVA && b != Blocks.SOUL_SAND && b != Blocks.END_STONE && b != Blocks.NETHERRACK && b != Blocks.AIR && b != Blocks.BEDROCK ) { w.destroyBlock( p, false ); }*/ } } } nbt.setBoolean( chunkid, true ); w.getWorldInfo().setDimensionData( LAU.ERZINEID, nbt ); } } @SubscribeEvent( priority = EventPriority.HIGHEST ) public void DecoPre( DecorateBiomeEvent.Pre e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { if( e.isCancelable() ) e.setCanceled( true ); if( e.hasResult() ) e.setResult( Result.DENY ); } } @SubscribeEvent( priority = EventPriority.HIGHEST ) public void DecorateBiome( DecorateBiomeEvent.Decorate e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { if( e.isCancelable() ) e.setCanceled( true ); if( e.hasResult() ) e.setResult( Result.DENY ); } } @SubscribeEvent( priority = EventPriority.HIGHEST ) public void PopulateChunk( PopulateChunkEvent.Populate e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { if( e.isCancelable() ) e.setCanceled( true ); if( e.hasResult() ) e.setResult( Result.DENY ); } } @SubscribeEvent public void LivingSpawn( LivingSpawnEvent e ) { World w = e.getWorld(); if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) { if( e.isCancelable() ) e.setCanceled( true ); if( e.hasResult() ) e.setResult( Result.DENY ); } } } Yes i use DecorateBiomeEvent Pre and Decorate ( i've made this for testing purpose ) but, i'm in trouble, my main event for replacing block do not clear everything, sometime some flower, grass or tree is populated on my world and i don't know how to canceled that or maybe by doing a second loop ... But first, my first problem here is at the bottom, LivingSpawn, i don't understand why this not work, i've made this to prevent creature to spawn but ... i also use this on my world provider : this.setAllowedSpawnTypes( false, false ); ... And why some tree / flower / water keep on the world ... i'm trying a lot of thing but nothing seem to really clear the world Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.