Setting Block texture in Inventory (ItemBlock)

[Big_Bad_E]

So, I ran into some trouble getting a texture/model onto an ItemBlock.

What I have right now:

// Registering the Block's model
final Block saltore = new SaltOre(Material.ROCK);
ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(saltore), 0, new ModelResourceLocation(saltore.getRegistryName(), "normal"));
// Registering the ItemBlock's model
final ItemBlock saltoreitem = new SaltOreItem(saltore);
ModelLoader.setCustomModelResourceLocation(saltoreitem, 0, new ModelResourceLocation(saltore.getRegistryName(), "inventory"));

I am trying to make one BlockState, one Item model, and one Block model.

BlockState (I don't know how to do this so help is appreciated):

 

"variants": {
        "normal": { "model": "culinarycraft:salt_ore" }
        "inventory": { "model": "culinarycraft:salt_ore" }
    }

Item Model:

{
    "parent": "culinarycraft:block/salt_ore",
    "display": {
        "thirdperson": {
            "rotation": [ 10, -45, 170 ],
            "translation": [ 0, 1.5, -2.75 ],
            "scale": [ 0.375, 0.375, 0.375 ]
        }
    }
}

Block Model:

{
    "parent": "block/cube_all",
    "textures": {
        "all": "culinarycraft:blocks/salt_ore"
    }
}

I looked at vanilla .Json's but I don't know, I've messed around with many things but can't manage to figure out how to make it work correctly.

Any help is appreciated.

[Big_Bad_E]

Bump, still can't find my problem sadly ;-;

[Terrails]

The

ModelLoader 

should go into a

ModelRegistryEvent

to register an event make the event method static and add 

@Mod.EventBusSubscriber

annotation to the class or don't make it static and register it in your preInit with 

MinecraftForge.EVENT_BUS.register(Object theClassContainingTheEvent)

 

[Big_Bad_E]

9 hours ago, Terrails said:

The

ModelLoader 

should go into a

ModelRegistryEvent

to register an event make the event method static and add 

@Mod.EventBusSubscriber

annotation to the class or don't make it static and register it in your preInit with 

MinecraftForge.EVENT_BUS.register(Object theClassContainingTheEvent)

 

Yep, forgot to say I subscribed to ModelRegistryEvent and annotated the class with EventBusSubscriber. My problem is not setting the block's texture, that works perfectly, but the ItemBlock. I cannot find a place where that is shown. P.S. I made a class for the block's ItemBlock because if I just made a new ItemBlock I couldn't set the registry name.

[Big_Bad_E]

I'm just using the console errors to find my problems.

[Big_Bad_E]

I don't know I am getting errors I just can't solve.

My Registry Class:

@EventBusSubscriber
public class ModelRegistry {
	@SubscribeEvent
    public static void registerModels(ModelRegistryEvent event) {
		final Block saltore = new SaltOre(Material.ROCK);
    	ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(saltore), 0, new ModelResourceLocation(saltore.getRegistryName(), "normal"));
    	final Item saltoreitem = new ItemBlock(saltore).setRegistryName("culinarycraft:salt_ore");
    	ModelLoader.setCustomModelResourceLocation(saltoreitem, 0, new ModelResourceLocation(saltore.getRegistryName(), "inventory"));
	}
}

My Registry Class:

@EventBusSubscriber
public class BlockRegistry {
	public static final Block saltore = new SaltOre(Material.ROCK);
	
	public static final Item saltoreitem = new ItemBlock(saltore).setRegistryName("culinarycraft:salt_ore");
	
	@SubscribeEvent
	public static void registerBlocks(RegistryEvent.Register<Block> event) {
	    event.getRegistry().registerAll(saltore);
	}
	
	@SubscribeEvent
	public static void registerBlockItems(RegistryEvent.Register<Item> event) {
	    event.getRegistry().registerAll(saltoreitem);
	}
}

I have the same .json files as above.

The Error:

[14:53:10] [Server thread/INFO] [FML]: Injecting existing registry data into this server instance
[14:53:10] [Server thread/INFO] [FML]: Registry Block: Found a missing id from the world cullinarycraft:salt_ore
[14:53:10] [Server thread/INFO] [FML]: Registry Item: Found a missing id from the world culinarycraft:salt_ore_item
[14:53:10] [Server thread/ERROR] [FML]: Unidentified mapping from registry minecraft:items
[14:53:10] [Server thread/ERROR] [FML]:     culinarycraft:salt_ore_item: 4096
[14:53:17] [Server thread/INFO] [FML]: World backup created at C:\Users\Big_Bad_E\Desktop\1.12 modding\run\saves\Culinary Craft-20171231-145314.zip.
[14:53:17] [Server thread/ERROR] [FML]: There are unidentified mappings in this world - we are going to attempt to process anyway
[14:53:17] [Server thread/WARN] [FML]: Registry Item: Object did not get ID it asked for. Name: culinarycraft:salt_ore Expected: 4096 Got: 4097
[14:53:17] [Server thread/INFO] [FML]: Applying holder lookups
[14:53:17] [Server thread/INFO] [FML]: Holder lookups applied

My Block Class (salt_ore):

public class SaltOre extends Block {
	public SaltOre(Material material) {
		super(material);
		this.setHarvestLevel("Pickaxe", 2);
		this.setRegistryName("culinarycraft:salt_ore");
		this.setUnlocalizedName(getRegistryName().toString());
	}
}

salt_ore_item was what my registry name for the item was but I removed it completely from my code

Any1 know what i'm doing wrong?

Edited December 31, 2017 by Big_Bad_E

[Big_Bad_E]

I'm just gonna bump this because I still can't find out how to do this. Prob gonna check out some guides or something if no1 responds to see how they do it 

Edited January 1, 2018 by Big_Bad_E

[Terrails]

12 hours ago, Big_Bad_E said:

Yep, forgot to say I subscribed to ModelRegistryEvent and annotated the class with EventBusSubscriber. My problem is not setting the block's texture, that works perfectly, but the ItemBlock. I cannot find a place where that is shown. P.S. I made a class for the block's ItemBlock because if I just made a new ItemBlock I couldn't set the registry name.

you can set the registry name with something like this in Item RegistryEvent

event.getRegistry().register(new ItemBlock(saltore).setRegistryName(saltore.getRegistryName()));

and for the models just use something like this:

for (Block block : ModBlocks.getList()) {
    ModelResourceLocation location = new ModelResourceLocation(block.getRegistryName(), "inventory");
    ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, location);
}
for (Item item : ModItems.getList()) {
    ModelResourceLocation location = new ModelResourceLocation(item.getRegistryName(), "inventory");
    ModelLoader.setCustomModelResourceLocation(item, 0, location);
}

I just iterate through each block/item I have in a list and set their model location

Edited January 1, 2018 by Terrails

[Big_Bad_E]

2 hours ago, diesieben07 said:

You are creating new blocks and items here. These blocks and items are never registered and the blocks and items that you actually registered don't have a model associated with them.

Ahhh, I find a way to mess the whole thing up... thanks for pointing that out, i'm just going to make a list and create the block and add it to the list, and register that block and set that block's model.