[1.12.2] [Solved] Packet Messages and static fields

[GooberGunter]

Hey! I'm trying to figure out if I have this packet done right. Essentially, whenever my custom HUD is drawn on the screen, the client sends a request packet to the server, which replies with server information based on data within the chunk (capability). What I wanna know is if it will work on a server with multiple people, but I can't think of a way to test it. Theoretically, the values in the HUD class are only set when requested by the HUD class, but because the method and storage variable are static, I'm pretty sure it will set the storage variable to that data on every client. 

 

So I guess my question is, am I right about the value setting for all clients? More generalized: does every client have it's own instance of this gui class upon launch, meaning that static doesn't matter? Because if there are two clients, each with the jar file of this mod, then the fetched data from the packet (requested by one client) shouldn't set for both clients, right? I'm still a little unclear on the server/client relationship as well as multiple copies of the mod.

Request Message Class and Message Handler

Spoiler

package com.GooberGunter.GrandSorcery.common.networking.packets;

import com.GooberGunter.GrandSorcery.common.utils.Util;

import io.netty.buffer.ByteBuf;
import net.minecraft.client.Minecraft;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class RequestMessage implements IMessage{
	
	public double x;
	public double z;
	
	public RequestMessage() {
		x=0;
		z=0;
	}
	
	public RequestMessage(double x, double z) {
		this.x=x;
		this.z=z;
	}
	
	
	@Override
	public void fromBytes(ByteBuf buf) {
		this.x = buf.readDouble();
		this.z = buf.readDouble();
		
	}

	@Override
	public void toBytes(ByteBuf buf) {
		buf.writeDouble(x);
		buf.writeDouble(z);
		
	}
	
	
	
}

package com.GooberGunter.GrandSorcery.common.networking.handlers;

import com.GooberGunter.GrandSorcery.common.networking.packets.ElementMessage;
import com.GooberGunter.GrandSorcery.common.networking.packets.RequestMessage;
import com.GooberGunter.GrandSorcery.common.utils.Util;

import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class RequestHandler implements IMessageHandler<RequestMessage, ElementMessage>{

	@Override
	public ElementMessage onMessage(RequestMessage message, MessageContext ctx) {
		return new ElementMessage(message.x, message.z);
		
	}
}

 

Reply Message and Handler classes:

Spoiler

package com.GooberGunter.GrandSorcery.common.networking.packets;

import com.GooberGunter.GrandSorcery.api.arcana.ArcanaProvider;
import com.GooberGunter.GrandSorcery.common.utils.Util;

import io.netty.buffer.ByteBuf;
import net.minecraft.client.Minecraft;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.DimensionType;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.common.DimensionManager;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class ElementMessage implements IMessage{
	
	public ElementMessage() {}
	
	private int f;
	private int a;
	private int ea;
	private int w;
	private int ar;
	private int lf;
	private int dt;
	private int lg;
	private int sh;
	
	public int[] toSend;
	
	public ElementMessage(double x, double z) {
		//TODO DO NOT USE MINECRAFT.GETMINECRAFT() THAT IS CLIENT SIDE
		this.toSend = DimensionManager.getWorld(0).getChunkFromBlockCoords(new BlockPos(x,0,z)).getCapability(ArcanaProvider.ARCANA_CAP, null).getArcana();
				//getChunkFromBlockCoords(new BlockPos(x, 0, z)).getCapability(ArcanaProvider.ARCANA_CAP, null).getArcana();
		//Util.logger.info("PACKET: "+toSend[0]+" "+toSend[1]+" "+toSend[2]+" "+toSend[3]+" "+toSend[4]);
		//Util.logger.info("PACKET: "+x+" "+z);
		f=0;
		a=0;
		ea=0;
		w=0;
		ar=0;
		lf=0;
		dt=0;
		lg=0;
		sh=0;
		
	}
	
	@Override
	public void fromBytes(ByteBuf buf) {
		// TODO Auto-generated method stub
		f=buf.readInt();
		a=buf.readInt();
		ea=buf.readInt();
		w=buf.readInt();
		ar=buf.readInt();
		lf=buf.readInt();
		dt=buf.readInt();
		lg=buf.readInt();
		sh=buf.readInt();
		int[] tempboi = {f,a,ea,w,ar, lf, dt, lg, sh};
		toSend = tempboi;
	}

	@Override
	public void toBytes(ByteBuf buf) {
		if(toSend == null) {
			return;
		}
		if(toSend.length==9) {
			f=toSend[0];
			a=toSend[1];
			ea=toSend[2];
			w=toSend[3];
			ar=toSend[4];
			lf=toSend[5];
			dt=toSend[6];
			lg=toSend[7];
			sh=toSend[8];
		}
		buf.writeInt(f);
		buf.writeInt(a);
		buf.writeInt(ea);
		buf.writeInt(w);
		buf.writeInt(ar);
		buf.writeInt(lf);
		buf.writeInt(dt);
		buf.writeInt(lg);
		buf.writeInt(sh);
	}

	

}

package com.GooberGunter.GrandSorcery.common.networking.handlers;

import com.GooberGunter.GrandSorcery.client.hud.GuiArcanometer;
import com.GooberGunter.GrandSorcery.common.networking.packets.ElementMessage;

import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class ElementMessageHandler implements IMessageHandler<ElementMessage, IMessage>{
	
	int[] elementReceived;
	
	@Override
	public IMessage onMessage(ElementMessage message, MessageContext ctx) {
		//TODO check if this still works with multiple players
		GuiArcanometer.setStorage(message.toSend);
		
		return null;
	}

}

 

Gui HUD class:

Spoiler

package com.GooberGunter.GrandSorcery.client.hud;

import org.lwjgl.opengl.GL11;

import com.GooberGunter.GrandSorcery.GSReferences;
import com.GooberGunter.GrandSorcery.GrandSorcery;
import com.GooberGunter.GrandSorcery.api.arcana.ArcanaProvider;
import com.GooberGunter.GrandSorcery.api.arcana.IArcana;
import com.GooberGunter.GrandSorcery.common.items.ModItems;
import com.GooberGunter.GrandSorcery.common.networking.GrandSorceryPacketHandler;
import com.GooberGunter.GrandSorcery.common.networking.packets.RequestMessage;
import com.GooberGunter.GrandSorcery.common.utils.Util;

import net.minecraft.client.Minecraft;
import net.minecraft.client.gui.FontRenderer;
import net.minecraft.client.gui.Gui;
import net.minecraft.client.gui.ScaledResolution;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.client.event.RenderGameOverlayEvent;
import net.minecraftforge.client.event.RenderGameOverlayEvent.ElementType;
import net.minecraftforge.event.world.WorldEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class GuiArcanometer extends Gui{
	
	private static int[] storage= {0,0,0,0,0,0,0,0,0};
	
	public static void render(Minecraft mc) {
		FontRenderer renderer = mc.fontRenderer;
		ScaledResolution scaledresolution = new ScaledResolution(mc);
		GrandSorceryPacketHandler hander = GrandSorcery.handler;
		
		mc.getTextureManager().bindTexture(new ResourceLocation(GSReferences.MODID+":textures/gui/arcanometer.png"));
 		drawModalRectWithCustomSizedTexture(scaledresolution.getScaledWidth()-96, 0, 96, 48, 96, 48, 96, 48);
 		hander.INSTANCE.sendToServer(new RequestMessage(mc.player.getPosition().getX(), mc.player.getPosition().getZ()));
 		//Util.logger.info("HANDLER: "+mc.player.getPosition().getX()+" "+mc.player.getPosition().getZ());
 		
 		//water
 		if(storage[3]>9) {
 			renderer.drawString(Integer.toString(storage[3]), scaledresolution.getScaledWidth()-88.5f, 28.5f, 0x0000ee, false);
		}else { renderer.drawString(Integer.toString(storage[3]), scaledresolution.getScaledWidth()-85.5f, 28.5f, 0x0000ee, false);}
 		
 		//air
 		if(storage[1]>9) {
 			renderer.drawString(Integer.toString(storage[1]), scaledresolution.getScaledWidth()-74.5f, 23f, 0x00ffc5, false);
		}else { renderer.drawString(Integer.toString(storage[1]), scaledresolution.getScaledWidth()-71.5f, 23f, 0x00ffc5, false);}
 		
 		//arcana
 		if(storage[4]>9) {
 			renderer.drawString(Integer.toString(storage[4]), scaledresolution.getScaledWidth()-53.25f, 13f, 0x6A0090, false);
		}else { renderer.drawString(Integer.toString(storage[4]), scaledresolution.getScaledWidth()-50.25f, 13f, 0x6A0090, false);}
 		
 		//earth
 		if(storage[2]>9) {
 			renderer.drawString(Integer.toString(storage[2]), scaledresolution.getScaledWidth()-32.5f, 23f, 0x793810, false);
		}else { renderer.drawString(Integer.toString(storage[2]), scaledresolution.getScaledWidth()-29.5f, 23f, 0x793810, false);}
 		
 		//fire
 		if(storage[0]>9) {
 			renderer.drawString(Integer.toString(storage[0]), scaledresolution.getScaledWidth()-18.5f, 28.5f, 0xff0000, false);
		}else { renderer.drawString(Integer.toString(storage[0]), scaledresolution.getScaledWidth()-15.5f, 28.5f, 0xff0000, false);}
 		
 		
 		
	}
	
	public static void setStorage(int[] io) {
		storage = io;
		//Util.logger.info("STORAGE: "+storage[0]+" "+storage[1]+" "+storage[2]+" "+storage[3]+" "+storage[4]);
	}
	
	public static int[] getStorage() {
		if(storage != null) {
			return storage;
		}else {int[] x = {0,0,0,0,0}; return x;}
	}
	
	
	
	
}

 

 

Edited January 20, 2018 by GooberGunter

[Leviathan143]

34 minutes ago, GooberGunter said:

Hey! I'm trying to figure out if I have this packet done right. Essentially, whenever my custom HUD is drawn on the screen, the client sends a request packet to the server, which replies with server information based on data within the chunk (capability). What I wanna know is if it will work on a server with multiple people, but I can't think of a way to test it. Theoretically, the values in the HUD class are only set when requested by the HUD class, but because the method and storage variable are static, I'm pretty sure it will set the storage variable to that data on every client. 

 

So I guess my question is, am I right about the value setting for all clients? More generalized: does every client have it's own instance of this gui class upon launch, meaning that static doesn't matter? Because if there are two clients, each with the jar file of this mod, then the fetched data from the packet (requested by one client) shouldn't set for both clients, right? I'm still a little unclear on the server/client relationship as well as multiple copies of the mod.

The effects of the static modifier are restricted to a single JVM. The server and each client all run separate instances of Minecraft in separate JVMs. There is no synchronisation of instances or member values between separate JVMs by default. If any exists it is because it has been explicitly and deliberately programmed by Mojang, Forge or you. Neither Mojang or Forge autosynchronise static member values. Separate JVMs do not talk to each other at all, in any way, ever, unless explicitly and deliberately told to do so and how to do so.

[GooberGunter]

Ok, that's what I thought. Thanks for clearing that up.

[GooberGunter]

Actually, now that you mention it. If I have packets being sent from server to client. If the mod is being run on a physical server, are the packets being sent from the "logical server" on the physical client or if a dedicated server is detected, from the physical server to the physical client. I remember reading the forge documentation and it eluded to it but didn't give immense detail.

[Leviathan143]

Can you rephrase that please? It's not clear what you're asking.

Edited January 20, 2018 by Leviathan143

[GooberGunter]

Does the logical server on the physical client sync up with the physical server? This seems like a dumb question

 

 

[Choonster]

1 minute ago, GooberGunter said:

Does the logical server on the physical client sync up with the physical server? This seems like a dumb question

 

There's only one logical server running at a time. In single player and LAN, the logical server is running in the physical client of the host. In multiplayer, the logical server is running in the physical (dedicated) server.

[Leviathan143]

It doesn't need to. The logical server is part of the physical server process. The same goes for the client, the logical client is part of the physical client process.

You seem confused about sides, I recommend you read this, even if you've read it already. It gives a pretty thorough explanation of logical and physical sides.

Edited January 20, 2018 by Leviathan143

[GooberGunter]

OH, Ok. It’s been such a long time since I’ve heard of threads, but I just got it. I have a much better understanding of the two sides as well as the practicality of threads. Thanks a lot!